Intent to Implement and Ship: CSS font-variant-east-asian

[Koji Ishii]

Contact emails

ko...@chromium.org, dr...@chromium.org

Spec
https://drafts.csswg.org/css-fonts-3/#font-variant-east-asian-prop

Summary
Add support for font-variant-east-asian and respective mapping from the font: CSS shorthand and into the font-variant: shorthand.

Following font-variant-caps, font-variant-ligatures, and font-variant-numeric, this property fills in yet another gap to the spec.

Motivation

Using the CSS keywords for feature selection is at candidate recommendation status in the CSS Fonts Module level 3 and is the spec recommended way to activate common features:

"Authors should generally use ‘font-variant’ and its related subproperties whenever possible and only use this property for special cases where its use is the only way of accessing a particular infrequently used font feature."

Signals from content developers and font foundries indicate that the CSS font-variant-* value keywords are easier to work with and less cryptic than font-feature settings.

Interoperability risk
Firefox: Shipped
Edge: No public signals
Safari: Shipped
Web developers: Positive

Compatibility risk
None.

Ongoing technical constraints
None.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,
Chrome OS, Android, and Android WebView)? Yes or no.
Yes.

OWP launch tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=755462

Link to entry on the Chrome Platform Status
https://www.chromestatus.com/features/4965040604053504

Requesting approval to ship?
Yes.

[Dimitri Glazkov]

LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACQRE%2BQV8saR7om1SiifvMmpcoGxo9uU9hc1fzXwkbHnMiR-eQ%40mail.gmail.com.

[TAMURA, Kent]

LGTM2.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOtFfx4p_zh_n%3D2KciykXNX1QpB5uim2vqp8MNXtnHDgW9s63A%40mail.gmail.com.

--

TAMURA Kent
Software Engineer, Google

[Philip Jägenstedt]

LGTM3

Is the coverage for this in web-platform-tests already sufficient? http://wpt.fyi/css/css-fonts-3 has a bunch of tests that Firefox are passing, but Safari has rather many failures, any idea why? In any event, the more cross-browser green the merrier.

There are also some tests in http://wpt.fyi/css/vendor-imports/mozilla/mozilla-central-reftests/text-decor-3 that do something with this features, might be worth checking if any of those are good tests that should be moved to a better location.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqF7-xXv7Xgj%2BY7jrmPPdHt6qgZCsvZCKqc3GxAu7CEjVA%40mail.gmail.com.

[Koji Ishii]

On Wed, Aug 23, 2017 at 9:33 PM, Philip Jägenstedt <foo...@chromium.org> wrote:

Is the coverage for this in web-platform-tests already sufficient?

​I think so. The spec is trying to exit CR and to move to PR/REC, this property is specifically desired since it has two impls.​ As we implement, if there were any missing tests for our code paths, I can submit them.

http://wpt.fyi/css/css-fonts-3 has a bunch of tests that Firefox are passing, but Safari has rather many failures, any idea why?

​​

In any event, the more cross-browser green the merrier.

I wasn't aware of this page. Tested a few on Safari Tech Preview and they failed. Chris or Myles, do you happen to know?​

I don't know how this result is updated, but Chrome is supposed to pass many of them, since we have shipped 3 other variant properties. We import css-fonts-3 and our bots pass them.

There are also some tests in http://wpt.fyi/css/vendor-imports/mozilla/mozilla-central-reftests/text-decor-3 that do something with this features, might be worth checking if any of those are good tests that should be moved to a better location.

​Thank you for the info, I'll check.​ I have to admit that our support on text-decor-3 isn't great yet, supporting this property may or may not pass.

[Philip Jägenstedt]

On Wed, Aug 23, 2017 at 2:57 PM Koji Ishii <ko...@chromium.org> wrote:

On Wed, Aug 23, 2017 at 9:33 PM, Philip Jägenstedt <foo...@chromium.org> wrote:

Is the coverage for this in web-platform-tests already sufficient?

​I think so. The spec is trying to exit CR and to move to PR/REC, this property is specifically desired since it has two impls.​ As we implement, if there were any missing tests for our code paths, I can submit them.

http://wpt.fyi/css/css-fonts-3 has a bunch of tests that Firefox are passing, but Safari has rather many failures, any idea why?

​​

In any event, the more cross-browser green the merrier.

I wasn't aware of this page. Tested a few on Safari Tech Preview and they failed. Chris or Myles, do you happen to know?​

I don't know how this result is updated, but Chrome is supposed to pass many of them, since we have shipped 3 other variant properties. We import css-fonts-3 and our bots pass them.

That's odd, I filed https://github.com/GoogleChrome/wptdashboard/issues/97. I see that the very first test (alternates-order.html) is expected to fail in TestExpectations, so asked you on the bug for help finding an example of this.