Intent to Remove: SVGZoomEvent

52 visualizzazioni
Passa al primo messaggio da leggere

Shanmuga

da leggere,
12 lug 2016, 06:06:1312/07/16
a blink-dev

Primary eng (and PM) emails

da...@opera.com, shanm...@samsung.com



Link to “Intent to Deprecate” thread

https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5PEUh2qHa7c/IUGlM4a9CQAJ

 

Summary

Remove the SVGZoomEvent interface and the corresponding onzoom attribute. 



Motivation

SVGZoomEvent doesn't work at all in Blink. It can be created and hooked up using onzoom="..." but it is never fired by the browser.

 

It has been removed from the SVG 2.0 specification:

 

https://github.com/w3c/svgwg/issues/21

https://github.com/w3c/svgwg/commit/3844475c05b865e961a0bc52cd63e627412360e2



Compatibility Risk

A httparchive search has been conducted:

https://code.google.com/p/chromium/issues/detail?id=367890#c11

indicating very low usage. From the search it looks likely that the event is possible to remove.

The interface has been around in WebKit and Blink for a long time. Originates in:

https://bugs.webkit.org/show_bug.cgi?id=10826

 

Usage information from UseCounter

https://www.chromestatus.com/metrics/feature/timeline/popularity/1232

 

OWP launch tracking bug

No OWP launch tracking bug but there is:

https://code.google.com/p/chromium/issues/detail?id=367890



Entry on the feature dashboard

https://www.chromestatus.com/feature/5760883808534528



Requesting approval to remove too?

Yes, M52 is the suggested milestone.

Philip Jägenstedt

da leggere,
12 lug 2016, 06:33:4112/07/16
a Shanmuga, blink-dev
LGTM1

Can you update https://www.chromestatus.com/feature/5760883808534528 with the actual removal milestone, which will be M54?

(Given the extremely low usage, I don't think it's worthwhile in this case to update the deprecation message for a release cycle.)

Shanmuga

da leggere,
12 lug 2016, 06:37:5312/07/16
a blink-dev, shanm...@samsung.com
Updated the milestone to M54

Shanmuga

da leggere,
12 lug 2016, 09:19:5212/07/16
a blink-dev, shanm...@samsung.com

Rick Byers

da leggere,
12 lug 2016, 09:24:3512/07/16
a Shanmuga, blink-dev

LGTM2

Philip Jägenstedt

da leggere,
13 lug 2016, 05:16:4613/07/16
a Rick Byers, Shanmuga, blink-dev
I didn't mention waiting for 3xLGTM when I reviewed https://codereview.chromium.org/2133983003/, so it has already landed. Since this intent seems 99% likely to pass I suggested leaving it in, but a 3rd LGTM is still needed here. Oops :)

Jochen Eisinger

da leggere,
13 lug 2016, 05:22:2013/07/16
a Philip Jägenstedt, Rick Byers, Shanmuga, blink-dev
lgtm3
Rispondi a tutti
Rispondi all'autore
Inoltra
0 nuovi messaggi