--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADZ1XibPV%3Dd448fckQeYFaO617_9aahsxysAjMEdQ4sy%3DQw4kQ%40mail.gmail.com.
I'm not sure we should do this for build time reasons alone. `use_v8_context_snapshot` is the default behaviour in shipping browsers, and it makes the renderer take quite a different path during page load / navigation. If we disable it in regular builds, then regular builds (including all the dchecks!) won't be running and texting the same code that we're shipping.
The fact that tests are failing with this flag change should be a huge flashing red light about this proposal - if we make the tests not test the code we're shipping, then we risk it breaking without us noticing. Indeed, I've been trying to turn this flag on for Android, and have been struggling to do so.
- Leszek
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHgVhZU-er_dfh_esgBmfLQ%2BOVf24y2yN7K6W6yjGqNkH%3Df%3D6w%40mail.gmail.com.