Intent to Ship: CSS Automatic Hyphenation for Windows/Linux/ChromeOS

238 views
Skip to first unread message

Koji Ishii

unread,
Oct 14, 2020, 1:55:03 PM10/14/20
to blink-dev

Contact emails

ko...@chromium.org


Specification

https://drafts.csswg.org/css-text-3/#propdef-hyphens

Summary

Blink supports `manual` and `none` values of the CSS `hyphens` property since M55, but `auto`, which enables the automatic hyphenation, is supported only on Android and Mac. This feature enables `hyphens: auto` on Windows, Linux, and ChromeOS by using dictionaries used in Android Open Source Project. The previous feature entry for M55 is https://www.chromestatus.com/features/5642121184804864



Blink component

Blink

TAG review

None

TAG review status

Not applicable

Risks

Interoperability and Compatibility

I don't think there are interoperability and compatibility risks because Blink is already shipping in 2 platforms, and also other browsers are already shipping.

Gecko: Shipped/Shipping
WebKit: Shipped/Shipping
Web developers: Strongly positive, the tracking bug has 339 stars.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes. Android and Mac are already shipping in M55.


Is this feature fully tested by web-platform-tests?

Yes

Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=652964

Launch bug

https://bugs.chromium.org/p/chromium/issues/detail?id=652964

Link to entry on the Chrome Platform Status

https://www.chromestatus.com/feature/5672891947417600

Yoav Weiss

unread,
Oct 15, 2020, 5:48:35 AM10/15/20
to Koji Ishii, blink-dev
LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACQRE%2BSLsj8W9YAu_7%3DxJUqH%2BzYpPM0tAx4dqKmGa4QdPKJ%2B3A%40mail.gmail.com.

Thomas Steiner

unread,
Oct 15, 2020, 5:52:58 AM10/15/20
to Koji Ishii, blink-dev
Non-owner LGTM. Thanks for finally shipping this useful feature! 

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACQRE%2BSLsj8W9YAu_7%3DxJUqH%2BzYpPM0tAx4dqKmGa4QdPKJ%2B3A%40mail.gmail.com.


--
Thomas Steiner, PhD—Developer Advocate (https://blog.tomayac.com, https://twitter.com/tomayac)

Google Germany GmbH, ABC-Str. 19, 20354 Hamburg, Germany
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.23 (GNU/Linux)

iFy0uwAntT0bE3xtRa5AfeCheCkthAtTh3reSabiGbl0ck0fjumBl3DCharaCTersAttH3b0ttom.hTtPs://xKcd.cOm/1181/
-----END PGP SIGNATURE-----

Mike West

unread,
Oct 15, 2020, 2:14:15 PM10/15/20
to blink-dev, Thomas Steiner, blink-dev, Koji Ishii
LGTM2. Aligning our behavior across platforms is a net positive for developers; doubly so when we're also aligning with other vendors.

-mike

Daniel Bratell

unread,
Oct 15, 2020, 2:58:32 PM10/15/20
to blink-dev, mk...@chromium.org, Thomas Steiner, blink-dev, Koji Ishii
LGTM3

/Daniel

Matt Menke

unread,
Oct 16, 2020, 11:38:23 AM10/16/20
to blink-dev, Koji Ishii
Are different dictionaries used based on user language/locale, or is there a single universal dictionary?  Just wondering if this is yet another way for sites to deduce information about a user's localization settings.

Koji Ishii

unread,
Oct 16, 2020, 2:00:55 PM10/16/20
to Matt Menke, blink-dev, Koji Ishii
Are different dictionaries used based on user language/locale, or is there a single universal dictionary?  Just wondering if this is yet another way for sites to deduce information about a user's localization settings.

Different dictionaries based on the content locale. We will use the same engine and dictionaries as Android Open Source Project.

fantasai

unread,
Oct 19, 2020, 3:01:48 PM10/19/20
to Koji Ishii, Matt Menke, blink-dev
> <https://android.googlesource.com/platform/external/hyphenation-patterns/+/refs/heads/master>.

Are you enabling hyphenation on untagged content, or only on language-tagged
content (per spec)?

~fantasai

Koji Ishii

unread,
Oct 20, 2020, 2:43:36 AM10/20/20
to fantasai, Koji Ishii, Matt Menke, blink-dev
Are you enabling hyphenation on untagged content, or only on language-tagged
content (per spec)?

There's an issue filed for that, please see crbug.com/676270.

fantasai

unread,
Oct 21, 2020, 11:00:43 PM10/21/20
to blin...@chromium.org, Yoav Weiss, Mike West, Daniel Bratell
> <http://crbug.com/676270>.

I see. Then, I don't think this should be shipped until this bug is fixed.

It is not only a spec violation but
* It creates bugwards-compat pressure when it does.
* It exacerbates existing non-interop among browsers.
* It can cause readability problems if the heuristic
doesn't match the actual content language.
* Because it depends on the system configuration,
it also causes interop problems between users using
the *same browser* on differently-configured systems!
* Lastly, using the system language in such cases adds
additional fingerprinting surface.

~fantasai

PhistucK

unread,
Oct 22, 2020, 4:23:42 AM10/22/20
to fantasai, blink-dev, Yoav Weiss, Mike West, Daniel Bratell
While I do not see the point of blocking shipping expanded support for this feature due to this bug (since most users are probably on Android anyway, it would not matter much), I do think it should be highly prioritized.

PhistucK


--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Yoav Weiss

unread,
Oct 22, 2020, 4:43:48 AM10/22/20
to PhistucK, fantasai, blink-dev, Mike West, Daniel Bratell
I agree this should not be a blocker for this intent, which is merely extending platform support for the feature.
At the same time, it would be good to fix such compatibility issues.

j.j.

unread,
Oct 22, 2020, 1:28:38 PM10/22/20
to blink-dev, phis...@gmail.com, fantasa...@inkedblade.net, mk...@google.com, brat...@gmail.com


Am Donnerstag, 22. Oktober 2020 10:43:48 UTC+2 schrieb Yoav Weiss:
I agree this should not be a blocker for this intent, which is merely extending platform support for the feature.

I think crbug.com/676270 should block shipping. Author may start using this feature for desktop sites and have expected results without a lang attribute in Chromium browsers (only). When that  bug is fixed, they have to change their code.

j.j.
 

On Thu, Oct 22, 2020 at 10:23 AM PhistucK <phis...@gmail.com> wrote:
While I do not see the point of blocking shipping expanded support for this feature due to this bug (since most users are probably on Android anyway, it would not matter much), I do think it should be highly prioritized.

PhistucK


On Thu, Oct 22, 2020 at 6:00 AM fantasai <fantas...@inkedblade.net> wrote:
On 10/19/20 11:43 PM, Koji Ishii wrote:
 > > Are you enabling hyphenation on untagged content, or only on language-tagged
 > > content (per spec)?
 >
 > There's an issue filed for that, please see crbug.com/676270
 > <http://crbug.com/676270>.

I see. Then, I don't think this should be shipped until this bug is fixed.

It is not only a spec violation but
  * It creates bugwards-compat pressure when it does.
  * It exacerbates existing non-interop among browsers.
  * It can cause readability problems if the heuristic
     doesn't match the actual content language.
  * Because it depends on the system configuration,
     it also causes interop problems between users using
     the *same browser* on differently-configured systems!
  * Lastly, using the system language in such cases adds
     additional fingerprinting surface.

~fantasai

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.

Koji Ishii

unread,
Oct 23, 2020, 9:57:34 AM10/23/20
to j.j., blink-dev, PhistucK, fantasai, Mike West, Daniel Bratell
I think we'll look at it soon.

Blink and WebKit can apply incorrect dictionaries for the lack of the feature today, but Gecko doesn't do so. I agree it's a good feature. Thank you for helping to make Chromium better.

2020年10月23日(金) 2:28 j.j. <fri...@jeka.info>:
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/53bbdc1b-77ad-4092-92cc-7dcd7e60b744o%40chromium.org.

Koji Ishii

unread,
Nov 2, 2020, 1:25:46 PM11/2/20
to Koji Ishii, j.j., blink-dev, PhistucK, fantasai, Mike West, Daniel Bratell
We've fixed crbug.com/676270 for M88, the fix is available in Canary 88.0.4313.0. Thank you for the feedback.

2020年10月23日(金) 22:57 Koji Ishii <ko...@chromium.org>:
Reply all
Reply to author
Forward
0 new messages