PSA: when you're running layout tests, build the target all_webkit EOM

[Jochen Eisinger]

[Adam Klein]

Stupid question: why not all_blink?

On Wed, Nov 6, 2013 at 2:46 AM, Jochen Eisinger <joc...@chromium.org> wrote:

[Jochen Eisinger]

all_blink was already taken at that time (both targets were introduced right after the fork), and updating targets that are also mentioned in the buildbot configs is not exactly fun.

Note that "you should build all_webkit" is nothing new, it was maybe not communicated clearly enough when we introduced it :)

best

-jochen

[Adam Barth]

all_blink builds all the targets in the Blink repo, which isn't enough to run layout tests because you'll be missing content_shell.  Maybe we should come up with a new name for the target you need to run layout tests?

Adam

[Emil A Eklund]

How about layout_tests?

[Adam Barth]

On Wed, Nov 6, 2013 at 10:05 AM, Emil A Eklund <e...@chromium.org> wrote:

How about layout_tests?

Sounds good to me.

Adam

[Jochen Eisinger]

Currently, this target would compile all_webkit without the unit tests. Is this what you intend?

Best
Jochen

[Dimitri Glazkov]

blink_tests? :)

I really hope we could start running unit tests alongside layout tests as part of run-blink-tests at some point.

:DG<

[Adam Barth]

Maybe call it blink_tests (as Dimitri suggests) and include the unit tests?

Adam

[Adam Klein]

+1 to blink_tests; that seems more in line with Chromium's target naming. In Chromium, 'all' is a scary target, _tests are the things you build.

[Jochen Eisinger]

So the proposal is to rename all_webkit to blink_tests? sounds reasonable

[Jochen Eisinger]

https://codereview.chromium.org/59233012