Intent to Implement and Ship: Remove 'no-preference' from prefers-color-scheme @media feature

[Rune Lillesveen]

Contact emails fut...@chromium.org

Design docs/spec Specification: https://drafts.csswg.org/mediaqueries-5/#prefers-color-scheme Summary The prefers-color-scheme feature in Media Queries Level 5 supported three values: 'no-preference', 'light', 'dark'. Remove the support for the 'no-preference' value because it has been removed from the specification. Motivation The value has been removed from the spec. We did not report 'no-preference' for any OS. Risks

Interoperability and Compatibility We do report 'no-preference' when doing forced darkening in Android WebView. Reporting 'light' instead is likely an improvement. As a note, we tried to report 'no-preference' for printing, but found that it wasn't web compatible as content already relies on the value being either light or dark. Firefox: Public support (https://groups.google.com/a/chromium.org/d/msg/blink-dev/3RhZFvZE1LM/t7BpLBWkAwAJ) Firefox want to remove this as well. See link. Edge: Public support (https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-634779976) almaher@ was OK with the resolution per meeting notes. Safari: Public support (https://lists.webkit.org/pipermail/webkit-dev/2020-June/031229.html) I have asked on webkit-dev@, but there is previous statement from Apple from a discussion a year ago: "hober: We have no notion of no-preference on our platforms. At OS install time, we prompt the user to pick light or dark. You have to to move on to the next screen. There is no system concept of no preference. We're not interested in pretending otherwise." See: https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-499261339 Web developers: No signals

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested by web-platform-tests? Yes Test changes already landed: https://chromium-review.googlesource.com/c/chromium/src/+/2232924 Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1091806 Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5719782840074240

This intent message was generated by Chrome Platform Status.

[Yoav Weiss]

LGTM1

On Mon, Jun 8, 2020 at 4:15 PM Rune Lillesveen <fut...@chromium.org> wrote:

Contact emails fut...@chromium.org

Design docs/spec Specification: https://drafts.csswg.org/mediaqueries-5/#prefers-color-scheme Summary The prefers-color-scheme feature in Media Queries Level 5 supported three values: 'no-preference', 'light', 'dark'. Remove the support for the 'no-preference' value because it has been removed from the specification. Motivation The value has been removed from the spec. We did not report 'no-preference' for any OS. Risks

Interoperability and Compatibility We do report 'no-preference' when doing forced darkening in Android WebView. Reporting 'light' instead is likely an improvement. As a note, we tried to report 'no-preference' for printing, but found that it wasn't web compatible as content already relies on the value being either light or dark. Firefox: Public support (https://groups.google.com/a/chromium.org/d/msg/blink-dev/3RhZFvZE1LM/t7BpLBWkAwAJ)

I don't think that counts as "public support" (as it's not on their "standards position" repo), but we can probably regard this as "positive signals".

Firefox want to remove this as well. See link. Edge: Public support (https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-634779976) almaher@ was OK with the resolution per meeting notes. Safari: Public support (https://lists.webkit.org/pipermail/webkit-dev/2020-June/031229.html) I have asked on webkit-dev@, but there is previous statement from Apple from a discussion a year ago: "hober: We have no notion of no-preference on our platforms. At OS install time, we prompt the user to pick light or dark. You have to to move on to the next screen. There is no system concept of no preference. We're not interested in pretending otherwise." See: https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-499261339 Web developers: No signals

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested by web-platform-tests? Yes Test changes already landed: https://chromium-review.googlesource.com/c/chromium/src/+/2232924 Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1091806 Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5719782840074240

This intent message was generated by Chrome Platform Status.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeQ%2BCaHw_N66%2B846ZgaswVjSkKUPvuWGWpE6DUS%2BNgQrnw%40mail.gmail.com.

[Manuel Rego Casasnovas]

LGTM2

On 08/06/2020 16:28, Yoav Weiss wrote:
> LGTM1
>
> On Mon, Jun 8, 2020 at 4:15 PM Rune Lillesveen <fut...@chromium.org

> <mailto:fut...@chromium.org>> wrote:
>
> Contact emails...@chromium.org <mailto:fut...@chromium.org>
> Design docs/specSpecification:
> https://drafts.csswg.org/mediaqueries-5/#prefers-color-schemeSummaryThe

> prefers-color-scheme feature in Media Queries Level 5 supported
> three values: 'no-preference', 'light', 'dark'. Remove the support
> for the 'no-preference' value because it has been removed from the

> specification. MotivationThe value has been removed from the spec.

> We did not report 'no-preference' for any OS. Risks
> Interoperability and Compatibility We do report 'no-preference' when
> doing forced darkening in Android WebView. Reporting 'light' instead
> is likely an improvement. As a note, we tried to report
> 'no-preference' for printing, but found that it wasn't web
> compatible as content already relies on the value being either light

> or dark. /Firefox/: Public support

> (https://groups.google.com/a/chromium.org/d/msg/blink-dev/3RhZFvZE1LM/t7BpLBWkAwAJ)
>
>
> I don't think that counts as "public support" (as it's not on their
> "standards position" repo), but we can probably regard this as "positive
> signals".
>

> Firefox want to remove this as well. See link. /Edge/: Public
> support
> (https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-634779976)
> almaher@ was OK with the resolution per meeting notes. /Safari/:

> Public support
> (https://lists.webkit.org/pipermail/webkit-dev/2020-June/031229.html) I
> have asked on webkit-dev@, but there is previous statement from
> Apple from a discussion a year ago: "hober: We have no notion of
> no-preference on our platforms. At OS install time, we prompt the
> user to pick light or dark. You have to to move on to the next
> screen. There is no system concept of no preference. We're not
> interested in pretending otherwise." See:
> https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-499261339

> /Web developers/: No signals

> Will this feature be supported on all six Blink platforms (Windows,

> Mac, Linux, Chrome OS, Android, and Android WebView)?Yes Is this

> feature fully tested by web-platform-tests

> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?Yes

> Test changes already landed:
> https://chromium-review.googlesource.com/c/chromium/src/+/2232924Tracking
> bughttps://bugs.chromium.org/p/chromium/issues/detail?id=1091806Link
> to entry on the Chrome Platform

> Statushttps://chromestatus.com/feature/5719782840074240

> This intent message was generated by Chrome Platform Status

> <https://www.chromestatus.com/>.

>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org

> <mailto:blink-dev+...@chromium.org>.

> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeQ%2BCaHw_N66%2B846ZgaswVjSkKUPvuWGWpE6DUS%2BNgQrnw%40mail.gmail.com

> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeQ%2BCaHw_N66%2B846ZgaswVjSkKUPvuWGWpE6DUS%2BNgQrnw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org

> <mailto:blink-dev+...@chromium.org>.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjkiVAB1bH7hEpj15qpgsW5wDroF3FUnWNWKKngcep_pw%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjkiVAB1bH7hEpj15qpgsW5wDroF3FUnWNWKKngcep_pw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

[Chris Harrelson]

LGTM3

--

You received this message because you are subscribed to the Google Groups "blink-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeQ%2BCaHw_N66%2B846ZgaswVjSkKUPvuWGWpE6DUS%2BNgQrnw%40mail.gmail.com.