WebView Origin Trials enabled on 103 beta

[Peter Birk Pakkenberg]

Hello blink-dev@

We have now enabled origin trials on WebView for 103 beta.

We aim to enable it on the stable channel in 104.

Please note that due to the limited beta channel penetration for WebView, you may not see much traffic on your trials yet.

Sincerely,

Peter Birk Pakkenberg Software Engineer pb...@google.com +447469379358

[Mike Taylor]

This is really cool - thanks!

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACvTYjvqy7DZsGq9_efaS-E2y7niTFxVkCqsd3BYrN41qv8oAw%40mail.gmail.com.

[Christian Biesinger]

Can you just clarify -- will a platform of "Android" enable an OT on webview as well? If yes is there a way not to do that?

Christian

--

[Peter Birk Pakkenberg]

Hi Christian,

Certainly. 

The answer is currently yes and no, respectively. Webview shares the android build target, so they are tied together right now.

Do you have a specific trial that you are concerned about? If the trial in question requires implementation in the embedder, then it's still possible to simply not provide any implementation for the WebView embedder, which will make the trial a no-op on that platform.

If the trial exists entirely in shared code, then we would prefer that the trial goes ahead on WebView along with the rest of the Android platform, since that means it will be enabled on WebView when the feature launches, and in my opinion it would be better to have the feature tested before launching it, which is not happening today.

Sincerely,

Peter Birk Pakkenberg Software Engineer pb...@google.com +447469379358

[Christian Biesinger]

Yes, my concern is the "FedCm" origin trial.

In particular, webview will not have an implementation on the embedder side, so the API will not work. But since the origin trial code does not know that, the API will still be exposed to websites. This means the website can not do feature detection and calling the API will just not work. This is an unfortunate state of affairs and may actually break real-world websites.

(Thinking of the [RuntimeEnabled] attribute in IDL)

[Peter Birk Pakkenberg]

Hi Christian,

I can see the issue. Do you already have a solution to ensure that the interface won't be available for WebView once the feature is fully released, and is it the case that the Origin Trial overrides this solution?

Sincerely,

Peter Birk Pakkenberg Software Engineer pb...@google.com +447469379358

[Christian Biesinger]

We are planning to use something like this:

https://chromium-review.googlesource.com/c/chromium/src/+/3565637

However, yes, I do think OT will override that.

Christian

[Peter Birk Pakkenberg]

Hi Mike,

Yes, you are correct, the origin trial will most likely override that.

Sorry for the back and forth. 

You can disable origin trials for WebView explicitly in aw_main_delegate.cc. Take a look at this CL, where they set the embedder_support::kOriginTrialDisabledFeatures command line flag and add the name of the origin trial to disable.

In their case they wanted to be able to test, which is why they have guarded the append by the check to see if it's already there, but in your case, it probably makes sense to make it an unconditional append, as long as you do it after their check.

Let me know if that works for you.

Sincerely,

Peter Birk Pakkenberg Software Engineer pb...@google.com +447469379358

[Christian Biesinger]

Hi Peter,

it seems your link was broken and I haven't been able to find such code separately, could you send the correct link? Thanks!

Christian

On Wed, Jun 29, 2022 at 6:38 AM Peter Birk Pakkenberg <pb...@google.com> wrote:

Hi Mike,

(huh)

[Peter Birk Pakkenberg]

Apologies, here is the full link: 

https://chromium-review.googlesource.com/c/chromium/src/+/3708942/3/android_webview/lib/aw_main_delegate.cc  

Sincerely,

Peter Birk Pakkenberg Software Engineer pb...@google.com +447469379358

[Christian Biesinger]

Thank you!

Christian