Intent to Ship: droppedEntriesCount in PerformanceObserver callback

52 views
Skip to first unread message

Nicolás Peña

unread,
May 6, 2021, 4:14:38 PMMay 6
to blink-dev

Contact emails

n...@chromium.org

Explainer


https://github.com/npm1/hasDroppedEntry/blob/master/README.md

Specification

https://w3c.github.io/performance-timeline/#dom-performanceobservercallbackoptions-droppedentriescount

API spec

Yes

Summary

Currently, web developers can use PerformanceObserver with the buffered flag to listen to past and future performance entries about their site. However, past entries need to be stored, and there is a buffer size limit. The droppedEntriesCount parameter helps developers know if they may have lost an entry due to this storage being full. It's set to the number of entries which got dropped from the buffer due to such a buffer being full.



Blink component

Blink>PerformanceAPIs

TAG review

https://github.com/w3ctag/design-reviews/issues/547

TAG review status

Issues addressed

Risks



Interoperability and Compatibility

This is a low risk feature. A developer using this feature will need to check that the options parameter in the callback is not undefined (to feature detect), and then obtain the droppedEntriesCount from it. It is simple to implement and user agents have followed along with implementing the buffered flag so it's reasonable to suspect they'll implement this parameter as well.



Gecko: No signal (https://github.com/mozilla/standards-positions/issues/434)

WebKit: Positive (https://lists.webkit.org/pipermail/webkit-dev/2020-August/031369.html)

Web developers: Positive (https://github.com/w3c/performance-timeline/issues/169)

Ergonomics

This feature is a new parameter in the PerformanceObserver callback. We do not see ergonomics risks here, as it is fairly easy to feature detect. Additional parameters will be in the same dictionary.



Is this feature fully tested by web-platform-tests?

Not yet (will add alongside implementation)

Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=1114172

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5320666234486784

This intent message was generated by Chrome Platform Status.

Rick Byers

unread,
May 6, 2021, 4:33:39 PMMay 6
to Nicolás Peña, blink-dev
Seems like a simple tiny addition (with lots of bikeshedding on the name!). LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAATDikvKZT6k%2B-Qchavbh4-jzW2gf%2BSwgyWqXnzi2k_sjPcjw%40mail.gmail.com.

Chris Harrelson

unread,
May 6, 2021, 5:59:21 PMMay 6
to Rick Byers, Nicolás Peña, blink-dev

Manuel Rego Casasnovas

unread,
May 10, 2021, 7:00:37 AMMay 10
to Chris Harrelson, Rick Byers, Nicolás Peña, blink-dev
LGTM3

On 06/05/2021 23:59, Chris Harrelson wrote:
> LGTM2
>
> On Thu, May 6, 2021 at 1:33 PM Rick Byers <rby...@chromium.org
> <mailto:rby...@chromium.org>> wrote:
>
> Seems like a simple tiny addition (with lots of bikeshedding on the
> name!). LGTM1
>
> On Thu, May 6, 2021 at 4:14 PM Nicolás Peña <n...@chromium.org
> <mailto:n...@chromium.org>> wrote:
>
>
> Contact emails
>
> n...@chromium.org <mailto:n...@chromium.org>
>
>
> Explainer
>
>
> https://github.com/npm1/hasDroppedEntry/blob/master/README.md
> <https://github.com/npm1/hasDroppedEntry/blob/master/README.md>
>
>
> Specification
>
> https://w3c.github.io/performance-timeline/#dom-performanceobservercallbackoptions-droppedentriescount
> <https://w3c.github.io/performance-timeline/#dom-performanceobservercallbackoptions-droppedentriescount>
>
>
> API spec
>
> Yes
>
>
> Summary
>
> Currently, web developers can use PerformanceObserver with the
> buffered flag to listen to past and future performance entries
> about their site. However, past entries need to be stored, and
> there is a buffer size limit. The droppedEntriesCount parameter
> helps developers know if they may have lost an entry due to this
> storage being full. It's set to the number of entries which got
> dropped from the buffer due to such a buffer being full.
>
>
>
> Blink component
>
> Blink>PerformanceAPIs
> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPerformanceAPIs>
>
>
> TAG review
>
> https://github.com/w3ctag/design-reviews/issues/547
> <https://github.com/w3ctag/design-reviews/issues/547>
>
>
> TAG review status
>
> Issues addressed
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
> This is a low risk feature. A developer using this feature will
> need to check that the options parameter in the callback is not
> undefined (to feature detect), and then obtain the
> droppedEntriesCount from it. It is simple to implement and user
> agents have followed along with implementing the buffered flag
> so it's reasonable to suspect they'll implement this parameter
> as well.
>
>
>
> Gecko: No signal
> (https://github.com/mozilla/standards-positions/issues/434
> <https://github.com/mozilla/standards-positions/issues/434>)
>
> WebKit: Positive
> (https://lists.webkit.org/pipermail/webkit-dev/2020-August/031369.html
> <https://lists.webkit.org/pipermail/webkit-dev/2020-August/031369.html>)
>
> Web developers: Positive
> (https://github.com/w3c/performance-timeline/issues/169
> <https://github.com/w3c/performance-timeline/issues/169>)
>
>
> Ergonomics
>
> This feature is a new parameter in the PerformanceObserver
> callback. We do not see ergonomics risks here, as it is fairly
> easy to feature detect. Additional parameters will be in the
> same dictionary.
>
>
>
> Is this feature fully tested by web-platform-tests
> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
>
> Not yet (will add alongside implementation)
>
>
> Tracking bug
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=1114172
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1114172>
>
>
> Link to entry on the Chrome Platform Status
>
> https://chromestatus.com/feature/5320666234486784
> <https://chromestatus.com/feature/5320666234486784>
>
> This intent message was generated by Chrome Platform Status
> <https://www.chromestatus.com/>.
>
> --
> You received this message because you are subscribed to the
> Google Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAATDikvKZT6k%2B-Qchavbh4-jzW2gf%2BSwgyWqXnzi2k_sjPcjw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-N1NAPbjVj0_q9_ghbx5daYQ%2Bn9X5SB%3DpPUTHn7SCNgg%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-N1NAPbjVj0_q9_ghbx5daYQ%2Bn9X5SB%3DpPUTHn7SCNgg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9o9qSxchm%2BXxbNOwg_b2CdEB9EHEbZfSyUS8WQ5SFCog%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9o9qSxchm%2BXxbNOwg_b2CdEB9EHEbZfSyUS8WQ5SFCog%40mail.gmail.com?utm_medium=email&utm_source=footer>.
Reply all
Reply to author
Forward
0 new messages