Intent to Ship: AudioContext.setSinkId()

[Ajay Rahatekar]

Contact emails

hong...@chromium.org, alv...@chromium.org, mjwi...@chromium.org 

Explainer

None

Specification

https://github.com/WebAudio/web-audio-api/pull/2498

Summary

AudioContext.setSinkId sets the ID of the audio device to use for output. This allows the AudioElement to route audio to a connected output device of user's choosing.

Blink component

Blink>WebAudio

TAG review

This is a small API change within Web Audio API. The WG was advised that this is too small for the TAG review.

TAG review status

Not applicable

Risks

Interoperability and Compatibility

Gecko: Positive (https://github.com/WebAudio/web-audio-api/issues/2400) Mozilla is co-developing the spec change.

WebKit: No signal

Web developers: Positive (https://github.com/WebAudio/web-audio-api/issues/2400) Many developers chimed in the spec issue and the implementation crbug entry (crbug.com/1216187). Also several partners expressed the need for this API. We have not seen any negative feedback on this.

Other signals:

WebView application risks

Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?

Debuggability

This adds a new method to AudioContext; the WebIDL change will be addressed by the DevTools automatically.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes

This is a part of Web Audio API, which is available on all platforms.

Is this feature fully tested by web-platform-tests?

Yes. The WPT will be added for this feature.

Flag name

–enable-blink-features=AudioContextSetSinkId

Requires code in //chrome?

False

Tracking bug

https://crbug.com/1355977

Launch bug

https://crbug.com/1216187

Estimated milestones

108

Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

None

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5190163462881280

This intent message was generated by Chrome Platform Status.

--

Ajay Rahatekar | Technical Program Manager | ajayra...@google.com | 650-797-1279

[Ajay Rahatekar]

Apologies, the tracking and launch bugs in the original email are interchanged. The correct details are:

Tracking bug

https://crbug.com/1216187
Launch bug

https://crbug.com/1355977

[Alex Russell]

Doesn't this require at least consulting former TAG members before asserting no review is required?

For avoidance of delay, please at least file an FYI with the TAG.

Regards, 

Alex

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/34425811-7d74-4b1d-ad7a-cddeb7a0aadcn%40chromium.org.

[Hongchan Choi]

Hi Alex,

In one of our WG teleconferences, we verbally asked the W3C liaison (Chris Lilley) about the TAG review but I was told this might be "too small to initiate the review". I can certainly start the TAG review (or FYI) if that's necessary.

Cheers,

Hongchan

[Philipp Hancke]

the ID of the sink needs to be obtained from navigator.mediaDevices.enumerateDevices because https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/selectAudioOutput is not implemented anywhere?

--

You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHB%2BDAj6AJ01%3DgXdUepU9Aejf6DOt2qmsK%3DUm%2BJSEDoVRMeyqw%40mail.gmail.com.

[Hongchan Choi]

Re: Alex - we kicked off the TAG review: https://github.com/w3ctag/design-reviews/issues/766

[Hongchan Choi]

1. Yes. The lack of implementation is one issue, but the relationship between selectAudioOutput() and Web Audio API is not really specified or documented.

2. Since AudioElement.setSinkId() has been used for years, we believe it makes more sense to use the same pattern for its low-level counterpart - Web Audio API's AudioContext. This approach is more specific and focused.

[Chris Harrelson]

Thanks for filing the TAG review. Could you also file for official positions from Mozilla and Webkit also? Thanks. I'm sure you're right about Mozilla, but they've requested going through the process in the past for other intents.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGJqXNuLuQ0mv%2BqRu2YxvP9iu_E%3DF2FdVe5Ewz%3DeB-yNokJtFA%40mail.gmail.com.

[Ajay Rahatekar]

We have filed requests for position. Please see below:

Mozilla: https://github.com/mozilla/standards-positions/issues/683

Webkit: https://github.com/WebKit/standards-positions/issues/53

[Ajay Rahatekar]

Please let us know of any other questions, concerns or observations. 

Thanks in advance.

-Ajay

[Yoav Weiss]

On Tuesday, September 13, 2022 at 4:16:15 PM UTC+2 ajayra...@google.com wrote:

Please let us know of any other questions, concerns or observations. 

Thanks in advance.

-Ajay

On Wednesday, August 31, 2022 at 2:54:14 PM UTC-7 Ajay Rahatekar wrote:

We have filed requests for position. Please see below:

Mozilla: https://github.com/mozilla/standards-positions/issues/683

Webkit: https://github.com/WebKit/standards-positions/issues/53

On Wed, Aug 31, 2022 at 8:54 AM Chris Harrelson <chri...@chromium.org> wrote:

Thanks for filing the TAG review. Could you also file for official positions from Mozilla and Webkit also? Thanks. I'm sure you're right about Mozilla, but they've requested going through the process in the past for other intents.

On Wed, Aug 31, 2022 at 8:08 AM Hongchan Choi <hong...@chromium.org> wrote:

1. Yes. The lack of implementation is one issue, but the relationship between selectAudioOutput() and Web Audio API is not really specified or documented.

2. Since AudioElement.setSinkId() has been used for years, we believe it makes more sense to use the same pattern for its low-level counterpart - Web Audio API's AudioContext. This approach is more specific and focused.

On Tue, Aug 30, 2022 at 10:46 PM Philipp Hancke <philipp...@googlemail.com> wrote:

the ID of the sink needs to be obtained from navigator.mediaDevices.enumerateDevices because https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/selectAudioOutput is not implemented anywhere?

Am Di., 30. Aug. 2022 um 19:02 Uhr schrieb 'Ajay Rahatekar' via blink-dev <blin...@chromium.org>:

Contact emails

hong...@chromium.org, alv...@chromium.org, mjwi...@chromium.org 

Explainer

None

Specification

https://github.com/WebAudio/web-audio-api/pull/2498

The PR hasn't landed yet, and Mozilla's (positive) position states that there are some details to be determined still.

Can you expand on that? What's holding the PR from landing?

[Hongchan Choi]

The original proposal didn't work out well because of the type confusion in the union (DOMString or AudioSinkCategory) - they are both DOMString in the end. So we are considering two options:

https://github.com/WebAudio/web-audio-api/issues/2400#issuecomment-1239704445

There's no disagreement. We just need to make a decision, and that is planned during this TPAC.

Let me know if you have any questions!

Thanks,

Hongchan

[Yoav Weiss]

Once the PR lands, this seems fine to ship (IMO). Let us know when that happens :)

[Mike West]

Friendly ping. It looks like conversation died down ~2 weeks ago. Has there been movement in the meantime, or should we consider this intent on hold for a while?

-mike

[Hongchan Choi]

The spec PR is approved and we'll be landing the spec change today or tomorrow. In the meantime, we would like to answer any questions for the Blink API Owner approval.

Cheers,

Hongchan

[Hongchan Choi]

The spec change has been landed: https://webaudio.github.io/web-audio-api/#dom-audiocontext-setsinkid

-Hongchan

[Mike Taylor]

LGTM1

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGJqXNvp-%3DESWy%2BdmNs10uab5jBc3e5y-9dPx13i1s3orRj6Jg%40mail.gmail.com.

[TAMURA, Kent]

LGTM2.

Mozilla is positive. Interoperability risk looks small.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/99d5d298-6fdf-04d0-e408-d5e8e512cf5b%40chromium.org.

--

TAMURA Kent
Software Engineer, Google

[Yoav Weiss]

LGTM3