Intent to Implement and Ship: Animation.updatePlaybackRate

71 views
Skip to first unread message

Kevin Ellis

unread,
May 7, 2019, 2:04:45 PM5/7/19
to blink-dev, Stephen McGruer
kev...@chromium.org https://developer.mozilla.org/en-US/docs/Web/API/Animation/updatePlaybackRate Specification: https://drafts.csswg.org/web-animations/#the-animation-interface https://drafts.csswg.org/web-animations/#the-animation-interface
https://drafts.csswg.org/web-animations/#seamlessly-updating-the-playback-rate-of-an-animation Animation.updatePlaybackRate provides a means to seamlessly transition the playback rate of an animation such that there is no visible jump in the animation. Current time is preserved at the instance the new playback rate takes effect. Animation.updatePlaybackRate provides a means of ensure that a change in playback rate results in a smooth transition. Current time is preserved at the moment the new playback rate takes effect. This method is presently available on Firefox and under development for Safari. Adding support in Chrome ensure consistency across browsers.
Already shipped for Firefox and under development for Safari. Firefox: Shipped (https://wpt.fyi/results/web-animations/interfaces/Animation/idlharness.window.html?label=master) Edge: No public signals Safari: In development (https://wpt.fyi/results/web-animations/interfaces/Animation/idlharness.window.html?label=master) Web developers: No signals
Yes Yes Covered by interface and timing-model tests for web-animations. Adding support for Animation.updatePlaybackRate resolves 27 WPT failures. https://bugs.chromium.org/p/chromium/issues/detail?id=827634 https://wpt.fyi/results/web-animations/interfaces/Animation/idlharness.window.html?label=master https://wpt.fyi/results/web-animations/timing-model/animations/seamlessly-updating-the-playback-rate-of-an-animation.html?label=master https://www.chromestatus.com/features/6276633918963712

Philip Jägenstedt

unread,
May 8, 2019, 6:22:00 AM5/8/19
to Kevin Ellis, blink-dev, Stephen McGruer
LGTM1, this seems very useful, and it's cool to see Firefox already passing the tests that we'll now match. After implementing this, it might be a good idea to check if any of the newly passing tests fail in Firefox and look into why that might be. Sometimes that reveals stuff worth fixing before shipping.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE1FVESA-3iGaYyXRVUf5W5w5-Sc%2BKesx4O9ZS3BBfnGz-9wNQ%40mail.gmail.com.

Kevin Ellis

unread,
May 8, 2019, 9:57:13 AM5/8/19
to Philip Jägenstedt, blink-dev, Stephen McGruer
Hi Philip,

Sounds good. Thus far, none of the test cases have been modified in order to address test failures.  Certainly, if any tests are introduced or modified, I'd be happy to compare with test results on Firefox.

Daniel Bratell

unread,
May 9, 2019, 2:27:35 AM5/9/19
to Philip Jägenstedt, 'Kevin Ellis' via blink-dev, Kevin Ellis, Stephen McGruer
LGTM2

A little bit of a pity that there is now two ways to do basically the same thing, though not exactly the same thing.

/Daniel
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE1FVESoaWrKCSwpsyB6ugUAR_k3%3DkW_rPYQmK%2Be7sA%2BRT0mXA%40mail.gmail.com.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

Yoav Weiss

unread,
May 9, 2019, 12:07:04 PM5/9/19
to Daniel Bratell, Philip Jägenstedt, 'Kevin Ellis' via blink-dev, Kevin Ellis, Stephen McGruer
Reply all
Reply to author
Forward
0 new messages