Where are the expectations impacting the canvas_webgpu_transfer layout tests?

[Colin Blundell]

Hi folks,

I'm running wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html on Mac:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html --driver-logging --flag-specific=webgpu

The result says "passed unexpectedly".

If I just run the whole test suite they all get skipped:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer --driver-logging --flag-specific=webgpu

Found 29 tests; running 0, skipping 29.
No tests to run.

My question is: Where is the test runner finding expectations for these canvas_webgpu_transfer tests? The only reference I see to these tests for Mac in expectations files is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/WebGPUExpectations;l=27-28?q=WebGPUExpec&ss=chromium

Thanks,

Colin

[Fredrik Söderquist]

In third_party/blink/web_tests/WebGPUExpectations it looks like (passed via --additional-expectations).

/fs

 

Thanks,

Colin

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NE_BsZVXGtd5m8_AbTqpS413A3_UmCKR-YT2cVZgf92sQ%40mail.gmail.com.

[Colin Blundell]

On Wed, Sep 11, 2024 at 4:41 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:34 PM Colin Blundell <blun...@chromium.org> wrote:

Hi folks,

I'm running wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html on Mac:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html --driver-logging --flag-specific=webgpu

The result says "passed unexpectedly".

If I just run the whole test suite they all get skipped:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer --driver-logging --flag-specific=webgpu

Found 29 tests; running 0, skipping 29.
No tests to run.

My question is: Where is the test runner finding expectations for these canvas_webgpu_transfer tests? The only reference I see to these tests for Mac in expectations files is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/WebGPUExpectations;l=27-28?q=WebGPUExpec&ss=chromium

In third_party/blink/web_tests/WebGPUExpectations it looks like (passed via --additional-expectations).

But only two out of the 29 tests are referenced for Mac in that file, unless there's something I'm missing? e.g., transferBackFromGPUTexture-canvas-readback-rgba16f.https.html is not referenced.

[Fredrik Söderquist]

On Wed, Sep 11, 2024 at 4:43 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Sep 11, 2024 at 4:41 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:34 PM Colin Blundell <blun...@chromium.org> wrote:

Hi folks,

I'm running wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html on Mac:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html --driver-logging --flag-specific=webgpu

The result says "passed unexpectedly".

If I just run the whole test suite they all get skipped:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer --driver-logging --flag-specific=webgpu

Found 29 tests; running 0, skipping 29.
No tests to run.

My question is: Where is the test runner finding expectations for these canvas_webgpu_transfer tests? The only reference I see to these tests for Mac in expectations files is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/WebGPUExpectations;l=27-28?q=WebGPUExpec&ss=chromium

In third_party/blink/web_tests/WebGPUExpectations it looks like (passed via --additional-expectations).

But only two out of the 29 tests are referenced for Mac in that file, unless there's something I'm missing? e.g., transferBackFromGPUTexture-canvas-readback-rgba16f.https.html is not referenced.

Sorry, it looks like I may have read your question a tad too quickly... :(. I think this could be running a single test vs. a "set" issue.

/fs

[Colin Blundell]

On Wed, Sep 11, 2024 at 5:06 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:43 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Sep 11, 2024 at 4:41 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:34 PM Colin Blundell <blun...@chromium.org> wrote:

Hi folks,

I'm running wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html on Mac:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html --driver-logging --flag-specific=webgpu

The result says "passed unexpectedly".

If I just run the whole test suite they all get skipped:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer --driver-logging --flag-specific=webgpu

Found 29 tests; running 0, skipping 29.
No tests to run.

My question is: Where is the test runner finding expectations for these canvas_webgpu_transfer tests? The only reference I see to these tests for Mac in expectations files is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/WebGPUExpectations;l=27-28?q=WebGPUExpec&ss=chromium

In third_party/blink/web_tests/WebGPUExpectations it looks like (passed via --additional-expectations).

But only two out of the 29 tests are referenced for Mac in that file, unless there's something I'm missing? e.g., transferBackFromGPUTexture-canvas-readback-rgba16f.https.html is not referenced.

Sorry, it looks like I may have read your question a tad too quickly... :(. I think this could be running a single test vs. a "set" issue.

I agree that the test in question is getting run when I run it singly because AFAIK a test will always be run when you run it singly. What I'm not seeing is where there are any expectations on Mac for either this test or any of the other tests being skipped that are (a) causing them to be skipped when run as a suite, (b) causing the pass result on this single test to be reported as unexpected.

Thanks,

Colin

[Fredrik Söderquist]

On Wed, Sep 11, 2024 at 5:16 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Sep 11, 2024 at 5:06 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:43 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Sep 11, 2024 at 4:41 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:34 PM Colin Blundell <blun...@chromium.org> wrote:

Hi folks,

I'm running wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html on Mac:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html --driver-logging --flag-specific=webgpu

The result says "passed unexpectedly".

If I just run the whole test suite they all get skipped:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer --driver-logging --flag-specific=webgpu

Found 29 tests; running 0, skipping 29.
No tests to run.

My question is: Where is the test runner finding expectations for these canvas_webgpu_transfer tests? The only reference I see to these tests for Mac in expectations files is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/WebGPUExpectations;l=27-28?q=WebGPUExpec&ss=chromium

In third_party/blink/web_tests/WebGPUExpectations it looks like (passed via --additional-expectations).

But only two out of the 29 tests are referenced for Mac in that file, unless there's something I'm missing? e.g., transferBackFromGPUTexture-canvas-readback-rgba16f.https.html is not referenced.

Sorry, it looks like I may have read your question a tad too quickly... :(. I think this could be running a single test vs. a "set" issue.

I agree that the test in question is getting run when I run it singly because AFAIK a test will always be run when you run it singly. What I'm not seeing is where there are any expectations on Mac for either this test or any of the other tests being skipped that are (a) causing them to be skipped when run as a suite,

This I'd think is from NeverFixTests which has:

wpt_internal/webgpu/* [ Skip ]

[Colin Blundell]

On Wed, Sep 11, 2024 at 5:58 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 5:16 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Sep 11, 2024 at 5:06 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:43 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Sep 11, 2024 at 4:41 PM Fredrik Söderquist <f...@opera.com> wrote:

On Wed, Sep 11, 2024 at 4:34 PM Colin Blundell <blun...@chromium.org> wrote:

Hi folks,

I'm running wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html on Mac:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer/transferBackFromGPUTexture-canvas-readback-rgba16f.https.html --driver-logging --flag-specific=webgpu

The result says "passed unexpectedly".

If I just run the whole test suite they all get skipped:

third_party/blink/tools/run_web_tests.py -t mac_release wpt_internal/webgpu/canvas_webgpu_transfer --driver-logging --flag-specific=webgpu

Found 29 tests; running 0, skipping 29.
No tests to run.

My question is: Where is the test runner finding expectations for these canvas_webgpu_transfer tests? The only reference I see to these tests for Mac in expectations files is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/WebGPUExpectations;l=27-28?q=WebGPUExpec&ss=chromium

In third_party/blink/web_tests/WebGPUExpectations it looks like (passed via --additional-expectations).

But only two out of the 29 tests are referenced for Mac in that file, unless there's something I'm missing? e.g., transferBackFromGPUTexture-canvas-readback-rgba16f.https.html is not referenced.

Sorry, it looks like I may have read your question a tad too quickly... :(. I think this could be running a single test vs. a "set" issue.

I agree that the test in question is getting run when I run it singly because AFAIK a test will always be run when you run it singly. What I'm not seeing is where there are any expectations on Mac for either this test or any of the other tests being skipped that are (a) causing them to be skipped when run as a suite,

This I'd think is from NeverFixTests which has:

wpt_internal/webgpu/* [ Skip ]

👍 Thank you!