Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Web-Facing Change PSA: NotRestoredReasons name change

268 views
Skip to first unread message

Yuzu Saijo

unread,
Nov 4, 2024, 11:57:41 PM11/4/24
to blink-dev

We are going to change the names reported in NotRestoredReasons API so that they match the specified names. NotRestoredReasons API has been launched for 6 months now.

The change is likely to land with a flag in M133.

We expect that web developers are counting these values. Since this is an API that reports events about a previous instance of the page, we do not expect that any client-side code takes any action based on specific strings.

Server side code which presents reports based on this API's data may attach advice to developers on how to avoid blocking BFCache for certain reasons. This would need to attach the advice to the new values and the old values. Similarly developer-targeted articles may reference the old values.


Yoav Weiss (@Shopify)

unread,
Nov 5, 2024, 2:14:58 AM11/5/24
to Yuzu Saijo, blink-dev
What does current usage look like? Have you reached out to folks who may be using the API to notify them that they'd need to adapt their backend code?

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPK8OYiAWY-8Hsy0MK3FYLOpTrs87knwWbRhhzby2ZLsgOOWDg%40mail.gmail.com.

Yuzu Saijo

unread,
Nov 7, 2024, 1:02:04 AM11/7/24
to Yoav Weiss (@Shopify), blink-dev
Thanks Yoav for the question.

I realized that we have a usage counter but in a wrong place, and it is now just counting the number of history navigation.
So at the moment we don't know how many people use the API.
I will send out a CL to change this. 

We are thinking of reaching out to RUM users so that they can be aware of the upcoming change.
But basically this API's report values are like histograms and sites must handle new values and values that are not present.

Yuzu Saijo

unread,
Nov 8, 2024, 12:32:49 AM11/8/24
to Yoav Weiss (@Shopify), bfcac...@chromium.org, blink-dev

Domenic Denicola

unread,
Nov 13, 2024, 4:11:08 AM11/13/24
to Yuzu Saijo, Yoav Weiss (@Shopify), bfcac...@chromium.org, blink-dev
I spent some time discussing this with the team internally before this was sent, with the tentative conclusion that a PSA was appropriate instead of a full Intent to Ship.

Here are the factors that indicate this to me:
  • As Yuzu states, in practice we expect these values to be treated as opaque strings, bucketed by reporting APIs. It is extremely hard to imagine user-visible breakage from any reasonable coding pattern; it would be similar to expecting user-visible breakage from changing exception message strings. (Possible! But not usually considered to require an Intent to Ship.)

    The shipping guidelines state reporting breakage is still considered as important, so the question is whether we believe this change is "very unlikely" to break such reporting backends. I agree with the team that such reporting breakage is very unlikely. Site owners might see some failures migrate from the "unload-listener" to "unload-handler" buckets on their dashboards, which could be slightly strange, but it doesn't seem like breakage.
  • Unlike exception messages, bfcache reporting reasons are written down in specs. But, this change is aligning with the specification. If in the future the team plans to perform more renames or additions of bfcache blocking reasons, those will go through the usual spec process, and come with a corresponding Intent to Ship. So this is more of a bugfix, and not a full "new feature".
  • The majority of the changed reasons (4/5) are migrating from specific reason strings to "masked", which is the per-spec fallback that the browser is always allowed to send. In general web pages and reporting software need to be resilient to the contents of the "masked" bucket fluctuating between browsers and browser versions.
  • The team flag-guarded this change so if somehow, something breaks, it can be remotely rolled back.

Fergal Daly

unread,
Feb 25, 2025, 4:54:08 AMFeb 25
to blink-dev, Domenic Denicola, Yoav Weiss, bfcac...@chromium.org, blink-dev, Yuzu Saijo
I would like to rollout this change in M135 (cutting next week). There has been no response to Domenic's argument that this is very unlikely to cause breakage. Unless someone argues that this needs to be more than a PSA, I will proceed,

Fergal

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

Fergal Daly

unread,
Feb 28, 2025, 2:14:53 AMFeb 28
to blink-dev, Fergal Daly, Domenic Denicola, Yoav Weiss, bfcac...@chromium.org, blink-dev, Yuzu Saijo
This has been submitted as https://chromiumdash.appspot.com/commit/af269bab5f16b6a8304f1b820bca16c5118943f2 and will roll out in M135. Thanks,

F

Reply all
Reply to author
Forward
0 new messages