Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs
Zachary Tan
Contact emails
Explainer
None
Specification
https://github.com/fedidcg/FedCM/pull/510
Design docs
None
Summary
This changes one of our existing WebDriver commands to allow clicking on a button on the FedCM dialog by passing a parameter of the button to click rather than having to expose a new WebDriver command each time a button is introduced on the FedCM dialog.
Currently, the existing WebDriver command clicks on the “Continue” button on the mismatch dialog. This will be replaced with calling the command with the button constant “kConfirmIdpLoginContinue”. We will also be adding two new button constants for the error API, “kErrorGotIt” and “kErrorMoreDetails” which will click on the got it button and the more details button on the error dialog respectively.
Blink component
TAG review
None
TAG review status
Not applicable
Risks
Interoperability and Compatibility
Gecko: Positive. (https://github.com/fedidcg/FedCM/pull/510#issuecomment-1830257611) Mozilla has requested that we use their spec LGTMs in favor of standards position entries for FedCM. Hence, we will not file a standards position request.
WebKit: No signal. We have no signal from Safari for FedCM in general; as such, we have no signal for this part either.
Web developers: Positive. At least one user is interested and sees the lack of this as a blocker to rolling out FedCM support.
Other signals:
Ergonomics
n/a
Activation
Selenium Java APIs have been exposed for existing WebDriver commands and this command will be updated there accordingly.
Security
n/a, this is only exposed through WebDriver.
WebView application risks
n/a
Debuggability
This is a debugging feature.
Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes
Is this feature fully tested by web-platform-tests?
No
Flag name
Not applicable
Requires code in //chrome?
True
Estimated milestones
Anticipated spec changes
Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).
Link to entry on the Chrome Platform Status
Not applicable
Domenic Denicola
Contact emails
Explainer
None
Specification
https://github.com/fedidcg/FedCM/pull/510
Design docs
None
Summary
This changes one of our existing WebDriver commands to allow clicking on a button on the FedCM dialog by passing a parameter of the button to click rather than having to expose a new WebDriver command each time a button is introduced on the FedCM dialog.
Currently, the existing WebDriver command clicks on the “Continue” button on the mismatch dialog. This will be replaced with calling the command with the button constant “kConfirmIdpLoginContinue”. We will also be adding two new button constants for the error API, “kErrorGotIt” and “kErrorMoreDetails” which will click on the got it button and the more details button on the error dialog respectively.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADAy7ja0xnBUfFywLCSs5NDfTNaN4pRnhFbN3_hojC72ZzAvag%40mail.gmail.com.
Zachary Tan
Mike Taylor
LGTM1
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADAy7jY_8BsfSSOCf9LQVpfJ0S_py8TuxkR5cXuZoiZpGUnFLw%40mail.gmail.com.
Rick Byers
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/49af6312-edea-4bdb-884c-261d7c9373bc%40chromium.org.
Philip Jägenstedt
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_u_M_T9MobnxPPydLjAHmzwPXFbo3Tc-a%3DyPx3Sr7QvQ%40mail.gmail.com.