Intent to Ship: CSS custom counter style

193 views
Skip to first unread message

Xiaocheng Hu

unread,
Feb 19, 2021, 2:06:32 PMFeb 19
to blink-dev

Contact emails

xiaoc...@chromium.org

Explainer


https://developer.mozilla.org/en-US/docs/Web/CSS/@counter-style

Specification

https://drafts.csswg.org/css-counter-styles-3

API spec

Yes

Design docs


https://bit.ly/2Gm1oMC

Summary

The CSS @counter-style rule allows web authors to specify and use custom counter styles in list markers and CSS counters. This helps web internationalization.


Note: we are not shipping the following:

  • Image symbols, which no browser supports, and is 'at-risk' per spec.
  • 'speak-as' descriptor, which is an accessibility feature. We plan to ship @counter-style first, and then work with the accessibility team to implement 'speak-as'. Also note that screen-reading of existing (predefined) counter styles is unaffected.


Blink component

Blink>CSS

Search tags

csscountercounter-style

TAG review

Not needed as Firefox already shipped it in 2014.

TAG review status

Not applicable

Risks



Interoperability and Compatibility

This should greatly improve interoperability. The spec is already in Candidate Recommendation status and Firefox already shipped it in 2014, while no other browser has shipped it yet.



Gecko: Shipped/Shipping (https://bugzilla.mozilla.org/show_bug.cgi?id=966166) Other than image symbols and 'speak-as: spell-out', Firefox has fully shipped the feature.

WebKit: No signal (https://bugs.webkit.org/show_bug.cgi?id=167645)

Web developers: No signals


Is this feature fully tested by web-platform-tests?

Yes

Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=687225

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5692693659254784

This intent message was generated by Chrome Platform Status.

Chris Harrelson

unread,
Feb 19, 2021, 2:48:37 PMFeb 19
to Xiaocheng Hu, blink-dev
Hi,

Could you email webkit-dev to ask for a signal?
 

Web developers: No signals


Is this feature fully tested by web-platform-tests?

Yes

Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=687225

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5692693659254784

This intent message was generated by Chrome Platform Status.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABDsFEa-qBQZ0Uh3sXMwqshxe%2Bt8wDm%3DwnbO4Uoh9%2BJO-8yeRw%40mail.gmail.com.

Xiaocheng Hu

unread,
Feb 19, 2021, 3:41:38 PMFeb 19
to Chris Harrelson, Xiaocheng Hu, blink-dev

Mike West

unread,
Feb 25, 2021, 3:26:42 PMFeb 25
to blink-dev, Xiaocheng Hu, blink-dev, Chris Harrelson
LGTM1. WebKit expressed support, and Firefox is already shipping. Thanks for resolving this interop issue!

I'm also happy to see you calling out accessibility concerns; I'll be happy to see you resolve those in the future. It would be ideal if we could ensure that the sites using this mechanism remain workable for folks using accessibility tools.

-mike

Manuel Rego Casasnovas

unread,
Feb 25, 2021, 3:32:54 PMFeb 25
to Mike West, blink-dev, Xiaocheng Hu, Chris Harrelson
LGTM2.
> https://bit.ly/2Gm1oMC <https://bit.ly/2Gm1oMC>
>
>
> Summary
>
> The CSS @counter-style rule allows web authors to specify
> and use custom counter styles in list markers and CSS
> counters. This helps web internationalization.
>
>
> Note: we are not shipping the following:
>
> * Image symbols, which no browser supports, and is
> 'at-risk' per spec.
> * 'speak-as' descriptor, which is an accessibility
> feature. We plan to ship @counter-style first, and then
> work with the accessibility team to implement
> 'speak-as'. Also note that screen-reading of existing
> (predefined) counter styles is unaffected.
>
>
> Blink component
>
> Blink>CSS
> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS>
>
>
> Search tags
>
> css <https://chromestatus.com/features#tags:css>, counter
> <https://chromestatus.com/features#tags:counter>,
> counter-style
> <https://chromestatus.com/features#tags:counter-style>
>
>
> TAG review
>
> Not needed as Firefox already shipped it in 2014.
>
>
> TAG review status
>
> Not applicable
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
> This should greatly improve interoperability. The spec is
> already in Candidate Recommendation status and Firefox
> already shipped it in 2014, while no other browser has
> shipped it yet.
>
>
>
> Gecko: Shipped/Shipping
> (https://bugzilla.mozilla.org/show_bug.cgi?id=966166
> <https://bugzilla.mozilla.org/show_bug.cgi?id=966166>) Other
> than image symbols and 'speak-as: spell-out', Firefox has
> fully shipped the feature.
>
> WebKit: No signal
> (https://bugs.webkit.org/show_bug.cgi?id=167645
> <https://bugs.webkit.org/show_bug.cgi?id=167645>)
>
>
> Could you email webkit-dev to ask for a signal?
>
>
> Here it is:
> https://lists.webkit.org/pipermail/webkit-dev/2021-February/031700.html
> <https://lists.webkit.org/pipermail/webkit-dev/2021-February/031700.html>
>
>
> Web developers: No signals
>
>
> Is this feature fully tested by web-platform-tests
> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
>
> Yes
>
>
> Tracking bug
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=687225
> <https://bugs.chromium.org/p/chromium/issues/detail?id=687225>
>
>
> Link to entry on the Chrome Platform Status
>
> https://chromestatus.com/feature/5692693659254784
> <https://chromestatus.com/feature/5692693659254784>
>
> This intent message was generated by Chrome Platform Status
> <https://www.chromestatus.com/>.
>
> --
> You received this message because you are subscribed to the
> Google Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails
> from it, send an email to blink-dev+...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABDsFEa-qBQZ0Uh3sXMwqshxe%2Bt8wDm%3DwnbO4Uoh9%2BJO-8yeRw%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABDsFEa-qBQZ0Uh3sXMwqshxe%2Bt8wDm%3DwnbO4Uoh9%2BJO-8yeRw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3e5034aa-6d0b-4761-ad9e-428e4f2da39bn%40chromium.org
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3e5034aa-6d0b-4761-ad9e-428e4f2da39bn%40chromium.org?utm_medium=email&utm_source=footer>.

TAMURA, Kent

unread,
Feb 25, 2021, 7:20:22 PMFeb 25
to Manuel Rego Casasnovas, Mike West, blink-dev, Xiaocheng Hu, Chris Harrelson
LGTM3.




--
TAMURA Kent
Software Engineer, Google


Xiaocheng Hu

unread,
Feb 25, 2021, 7:54:33 PMFeb 25
to TAMURA, Kent, Manuel Rego Casasnovas, Mike West, blink-dev, Xiaocheng Hu, Chris Harrelson
Thanks everyone for reviewing!

Unfortunately I just received a P1 bug (https://crbug.com/1180992) minutes ago. I'll fix it first and then see if we should still target M90, or postpone to M91.

obr...@igalia.com

unread,
Feb 26, 2021, 3:07:57 PMFeb 26
to blink-dev, xiaoc...@chromium.org
Extending 'disclosure-open' and 'disclosure-closed' doesn't work well (https://crbug.com/1168277).
This is marked as blocking bug 687225. Do you plan to fix it before shipping?

El dia divendres, 19 de febrer de 2021 a les 20:06:32 UTC+1, xiaoc...@chromium.org va escriure:

Xiaocheng Hu

unread,
Mar 1, 2021, 5:48:12 PMMar 1
to obr...@igalia.com, blink-dev, xiaoc...@chromium.org
On Fri, Feb 26, 2021 at 12:08 PM obr...@igalia.com <obr...@igalia.com> wrote:
Extending 'disclosure-open' and 'disclosure-closed' doesn't work well (https://crbug.com/1168277).
This is marked as blocking bug 687225. Do you plan to fix it before shipping?

Not planned. I've modified the bug.

Alex Russell

unread,
Mar 2, 2021, 7:49:01 PMMar 2
to blink-dev, Xiaocheng Hu, blink-dev, obr...@igalia.com
I'm glad to see this move forward, however please consider this a request for follow-on work to describe the internals of these sorts of DOM structures via Shadow DOM de-structuring. Future work on generated pseduoelements of this sort should probably include some sort of description of the internal structure, even if it isn't specified in a developer exposed way at first.

Regards

Xiaocheng Hu

unread,
Mar 10, 2021, 3:43:31 PMMar 10
to Alex Russell, blink-dev, Xiaocheng Hu, obr...@igalia.com
PSA: This has been enabled in M91. Not M90, due to having missed the branch date.
Reply all
Reply to author
Forward
0 new messages