Intent to remove display: compact (alias to display: block)

Elliott Sprehn

unread,

Oct 29, 2013, 6:23:20 PM10/29/13

to blink-dev

Currently display: compact results in display: block rendering unless the experimental region based column implementation is turned on. When that is turned on we don't follow the current version of the spec... so it's not clear why that's there.

No other browser supports it and it's not documented on MDN or MSDN. Our "implementation" apparently comes from the dawn of time: https://trac.webkit.org/changeset/5790

The feature is used on 0.02% of page views, so I don't think we can remove it, but I think we should make the value of compact compute to "block" which results in identical behavior and means that our code doesn't need to know about it.

Hopefully someday we can just remove the feature entirely (and get it removed from the spec).

- E

Ojan Vafai

unread,

Oct 29, 2013, 6:28:27 PM10/29/13

to Elliott Sprehn, blink-dev

lgtm

Eric Seidel

unread,

Oct 29, 2013, 8:15:12 PM10/29/13

to Ojan Vafai, Elliott Sprehn, blink-dev

Can we make it return false from @supports as well as alias to
"block"? That may not be worth the trouble...

Adam Barth

unread,

Oct 30, 2013, 2:54:23 AM10/30/13

to Eric Seidel, Ojan Vafai, Elliott Sprehn, blink-dev

Given that no other browser supports it, it seems like we should try just removing it.

Adam

TAMURA, Kent

unread,

Oct 30, 2013, 6:14:45 PM10/30/13

to blink-dev, Eric Seidel, Ojan Vafai, Elliott Sprehn, Adam Barth

lgtm to make it an alias of 'block.'

--
TAMURA Kent
Software Engineer, Google

Ojan Vafai

unread,

Oct 30, 2013, 6:49:21 PM10/30/13

to TAMURA, Kent, blink-dev, Eric Seidel, Elliott Sprehn, Adam Barth

I actually think we can get away with just removing it. It only changes behavior if the display of the element is not a block. I think the percent of pageviews that apply compact to inlines is probably much lower than the 0.02% of pageviews that apply compact. Unfortunately, writing a UseCounter to verify that is hard.

I vote that we try removing it and we can add it back in if we end up getting bugs filed.

Elliott Sprehn

unread,

Oct 30, 2013, 6:52:24 PM10/30/13

to Ojan Vafai, TAMURA, Kent, blink-dev, Eric Seidel, Adam Barth

+1

Dimitri Glazkov

unread,

Nov 5, 2013, 12:27:04 PM11/5/13

to Elliott Sprehn, Ojan Vafai, TAMURA, Kent, blink-dev, Eric Seidel, Adam Barth

LGTM to just remove it.

Tab Atkins Jr.

unread,

Nov 5, 2013, 2:04:13 PM11/5/13

to Dimitri Glazkov, Elliott Sprehn, Ojan Vafai, TAMURA, Kent, blink-dev, Eric Seidel, Adam Barth

LGTM to remove too. This didn't even make the jump to CSS 2.1, so it
hasn't been documented in over a decade.

> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+...@chromium.org.

Reply all

Reply to author

Forward