Intent to Ship: `navigator.webdriver === false` when automation is not enabled.

81 views
Skip to first unread message

Maksim Sadym

unread,
Apr 16, 2021, 7:18:42 PMApr 16
to blin...@chromium.org, mk...@chromium.org, Mathias Bynens, Philip Jägenstedt

Contact emails

sa...@google.com

Explainer

None

Specification

https://w3c.github.io/webdriver/#interface

API spec

Yes

Design docs


https://w3c.github.io/webdriver/#interface

Summary

Prior to this change, Chromium only exposed `navigator.webdriver` when the browser was being automated. However, other browsers expose it unconditionally per the spec (https://w3c.github.io/webdriver/#interface), with the value `false` in case the browser is not being automated. We propose changing Chromium to align with other browsers and the spec. This is a potentially breaking change since web pages could in theory rely on the old `navigator.webdriver === undefined` behavior.



Blink component

Blink

Search tags

navigatorwebdriverautomation

TAG review



TAG review status

Not applicable

Risks



Interoperability and Compatibility



Gecko: Shipped/Shipping

WebKit: Shipped/Shipping

Web developers: No signals


Is this feature fully tested by web-platform-tests?

Yes

Flag name



Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=1152355

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5670121114697728

This intent message was generated by Chrome Platform Status.

--
Best regards,
Maksim Sadym

Mike West

unread,
Apr 20, 2021, 10:10:57 AMApr 20
to Maksim Sadym, blin...@chromium.org, Mathias Bynens, Philip Jägenstedt
Retrospective LGTM1.

This shipped in Chrome 89 without running through the Blink process. Thanks for circling back around to send this I2S. Since we're following our friends in Gecko and WebKit with this behavior, I'm happy to see this move towards more interop.

-mike

Chris Harrelson

unread,
Apr 20, 2021, 10:50:49 AMApr 20
to Mike West, Maksim Sadym, blink-dev, Mathias Bynens, Philip Jägenstedt
LGTM2

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3Dd8Bx%3D-CGrvCdBQiv3ywi44Q0iqOr0U44uyeFCavp-hJQ%40mail.gmail.com.

Daniel Bratell

unread,
Apr 21, 2021, 3:56:13 AMApr 21
to Chris Harrelson, Mike West, Maksim Sadym, blink-dev, Mathias Bynens, Philip Jägenstedt
Reply all
Reply to author
Forward
0 new messages