Intent to Implement & Ship: RTCPeerConnection::onicecandidateerror

180 views
Skip to first unread message

ma...@microsoft.com

unread,
Jun 14, 2019, 11:48:11 AM6/14/19
to blink-dev
Contact emails

Spec

Summary
ICE candidate error event provides detailed information about WebRTC ICE candidate gathering failures, including the ones defined by STUN (RFC5389) and TURN (RFC5766).

Motivation
Diagnosing ICE connectivity issues without having access to detailed gathering failures can be a challenge. Support for ICE candidate errors is targeted towards better connectivity troubleshooting and network diagnostics.

Risks
Interoperability and Compatibility
Low, this is not yet available on other browsers.
Ergonomics
N/A
Activation
N/A

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes.

Link to entry on the feature dashboard
Need help creating a feature on https://www.chromestatus.com, as I don't have access.

Requesting approval to ship?
Yes.

Philip Jägenstedt

unread,
Jun 17, 2019, 9:07:47 AM6/17/19
to ma...@microsoft.com, blink-dev
LGTM1, this is very minor, just a new event and event interface.

Note that on interoperability, the risk when shipping new things which aren't yet in other browsers is that they never are. In other words, low interop risk would be when we have high confidence that all engines will ship this, and it's high if we think they won't. However, this is a larger concern with a big new feature, this is just a new event, and one that ended up in the WebRTC spec following a working group process with multi-vendor participation.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/23a37727-3df5-40bc-86cf-a053d3f6bf6a%40chromium.org.

Max Solodovnikov

unread,
Jun 17, 2019, 9:24:07 AM6/17/19
to blink-dev, ma...@microsoft.com
Thanks, Philip! Does it need an entry on chromestatus.com? If so, can you help with it (either grant write access or help creating an entry)?

Philip Jägenstedt

unread,
Jun 17, 2019, 11:16:08 AM6/17/19
to Max Solodovnikov, Johnny Stenback, blink-dev
It used to be possible to request an account at the bottom of chromestatus.com, I'm not sure what's happened there. +Johnny Stenback, can you help Max get set up with an account to create an entry? If it doesn't work I can create an entry.

On Mon, Jun 17, 2019 at 3:24 PM 'Max Solodovnikov' via blink-dev <blin...@chromium.org> wrote:
Thanks, Philip! Does it need an entry on chromestatus.com? If so, can you help with it (either grant write access or help creating an entry)?

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

sol...@gmail.com

unread,
Jun 19, 2019, 12:38:15 PM6/19/19
to blink-dev, ma...@microsoft.com, jste...@google.com
@jstenback, I wonder if you had a chance to look into permission issues that I am hitting? Is there a way to get write access to chromestatus.com?

Johnny Stenback

unread,
Jun 19, 2019, 8:38:30 PM6/19/19
to sol...@gmail.com, blink-dev, ma...@microsoft.com
Sorry for the delay in getting back on this. I've added sol...@gmail.com as a user in chromestatus.com. Enjoy!

Cheers,
Johnny

- jstenback (he/him)

Daniel Bratell

unread,
Jun 20, 2019, 9:54:07 AM6/20/19
to sol...@gmail.com, 'Johnny Stenback' via blink-dev, Johnny Stenback, ma...@microsoft.com
LGTM2

/Daniel
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACZRgz5477977jO72-uVvxQWzkAJ57XOF%3DPgEPi94A1U4iH5pw%40mail.gmail.com.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

Yoav Weiss

unread,
Jun 20, 2019, 9:59:39 AM6/20/19
to Daniel Bratell, sol...@gmail.com, 'Johnny Stenback' via blink-dev, Johnny Stenback, ma...@microsoft.com
As Philip said, interop risk is about chances of adoption by other engines.
Have you reached out to other engines? Opened issues? Do you know if they intend to implement?
Any links to WG discussions on this that can show objections or lack-there-of?

I agree that's a minor change. That also means it would be easy for other engines to follow if they so desire. I just want to make sure there aren't any objections we're missing here.

Henrik Boström

unread,
Jun 26, 2019, 10:35:40 AM6/26/19
to blink-dev, bra...@opera.com, sol...@gmail.com, jste...@google.com, ma...@microsoft.com
This will expose it to Chromium and Edge, and someone from Opera seem to have approved the intent in this thread.
I don't know if this exact feature has been discussed recently, but this is part of WebRTC 1.0 that all major browsers are working on implementing, and this has not been marked a feature at risk.

Can we proceed with the shipping?

On Thursday, June 20, 2019 at 3:59:39 PM UTC+2, Yoav Weiss wrote:
As Philip said, interop risk is about chances of adoption by other engines.
Have you reached out to other engines? Opened issues? Do you know if they intend to implement?
Any links to WG discussions on this that can show objections or lack-there-of?

I agree that's a minor change. That also means it would be easy for other engines to follow if they so desire. I just want to make sure there aren't any objections we're missing here.

On Thu, Jun 20, 2019 at 3:54 PM Daniel Bratell <bra...@opera.com> wrote:
LGTM2

/Daniel

On Wed, 19 Jun 2019 21:35:27 +0200, 'Johnny Stenback' via blink-dev <blin...@chromium.org> wrote:

Sorry for the delay in getting back on this. I've added sol...@gmail.com as a user in chromestatus.com. Enjoy!

Cheers,
Johnny

- jstenback (he/him)


On Wed, Jun 19, 2019 at 2:03 AM <sol...@gmail.com> wrote:
@jstenback, I wonder if you had a chance to look into permission issues that I am hitting? Is there a way to get write access to chromestatus.com?

On Monday, June 17, 2019 at 5:16:08 PM UTC+2, Philip Jägenstedt wrote:
It used to be possible to request an account at the bottom of chromestatus.com, I'm not sure what's happened there. +Johnny Stenback, can you help Max get set up with an account to create an entry? If it doesn't work I can create an entry.

On Mon, Jun 17, 2019 at 3:24 PM 'Max Solodovnikov' via blink-dev <blin...@chromium.org> wrote:
Thanks, Philip! Does it need an entry on chromestatus.com? If so, can you help with it (either grant write access or help creating an entry)?

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

Philipp Hancke

unread,
Jun 26, 2019, 11:24:55 AM6/26/19
to Henrik Boström, blink-dev, Daniel Bratell, sol...@gmail.com, jste...@google.com, ma...@microsoft.com
- I think that can be counted as "not opposed" from Firefox.


To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e4294d32-88cd-49fd-a90b-cc82bf8b5c72%40chromium.org.

Max Solodovnikov

unread,
Jun 26, 2019, 1:40:05 PM6/26/19
to blink-dev, hb...@chromium.org, bra...@opera.com, sol...@gmail.com, jste...@google.com, ma...@microsoft.com
Yes, feature has been published to  https://www.chromestatus.com/feature/6602864602382336. There are also tickets for Mozilla (https://bugzilla.mozilla.org/show_bug.cgi?id=1561441) and WebKit (https://bugs.webkit.org/show_bug.cgi?id=199207). Unfortunately I did not find any references to WG discussions on this specific API.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.

Yoav Weiss

unread,
Jul 4, 2019, 3:11:55 AM7/4/19
to Philipp Hancke, Henrik Boström, blink-dev, Daniel Bratell, sol...@gmail.com, Johnny Stenback, ma...@microsoft.com
On Wed, Jun 26, 2019 at 5:24 PM 'Philipp Hancke' via blink-dev <blin...@chromium.org> wrote:
- I think that can be counted as "not opposed" from Firefox.

I was hoping for something a bit more official, but I guess that shows it's not a super controversial change.
 

Yoav Weiss

unread,
Jul 4, 2019, 3:13:02 AM7/4/19
to Max Solodovnikov, blink-dev, Henrik Boström, Daniel Bratell, sol...@gmail.com, Johnny Stenback
LGTM3

On Wed, Jun 26, 2019 at 7:40 PM 'Max Solodovnikov' via blink-dev <blin...@chromium.org> wrote:
Yes, feature has been published to  https://www.chromestatus.com/feature/6602864602382336. There are also tickets for Mozilla (https://bugzilla.mozilla.org/show_bug.cgi?id=1561441) and WebKit (https://bugs.webkit.org/show_bug.cgi?id=199207). Unfortunately I did not find any references to WG discussions on this specific API.

Thanks for filing the issues! :)
 
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e7b778e8-268f-448c-8bac-444d47626fd3%40chromium.org.

Henrik Boström

unread,
Jul 4, 2019, 5:14:53 AM7/4/19
to blink-dev, ma...@microsoft.com, hb...@chromium.org, bra...@opera.com, sol...@gmail.com, jste...@google.com
> I was hoping for something a bit more official, but I guess that shows it's not a super controversial change.

It isn't super controversial. The WebRTC spec has public support by all major browsers (speaking broadly, without citations for particular features). The spec has evolved over the year which has caused some confusion, but now that the spec is moving closer to Proposed Recommendation, the feature set of webrtc-pc is fairly stable. One of the biggest pain-point in WebRTC between browsers was incompatible SDP but now everyone is using the same format. Since we are getting close to PR, implementer interest of shipping new features certainly need to be taken into account or they may be at risk. This is something which is currently being examined by editors and chairs, with representatives from Chrome, Firefox, Edge and Safari frequenting the editor's meetings.

Is there something in particular that we need to take more into account for future intents?
LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

Yoav Weiss

unread,
Jul 4, 2019, 5:37:34 AM7/4/19
to Henrik Boström, blink-dev, Max Solodovnikov, Daniel Bratell, sol...@gmail.com, Johnny Stenback
On Thu, Jul 4, 2019 at 11:14 AM Henrik Boström <hb...@chromium.org> wrote:
> I was hoping for something a bit more official, but I guess that shows it's not a super controversial change.

It isn't super controversial. The WebRTC spec has public support by all major browsers (speaking broadly, without citations for particular features). The spec has evolved over the year which has caused some confusion, but now that the spec is moving closer to Proposed Recommendation, the feature set of webrtc-pc is fairly stable. One of the biggest pain-point in WebRTC between browsers was incompatible SDP but now everyone is using the same format. Since we are getting close to PR, implementer interest of shipping new features certainly need to be taken into account or they may be at risk. This is something which is currently being examined by editors and chairs, with representatives from Chrome, Firefox, Edge and Safari frequenting the editor's meetings.

Is there something in particular that we need to take more into account for future intents?

Nothing in particular, but it would be great to keep track of the different vendors' opinions of the different features you're trying to ship.
If other vendors agree that everything that made it into the spec is something they also bless, then that's great. That's not typically the case in other WGs, which is why I asked.
 
LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d36bde85-ec89-478d-b929-218dca7cfcff%40chromium.org.

Henrik Boström

unread,
Jul 4, 2019, 5:43:38 AM7/4/19
to blink-dev, hb...@chromium.org, ma...@microsoft.com, bra...@opera.com, sol...@gmail.com, jste...@google.com


On Thursday, July 4, 2019 at 11:37:34 AM UTC+2, Yoav Weiss wrote:


On Thu, Jul 4, 2019 at 11:14 AM Henrik Boström <hb...@chromium.org> wrote:
> I was hoping for something a bit more official, but I guess that shows it's not a super controversial change.

It isn't super controversial. The WebRTC spec has public support by all major browsers (speaking broadly, without citations for particular features). The spec has evolved over the year which has caused some confusion, but now that the spec is moving closer to Proposed Recommendation, the feature set of webrtc-pc is fairly stable. One of the biggest pain-point in WebRTC between browsers was incompatible SDP but now everyone is using the same format. Since we are getting close to PR, implementer interest of shipping new features certainly need to be taken into account or they may be at risk. This is something which is currently being examined by editors and chairs, with representatives from Chrome, Firefox, Edge and Safari frequenting the editor's meetings.

Is there something in particular that we need to take more into account for future intents?

Nothing in particular, but it would be great to keep track of the different vendors' opinions of the different features you're trying to ship.
If other vendors agree that everything that made it into the spec is something they also bless, then that's great. That's not typically the case in other WGs, which is why I asked.

OK thanks. That's a good point. And some things will certainly be marked as "at risk" as a result of this work.
 
 
LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

sol...@gmail.com

unread,
Jan 16, 2020, 10:53:09 AM1/16/20
to blink-dev
Some further changes happened in the WebRTC 1.0 spec after original intent has been published (for details refer to webrtc-pc). Incorporating these changes into Chromium is tracked by the following ticket and CL.

Max Solodovnikov

unread,
Jan 16, 2020, 11:07:49 AM1/16/20
to blink-dev
Entry on the feature dashboard - https://chromestatus.com/feature/5698302152540160#
Reply all
Reply to author
Forward
0 new messages