Merging a UseCounter addition

51 views
Skip to first unread message

Donn Denman

unread,
Oct 5, 2023, 4:25:47 PM10/5/23
to blink-dev, Robert Kaplow, David Bokan
Can someone review a merge of new UseCounters in https://crrev.com/c/4915881?

I'm merging a CL that adds UseCounters, but my counters are not the next sequential values due to other additions that are not being merged. I'm thinking it's OK to add those values to third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom and the associated enums.xml even though they won't be used.

LMK if there's a better list to ask this question on.

Daniel Cheng

unread,
Oct 5, 2023, 4:39:13 PM10/5/23
to Donn Denman, blink-dev, Robert Kaplow, David Bokan
I think what you've done is fine; that being said, I probably would have just cherry-picked the specific use counter the diff uses, but I don't think it really makes a difference either way.

Daniel

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALCERB7%3DDLjqye-_u0g6X4k658f%3D6EHxcWJDTwL_djfFWR_fWQ%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages