Intent to Prototype and Ship: ::file-selector-button pseudo-element

81 views
Skip to first unread message

Emilio Cobos Álvarez

unread,
Dec 13, 2020, 12:51:24 PM12/13/20
to blink-dev
Contact emails
emi...@chromium.org

Explainer

https://github.com/w3c/csswg-drafts/issues/5049

Specification
https://github.com/w3c/csswg-drafts/pull/5788

Summary

Implements a standard version of ::-webkit-file-upload-button, see
https://github.com/w3c/csswg-drafts/issues/5049.

https://developer.mozilla.org/en-US/docs/Web/CSS/::file-selector-button

Blink component
Blink>CSS

TAG review
N/A (just effectively unprefixes an existing selector)

TAG review status
Not applicable

Risks


Interoperability and Compatibility
Gecko: Shipping (https://bugs.webkit.org/show_bug.cgi?id=219836)
WebKit: No signal, but sent a patch as well
(https://bugs.webkit.org/show_bug.cgi?id=219836)
Web developers: Positive: Feature was requested by web devs, bootstrap
is already using it: https://github.com/twbs/bootstrap/pull/31955

Debuggability
Same as other pseudo-elements.


Is this feature fully tested by web-platform-tests?
Yes

Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1086855

Launch bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1086855

Link to entry on the Chrome Platform Status
https://www.chromestatus.com/feature/5676301379698688

-- Emilio

Emilio Cobos Álvarez

unread,
Dec 13, 2020, 12:54:53 PM12/13/20
to blink-dev
Err, Gecko bug that enabled it is https://bugzilla.mozilla.org/show_bug.cgi?id=1662478 of course.

Manuel Rego Casasnovas

unread,
Dec 14, 2020, 6:01:54 AM12/14/20
to Emilio Cobos Álvarez, blink-dev
LGTM1, thanks for working on standarizing the pseudo-element.

On 13/12/2020 18:54, Emilio Cobos Álvarez wrote:
> Err, Gecko bug that enabled it is
> https://bugzilla.mozilla.org/show_bug.cgi?id=1662478 of course.
>
> On Sunday, December 13, 2020 at 6:51:24 PM UTC+1 Emilio Cobos Álvarez wrote:
>
> Contact emails
> emi...@chromium.org
>
> Explainer
>
> https://github.com/w3c/csswg-drafts/issues/5049
> <https://github.com/w3c/csswg-drafts/issues/5049>
>
> Specification
> https://github.com/w3c/csswg-drafts/pull/5788
> <https://github.com/w3c/csswg-drafts/pull/5788>
>
> Summary
>
> Implements a standard version of ::-webkit-file-upload-button, see
> https://github.com/w3c/csswg-drafts/issues/5049
> <https://github.com/w3c/csswg-drafts/issues/5049>.
>
> https://developer.mozilla.org/en-US/docs/Web/CSS/::file-selector-button
> <https://developer.mozilla.org/en-US/docs/Web/CSS/::file-selector-button>
>
>
> Blink component
> Blink>CSS
>
> TAG review
> N/A (just effectively unprefixes an existing selector)
>
> TAG review status
> Not applicable
>
> Risks
>
>
> Interoperability and Compatibility
> Gecko: Shipping (https://bugs.webkit.org/show_bug.cgi?id=219836
> <https://bugs.webkit.org/show_bug.cgi?id=219836>)
> WebKit: No signal, but sent a patch as well
> (https://bugs.webkit.org/show_bug.cgi?id=219836
> <https://bugs.webkit.org/show_bug.cgi?id=219836>)
> Web developers: Positive: Feature was requested by web devs, bootstrap
> is already using it: https://github.com/twbs/bootstrap/pull/31955
> <https://github.com/twbs/bootstrap/pull/31955>
>
> Debuggability
> Same as other pseudo-elements.
>
>
> Is this feature fully tested by web-platform-tests?
> Yes
>
> Tracking bug
> https://bugs.chromium.org/p/chromium/issues/detail?id=1086855
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1086855>
>
> Launch bug
> https://bugs.chromium.org/p/chromium/issues/detail?id=1086855
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1086855>
>
> Link to entry on the Chrome Platform Status
> https://www.chromestatus.com/feature/5676301379698688
> <https://www.chromestatus.com/feature/5676301379698688>
>
> -- Emilio
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/18472637-0e36-4f48-a492-8295f7460844n%40chromium.org
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/18472637-0e36-4f48-a492-8295f7460844n%40chromium.org?utm_medium=email&utm_source=footer>.

TAMURA, Kent

unread,
Dec 14, 2020, 7:04:12 PM12/14/20
to Emilio Cobos Álvarez, blink-dev
Will ::-webkit-file-upload-button be an alias of ::file-selector-button, or removed?


--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9dd001e6-958d-3373-a29c-e2b5cb8d5069%40chromium.org.


--
TAMURA Kent
Software Engineer, Google


Emilio Cobos Álvarez

unread,
Dec 14, 2020, 7:29:50 PM12/14/20
to TAMURA, Kent, blink-dev
On 12/15/20 1:03 AM, TAMURA, Kent wrote:
> Will ::-webkit-file-upload-button be an alias of ::file-selector-button,
> or removed?

I've kept it, so it shouldn't cause any breakage.

As I implemented it'd keep serializing as ::-webkit-file-upload-button,
just like ::placeholder and ::-webkit-input-placeholder work.

-- Emilio

> On Mon, Dec 14, 2020 at 2:51 AM Emilio Cobos Álvarez
> <emi...@chromium.org <mailto:emi...@chromium.org>> wrote:
>
> Contact emails
> emi...@chromium.org <mailto:emi...@chromium.org>
>
> Explainer
>
> https://github.com/w3c/csswg-drafts/issues/5049
> <https://github.com/w3c/csswg-drafts/issues/5049>
>
> Specification
> https://github.com/w3c/csswg-drafts/pull/5788
> <https://github.com/w3c/csswg-drafts/pull/5788>
>
> Summary
>
> Implements a standard version of ::-webkit-file-upload-button, see
> <https://developer.mozilla.org/en-US/docs/Web/CSS/::file-selector-button>
>
> Blink component
> Blink>CSS
>
> TAG review
> N/A (just effectively unprefixes an existing selector)
>
> TAG review status
> Not applicable
>
> Risks
>
>
> Interoperability and Compatibility
> Gecko: Shipping (https://bugs.webkit.org/show_bug.cgi?id=219836
> <https://bugs.webkit.org/show_bug.cgi?id=219836>)
> WebKit: No signal, but sent a patch as well
> (https://bugs.webkit.org/show_bug.cgi?id=219836
> <https://bugs.webkit.org/show_bug.cgi?id=219836>)
> Web developers: Positive: Feature was requested by web devs, bootstrap
> is already using it: https://github.com/twbs/bootstrap/pull/31955
> <https://github.com/twbs/bootstrap/pull/31955>
>
> Debuggability
> Same as other pseudo-elements.
>
>
> Is this feature fully tested by web-platform-tests?
> Yes
>
> Tracking bug
> https://bugs.chromium.org/p/chromium/issues/detail?id=1086855
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1086855>
>
> Launch bug
> https://bugs.chromium.org/p/chromium/issues/detail?id=1086855
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1086855>
>
> Link to entry on the Chrome Platform Status
> https://www.chromestatus.com/feature/5676301379698688
> <https://www.chromestatus.com/feature/5676301379698688>
>
>   -- Emilio
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org
> <mailto:blink-dev%2Bunsu...@chromium.org>.
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9dd001e6-958d-3373-a29c-e2b5cb8d5069%40chromium.org>.

TAMURA, Kent

unread,
Dec 14, 2020, 7:51:01 PM12/14/20
to Emilio Cobos Álvarez, blink-dev
LGTM2

yo...@yoav.ws

unread,
Dec 15, 2020, 2:06:37 AM12/15/20
to blink-dev, Kent Tamura, blink-dev, Emilio Cobos Álvarez
LGTM3
Reply all
Reply to author
Forward
0 new messages