Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

278 views
Skip to first unread message

Xiaochen Zhou

unread,
Jun 7, 2024, 11:11:05 AMJun 7
to blin...@chromium.org, Shivani Sharma, Josh Karlin, Sathish Manickam

Contact emails

xiaoc...@google.com, shiva...@google.com, jka...@google.com  


Explainer

https://github.com/WICG/turtledove/pull/1145


Specification

https://github.com/WICG/turtledove/pull/1141


Design docs

https://docs.google.com/document/d/1JSUZzEnVGn6Rz6ncLbyhThModoxTGnBn-jS5xJf4Aq0/edit?usp=sharing


Summary

We will complete the renderSize implementation to match what the Protected Audience explainer claims. The explainer states that if the Protected Audience generateBid function returns a render URL with size specified, then the browserSignals argument to the scoreAd function will have a renderSize field reflecting that size (so that all relevant information about the bid is available for scoring). However this was missed during implementation.


Setting this field is unlikely to break existing usage as this field has been a part of the explainer for 7 months and has always been optional. renderSize is only passed into scoreAd(), as part of browserSignals, if generateBid() returned a width and height. If it is specified, script can check whether the fix is enabled by executing: 


'renderSize' in browserSignals


See Github issue and explainer sections for renderSize.


Blink component

Blink>InterestGroups


TAG review

None


TAG review status

Not applicable


Risks



Interoperability and Compatibility

None


Gecko: No signal


WebKit: No signal


Web developers: No signals


Other signals:


WebView application risks

Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?

None



Debuggability

Additional debugging capabilities are not necessary for these feature changes.



Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?

No

Supported on all six Blink platforms except Android WebView.



Is this feature fully tested by web-platform-tests?

Yes, it is tested by third_party/blink/web_tests/external/wpt/fledge/tentative/score-ad-browser-signals.https.window.js.


Flag name on chrome://flags

None


Finch feature name

None


Non-finch justification

None


Requires code in //chrome?

False


Tracking bug

https://issues.chromium.org/u/1/issues/333628467


Launch bug

https://launch.corp.google.com/launch/4319084


Estimated milestones

No milestones specified



Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

None


Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5181817440436224


This intent message was generated by Chrome Platform Status



Vladimir Levin

unread,
Jun 11, 2024, 11:36:28 AMJun 11
to Xiaochen Zhou, blin...@chromium.org, Shivani Sharma, Josh Karlin, Sathish Manickam
Hi,

Can you please start the various reviews in chromestatus?
chipsna.png

Thanks,
Vlad

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALrW-V%2BWeRpO5f%3D%3DyMvbHrQHqs_FFT-w0-aKm37UyTtoSgTULA%40mail.gmail.com.

Xiaochen Zhou

unread,
Jun 11, 2024, 12:10:20 PMJun 11
to blink-dev, vmp...@chromium.org, blin...@chromium.org, Shivani Sharma, Josh Karlin, Sathish Manickam, Xiaochen Zhou
I have started the requests, thank you. This item was originated from a previous launch: https://chromestatus.com/feature/5140606359175168?gate=5143092244250624. This feature was added to the Protected Audience explainer, but was never implemented or spec'd. This launch implemented this missing feature and added it to the spec. Please refer to the previous launch for reviews, thank you.

Yoav Weiss (@Shopify)

unread,
Jun 12, 2024, 7:10:17 AMJun 12
to Xiaochen Zhou, blink-dev, vmp...@chromium.org, Shivani Sharma, Josh Karlin, Sathish Manickam
LGTM1

This sounds like a web-exposed bug fix, and I agree that the risk seems low.

Please add a runtime flag with a base feature for this, just in case this turns out riskier than expected.
 

Non-finch justification

None


Requires code in //chrome?

False


Tracking bug

https://issues.chromium.org/u/1/issues/333628467


Launch bug

https://launch.corp.google.com/launch/4319084


Estimated milestones

No milestones specified



Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

None


Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5181817440436224


This intent message was generated by Chrome Platform Status



--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALrW-V%2BWeRpO5f%3D%3DyMvbHrQHqs_FFT-w0-aKm37UyTtoSgTULA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Daniel Bratell

unread,
Jun 12, 2024, 10:06:56 AMJun 12
to Yoav Weiss (@Shopify), Xiaochen Zhou, blink-dev, vmp...@chromium.org, Shivani Sharma, Josh Karlin, Sathish Manickam

Chris Harrelson

unread,
Jun 12, 2024, 11:48:15 AMJun 12
to Daniel Bratell, Yoav Weiss (@Shopify), Xiaochen Zhou, blink-dev, vmp...@chromium.org, Shivani Sharma, Josh Karlin, Sathish Manickam
Reply all
Reply to author
Forward
0 new messages