Intent to Ship: Support for full 'filter' property syntax on SVG elements

70 views
Skip to first unread message

Fredrik Söderquist

unread,
Dec 18, 2020, 8:54:27 AM12/18/20
to blink-dev

Contact emails

f...@opera.com

Explainer

None

Specification

https://drafts.fxtf.org/filter-effects-1/

Summary

Allows the full syntax of the 'filter' property to be used on SVG elements which previously only supported single url(...) references. This allows filter functions such as blur(...), sepia(...) and grayscale(...) to apply to SVG elements as well as non-SVG elements. It makes the platform support for 'filter' more uniform and allows for easier application of some "canned" effects.



Blink component

Blink>SVG

Search tags

svg filters

TAG review

No TAG review because this is a feature that we already implement, and it has been shipping in Gecko for a number of years already.

TAG review status

Not applicable

Risks



Interoperability and Compatibility

The main risk is the lack of support in WebKit.


Gecko: Shipped/Shipping (https://bugzilla.mozilla.org/show_bug.cgi?id=1057180) (Shipped in FF 35)

WebKit: No signal (https://lists.webkit.org/pipermail/webkit-dev/2020-December/031653.html)

Web developers: Positive Bug currently has 44 stars.

Ergonomics

This addition should generally improve ergonomics because it removes one reason for adding special cases based on which element something will/could apply to. Performance should be in line with the already existing support.



Is this feature fully tested by web-platform-tests?

Yes

Tracking bug

https://crbug.com/109224

Sample links

https://css-tricks.com/almanac/properties/f/filter/

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5076637643177984

This intent message was generated by Chrome Platform Status.

Chris Harrelson

unread,
Dec 18, 2020, 12:45:55 PM12/18/20
to Fredrik Söderquist, blink-dev
LGTM1!

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHediLRe9L%3D5eYHX5q7O5QpujyNsowRZeNUsKMEXOqSVYjQTnw%40mail.gmail.com.

Manuel Rego Casasnovas

unread,
Dec 21, 2020, 2:04:25 AM12/21/20
to Chris Harrelson, Fredrik Söderquist, blink-dev
LGTM2

BTW, WebKit signals are positive now.

On 18/12/2020 18:45, Chris Harrelson wrote:
> LGTM1!
>
> On Fri, Dec 18, 2020 at 5:54 AM Fredrik Söderquist <f...@opera.com
> <mailto:f...@opera.com>> wrote:
>
>
> Contact emails
>
> f...@opera.com <mailto:f...@opera.com>
>
>
> Explainer
>
> None
>
>
> Specification
>
> https://drafts.fxtf.org/filter-effects-1/
> <https://drafts.fxtf.org/filter-effects-1/>
>
>
> Summary
>
> Allows the full syntax of the 'filter' property to be used on SVG
> elements which previously only supported single url(...) references.
> This allows filter functions such as blur(...), sepia(...) and
> grayscale(...) to apply to SVG elements as well as non-SVG elements.
> It makes the platform support for 'filter' more uniform and allows
> for easier application of some "canned" effects.
>
>
>
> Blink component
>
> Blink>SVG
> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ESVG>
>
>
> Search tags
>
> svg filters <https://chromestatus.com/features#tags:svg%20filters>
>
>
> TAG review
>
> No TAG review because this is a feature that we already implement,
> and it has been shipping in Gecko for a number of years already.
>
>
> TAG review status
>
> Not applicable
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
> The main risk is the lack of support in WebKit.
>
>
> Gecko: Shipped/Shipping
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1057180
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1057180>) (Shipped in
> <https://lists.webkit.org/pipermail/webkit-dev/2020-December/031653.html>)
>
> Web developers: Positive Bug currently has 44 stars.
>
>
> Ergonomics
>
> This addition should generally improve ergonomics because it removes
> one reason for adding special cases based on which element something
> will/could apply to. Performance should be in line with the already
> existing support.
>
>
>
> Is this feature fully tested by web-platform-tests
> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
>
> Yes
>
>
> Tracking bug
>
> https://crbug.com/109224 <https://crbug.com/109224>
>
>
> Sample links
>
> https://css-tricks.com/almanac/properties/f/filter/
> <https://css-tricks.com/almanac/properties/f/filter/>
>
>
> Link to entry on the Chrome Platform Status
>
> https://chromestatus.com/feature/5076637643177984
> <https://chromestatus.com/feature/5076637643177984>
>
> This intent message was generated by Chrome Platform Status
> <https://www.chromestatus.com/>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHediLRe9L%3D5eYHX5q7O5QpujyNsowRZeNUsKMEXOqSVYjQTnw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8OrFJJr2cFmeF%3D%3D8ZA-K6q1LJXf%2BgeggYKWwoQt2%3D7ig%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8OrFJJr2cFmeF%3D%3D8ZA-K6q1LJXf%2BgeggYKWwoQt2%3D7ig%40mail.gmail.com?utm_medium=email&utm_source=footer>.

Daniel Bratell

unread,
Dec 23, 2020, 7:55:22 AM12/23/20
to Manuel Rego Casasnovas, Chris Harrelson, Fredrik Söderquist, blink-dev
LGTM3

Nice to see this becoming a reliable feature of the web. Once WebKit
implements the final part, is this "done" from the web's point of view?

/Daniel

Fredrik Söderquist

unread,
Dec 23, 2020, 8:19:47 AM12/23/20
to Daniel Bratell, Manuel Rego Casasnovas, Chris Harrelson, blink-dev
On Wed, Dec 23, 2020 at 1:55 PM Daniel Bratell <brat...@gmail.com> wrote:
LGTM3

Nice to see this becoming a reliable feature of the web. Once WebKit
implements the final part, is this "done" from the web's point of view?

From a spec (Filter Effects L1) perspective, I guess the answer would be: "Almost done" (the filter() <image> value being the last hold-out)


/fs
Reply all
Reply to author
Forward
0 new messages