Blink-rel try bots do not run unit tests

116 views
Skip to first unread message

Stephen Chenney

unread,
Dec 1, 2023, 10:37:12 AM12/1/23
to blink-dev
I am surprised to discover that the various blink-rel try bots, say linux-blink-rel or win11-blink-rel, do not run blink_unittests or blink_platform_unittests or any other unit tests.

Is this deliberate?

I ask because I've been writing unit tests that depend on font metrics that differ across platforms, and I want to verify the tests on all those platforms. I recall being able to do this with the blink rel bots.

Stephen.

Xianzhu Wang

unread,
Dec 1, 2023, 11:36:02 AM12/1/23
to Stephen Chenney, blink-dev, Weizhong Xia
I think the blink try bots are mainly for rebaselining web tests. The CQ bots win-rel, linux-rel, mac-rel run blink unit tests. Running blink unit tests on all versions of platforms may be a rare requirement.

Weizhong, is there an easy way to force blink_unittests and blink_platform_unittests on the blink-rel try bots when needed?

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGsbWzS1e1nPWQcvahwVfonA20zYO1Z2Z9o4KYG14toyWs9VEA%40mail.gmail.com.

Jonathan Lee

unread,
Dec 1, 2023, 5:15:41 PM12/1/23
to blink-dev, Xianzhu Wang, blink-dev, Weizhong Xia, Stephen Chenney
The version-specific CI builders that run all test suites should have try mirrors. For example:

9JQTrzhr4wb4L2q.png

Then, you should be able to add CL footers to opt into the try mirrors, e.g.:

Cq-Include-Trybots: luci.chromium.try:mac_chromium_10.15_rel_ng

Stephen Chenney

unread,
Dec 3, 2023, 12:58:01 PM12/3/23
to Jonathan Lee, blink-dev, Xianzhu Wang, Weizhong Xia
Thanks for the info. It's clear now that my methodology for finding the platform specific try-bots for blink unit tests is not aligned with the actual set of platform specific try bots that run blink unit tests.

It seems worth explaining my use cases. I essentially only make changes in blink code, and frequently in places that may be sensitive to particular OS versions, such as fonts metrics. I always thought I could just use "blink" as a filter in Gerrit for the trybot selection and just select all the blink-rel bots. Then I discovered that these do not run unit tests and hence this mail thread and a bug report.

Am I right in understanding that I could get the same result by filtering on *chromium*rel_ng to see bots for the various platforms? Is the naming scheme consistent?

Stephen.
Reply all
Reply to author
Forward
0 new messages