Intent to Remove: Multiple Shadow Roots with a user agent shadow root

186 views
Skip to first unread message

Hayato Ito

unread,
Oct 14, 2015, 3:27:54 AM10/14/15
to blink-dev
Primary eng (and PM) emails

Link to "Intent to Deprecate" thread

Summary
Remove the support to call createShadowRoot for an element if it has a user agent shadow root, such as <input> element.

This "Intent to Remove: Multiple Shadow Roots with a user agent shadow root" is different from what I sent last month,"Intent to Remove: Multiple Shadow Roots" [1].


The last month's "Intent to Remove" is to remove "Multiple Shadow Roots" in general.

e.g.
A)
var div = document.createElement("div");
var sr1 = div.createShadowRoot();
var sr2 = div.createShadowRoot();   // We no longer supports.

This time, I'm going to remove the support for only the following case:

B)
var input = document.createElement("input");  // <input> has a user agent shadow root.
var sr1 = input.createShadowRoot();  // We no longer supports.

I'm going to remove only the case B. The case A continues to work.

We have a separate UseCounter for each: ElementCreateShadowRootMultiple and ElementCreateShadowRootMultipleWithUserAgentShadowRoot. The former is inclusive of the latter.

Motivation
This feature has been a cause of code complexity. It would be great to remove the support partially ahead of removing "Multiple Shadow Roots" entirely, in terms of code health.

Compatibility Risk
Low. Blink has supported this feature since M35.
No other browser supports this feature.

Usage information from UseCounter

For reference, the usage information for Multiple Shadow Roots (in general) is 0.0058%  https://www.chromestatus.com/metrics/feature/timeline/popularity/779

OWP launch tracking bug

Entry on the feature dashboard

TAMURA, Kent

unread,
Oct 14, 2015, 3:56:14 AM10/14/15
to Hayato Ito, blink-dev
lgtm to remove.  The usage looks almost zero.

--
TAMURA Kent
Software Engineer, Google


Chris Harrelson

unread,
Oct 14, 2015, 1:38:38 PM10/14/15
to TAMURA, Kent, Hayato Ito, blink-dev
LGTM2

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Philip Jägenstedt

unread,
Oct 20, 2015, 10:35:34 AM10/20/15
to Chris Harrelson, TAMURA, Kent, Hayato Ito, blink-dev
LGTM3
Reply all
Reply to author
Forward
0 new messages