Re: [blink-dev] Intent to Implement and Ship: <dialog>: add DialogShowParams to show()/showModal()

18 views
Skip to first unread message

Rick Byers

unread,
Jan 2, 2017, 8:53:43 AM1/2/17
to Chris Harrelson, Dan Beam, blink-dev
Updated subject.

This looks reasonable to me.  There's approval on the PR from @nt1m from Mozilla and feedback from @smaug---- (Gecko DOM lead) was addressed.  We should wait for the spec change to land before shipping IMHO.

On Sun, Jan 1, 2017 at 7:38 PM, Chris Harrelson <chri...@chromium.org> wrote:
Hi,

Since this is an intent to implement *and* ship, could you resend with that changed subject line?

While the change seems reasonable, I don't see much engagement outside of Chromium team members/Googlers. Has it seen sufficient exposure for people to comment?

Chris

On Thu, Dec 29, 2016 at 2:38 PM, Dan Beam <db...@chromium.org> wrote:
db...@chromium.org https://github.com/whatwg/html/pull/2197 Adds parameters to change how show() or showModal() is called. Currently, this allows bypassing initial focus, which is set when a dialog is shown. Some folks just don't want initial focus to be set. See: https://github.com/whatwg/html/issues/1929 for more context. Firefox: Public support Edge: No public signals Safari: No public signals Web developers: Positive Basically none. This code (and its tests) need to be maintained. Yes https://bugs.chromium.org/p/chromium/issues/detail?id=677562 https://www.chromestatus.com/features/5121613552943104 Yes

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.


Steve Faulkner

unread,
Jan 2, 2017, 11:05:28 AM1/2/17
to Rick Byers, Chris Harrelson, Dan Beam, blink-dev
I suggest that this addition is unecessary, what should be fixed is the default behaviour.  as it is poor UX and poor accessibility, some reasons here: https://github.com/whatwg/html/issues/1929#issuecomment-269790518  By default the focus should be on the dialog element and only if the developer wants to have focus set on a control when the dialog is displayed they could then use the autofucus attribute or JS .focus()
Reply all
Reply to author
Forward
0 new messages