Intent to Implement and Ship: Change <dialog> from position: absolute to position: fixed.

[Ian Kilpatrick]

Contact emails

ikilp...@chromium.org

Explainer

None

Specification

https://github.com/w3c/csswg-drafts/issues/4645

Summary

Blink shipped the <dialog> element[1] using a somewhat complex positioning scheme. The CSSWG discussed a change to this positioning scheme using "position: fixed" instead, and auto-margins to achieve centering. See [2]. We believe this should be broadly compatible with existing use (as the dialog is placed in the "top-layer"). [1] https://html.spec.whatwg.org/#the-dialog-element [2] https://github.com/w3c/csswg-drafts/issues/4645

Blink component

Blink

TAG review

None

TAG review status

Not applicable

Risks

Interoperability and Compatibility

We've shipped this feature for quite a while, we added two use-counters to determine if this would be web-compatible. https://www.chromestatus.com/metrics/feature/timeline/popularity/3329 https://www.chromestatus.com/metrics/feature/timeline/popularity/3330 Broadly speaking - we believe this should be web-compatible.

Gecko: In development (https://groups.google.com/g/mozilla.dev.platform/c/gqi4MDQDwX8/m/WKgnucKUAwAJ)

WebKit: No signal (https://github.com/w3c/csswg-drafts/issues/4645#issuecomment-635675187)

Web developers: No signals

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

No

Is this feature fully tested by web-platform-tests?

Yes

Link to entry on the Chrome Platform Status

https://www.chromestatus.com/feature/5756963046555648

This intent message was generated by Chrome Platform Status.

[Domenic Denicola]

From: Ian Kilpatrick <ikilp...@chromium.org>

> Specification
> https://github.com/w3c/csswg-drafts/issues/4645

Could you work to update the HTML Standard as part of this shipping? The relevant sections would be https://html.spec.whatwg.org/#normal-alignment and https://html.spec.whatwg.org/#flow-content-3.

> Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
> No

I'm curious what platform it won't be supported on?

[Ian Kilpatrick]

On Tue, Sep 22, 2020 at 1:15 PM Domenic Denicola <d...@domenic.me> wrote:

From: Ian Kilpatrick <ikilp...@chromium.org>

> Specification
> https://github.com/w3c/csswg-drafts/issues/4645

Could you work to update the HTML Standard as part of this shipping? The relevant sections would be https://html.spec.whatwg.org/#normal-alignment and https://html.spec.whatwg.org/#flow-content-3.

I took the "delete all the things" approach. https://github.com/whatwg/html/pull/5936/commits/ab983f09e6da4e06e7c07fe8ae7368c3ca5d67a2

 

> Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
> No

I'm curious what platform it won't be supported on?

Supported everywhere - must have missed a field in chromestatus.  

[Chris Harrelson]

LGTM1

No TAG review is required in this case, in my view, because this is a small layout change to an existing feature that is shipped on Chromium browsers already, and will result in interop with the in-progress Gecko feature.

Please do email webkit-dev also to get an official position rather than a comment on an issue. Perhaps this would result in them changing their behavior in concert to further de-risk interop? Worth asking them that as well.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpTSZrYuqTyHOBhfSiYmmNf%2BYLV_UVmE1rxtowhgBmQH5w%40mail.gmail.com.

[Ian Kilpatrick]

On Tue, Sep 22, 2020 at 2:04 PM Chris Harrelson <chri...@chromium.org> wrote:

LGTM1

No TAG review is required in this case, in my view, because this is a small layout change to an existing feature that is shipped on Chromium browsers already, and will result in interop with the in-progress Gecko feature.

Please do email webkit-dev also to get an official position rather than a comment on an issue. Perhaps this would result in them changing their behavior in concert to further de-risk interop? Worth asking them that as well.

Yup. Also I'm 99% certain the WebKit never shipped the <dialog> element with this rendering behaviour (see dialog.css) 

[Mike West]

I generally agree with Chris' logic above. The direction seems good, and I'm happy to see us moving in concert with Firefox. That said, Domenic raised a quite reasonable question about `show()` vs `showModal()` on the PR. It seems reasonable to ship only after resolving that question; can you validate that our implementation (and the spec) remain consistent with Firefox's?

-mike

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpREcq1rkYkG9%3DdF6Wn-osY3Na4YS48nqJRaGoA5K3X8Xg%40mail.gmail.com.

[Mike West]

Friendly ping. Is the conversation around the PR still ongoing?

-mike

[Ian Kilpatrick]

Close - one small disagreement left on the pull request - (but no fundamental disagreements).

https://github.com/whatwg/html/pull/5936#discussion_r514394976

[Ian Kilpatrick]

Bump on this now it has been merged.

[Chris Harrelson]

LGTM1

[Yoav Weiss]

LGTM2

Please file implementation bugs on WebKit and Firefox (if there aren't ones open already).

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2BN6QZvm%2B7_H-rA_0xPd0dPkUxRttEPrqx5LT6NXT5pL_uEc5A%40mail.gmail.com.

[Ian Kilpatrick]

Currently chromium is the only engine to have implemented and ship dialog. The relevant bugs for <dialog> more generally in the other browsers are:
https://bugs.webkit.org/show_bug.cgi?id=84635

https://bugzilla.mozilla.org/show_bug.cgi?id=840640

[Mike West]

LGTM3. Thank you for working through the spec and interop details!

-mike