This change brings Chromium code in line with the latest W3C spec for SVGGeometryElement and SVGPathElement in terms of usage of DOMPointInit over SVGPoint for getCharNumAtPosition, isPointInFill, isPointInStroke. The change has already landed: https://chromium-review.googlesource.com/c/chromium/src/+/6284886 Firefox and Safari already have this live making this a fairly safe change to land. Details for both added under Signals for both.
This is already implemented in Firefox and Safari with no reported open issues. Moreover, DOMPointInit is a superset of SVGPoint, but the extra params do have default values to support backward compatibility. We have however introduced some checks on Nan/Infinite values but those are exclusively to handle invalid requests to these APIs, say trying to access points at (Infinity, Nan) - (x,y) coordinate. And even then, we simply return back with a default value instead of throwing back an exception.
Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?
None
The SVGTextContentElement interface in JavaScript is implemented by elements that support rendering child text content. This interface is inherited by various text-related interfaces, such as SVGTextElement, SVGTSpanElement, SVGTRefElement, and SVGTextPathElement. Any of the above elements can be used to access and test APIs in SVGTextContentElement interface. For SVGGeometryElement, it is implemented by Geometry elements like SVGRectElement and SVGCircleElement. Objects of these classes can be used to access and test APIs in SVGGeometryElement interface.
* https://wpt.fyi/results/svg/types/scripted/SVGAnimatedEnumeration-SVGTextContentElement.html * https://wpt.fyi/results/svg/types/scripted/SVGGeometryElement.isPointInFill-01.svg
This is a simple spec catch up in Chromium which is already implemented in Firefox and Safari. Also, this change cannot be put behind a feature flag since it is a change in method/API signature. However, Firefox and Safari already have this live making this a fairly safe change to land. Details for both added under Signals for both.
Shipping on desktop | 136 |
Shipping on Android | 136 |
Shipping on iOS | 136 |
Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).
NoneContact emails
vinay...@microsoft.comExplainer
NoneSpecification
https://svgwg.org/svg2-draftSummary
This change brings Chromium code in line with the latest W3C spec for SVGGeometryElement and SVGPathElement in terms of usage of DOMPointInit over SVGPoint for getCharNumAtPosition, isPointInFill, isPointInStroke. The change has already landed: https://chromium-review.googlesource.com/c/chromium/src/+/6284886 Firefox and Safari already have this live making this a fairly safe change to land. Details for both added under Signals for both.
Blink component
Blink>SVGTAG review
NoneTAG review status
Not applicableRisks
Interoperability and Compatibility
This is already implemented in Firefox and Safari with no reported open issues. Moreover, DOMPointInit is a superset of SVGPoint, but the extra params do have default values to support backward compatibility. We have however introduced some checks on Nan/Infinite values but those are exclusively to handle invalid requests to these APIs, say trying to access points at (Infinity, Nan) - (x,y) coordinate. And even then, we simply return back with a default value instead of throwing back an exception.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67e2ef0b.170a0220.2e951e.01ad.GAE%40google.com.
You don't often get email from tk...@chromium.org.
Learn why this is important
|
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67e2ef0b.170a0220.2e951e.01ad.GAE%40google.com.
LGTM1
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67e2ef0b.170a0220.2e951e.01ad.GAE%40google.com.
--
TAMURA Kent
Software Engineer, Google
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f79155ea-f89d-4347-ac5b-801f3e5ea310n%40chromium.org.
LGTM3
/Daniel