flag-specific + FlagExpectations + virtual

33 views
Skip to first unread message

Vladimir Levin

unread,
Jul 14, 2023, 2:03:35 PM7/14/23
to blink-dev
Hi,

Is there any documentation for the following directories or any planned work to structure them better?

blink/third_party/web_tests/flag-specific
blink/third_party/web_tests/FlagExpectations
blink/third_party/web_tests/virtual

I know that `FlagExpectations` mirrors TestExpectations for each flag (aka virtual test suite?)

`virtual` seems to be READMEs that describe the particular virtual test suite (I'm not sure where this is used -- is this useful?)

`flag-specific` is where flag specific expectations are (not to be confused with FlagExpectations), and it's also a directory that takes me an embarrassingly long amount of time to find every time I have to look in there

I don't have any specific proposals, but I was just wondering if others felt that it is currently not the best structure. Maybe we can come up with something better, or at least help me frame it in a way that I can remember :)

Thanks,
vmpstr

Xianzhu Wang

unread,
Jul 14, 2023, 4:51:29 PM7/14/23
to Vladimir Levin, blink-dev
This document describes the relationship between flag-specifc and virtual suites.

Perhaps we should
- move FlagExpectations/flag-name to flag-specific/flag-name/TestExpectations
- require README.md under each flag-specifc/flag-name
- add web_tests/README.md, web_tests/flag-specific/README.md, which could just reference the above document.


--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2Okx6LPqbOJR8irh7JN%2BcKcEAeOSbgszrEJmgu3eurbSg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages