Intent to Remove: overflowchanged event

117 views
Skip to first unread message

Philip Jägenstedt

unread,
Feb 19, 2015, 3:10:34 AM2/19/15
to blink-dev, jro...@microsoft.com

Primary eng (and PM) emails

phi...@opera.com


Link to “Intent to Deprecate” thread

https://groups.google.com/a/chromium.org/d/msg/blink-dev/1RCzsyEyNU8/5vNpxrhRbUIJ


See also the first Intent to Remove, which prompted me to deprecate it and which was just pinged by Jacob Rossi from Microsoft:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/yBr6Aw3UokU/KjMjcG8eO0YJ

Summary

Remove the overflowchanged event


Motivation

This is a WebKit/Blink-only feature. I've not been able to find any discussion about standardizing it. There are some interesting comments in https://bugs.webkit.org/show_bug.cgi?id=67583


Jacob Rossi noted that "IE removed a similar event, onresize for individual elements, a good while back due to some of the reasons cited in the mails linked above about lack of interoperability and implementation-specific differences about when these events would necessarily fire."


Usage information from UseCounter

https://www.chromestatus.com/metrics/feature/timeline/popularity/208


There's good news here, the counter has been consistently at zero since June 2014. The deprecation message reach stable with M37 at the end of August 2014.


The counter is for when an event listener is added, not when the event is fired, so it includes more potential problems.

Entry on chromestatus.com

None


Compatibility Risk

There's a lot of discussion in the Intent to Deprecate. A CSS-Element-Queries Polyfill was mentioned, but that code has since been replaced:

https://github.com/marcj/css-element-queries/commit/d96e17397c3fa3e6cea96b239ef02628169267f0


Code similar to this is certain to still exist in the wild somewhere, but given the usage we can say that it isn't very widely used.

Dimitri Glazkov

unread,
Feb 19, 2015, 12:16:39 PM2/19/15
to Philip Jägenstedt, blink-dev, jro...@microsoft.com
LGTM.

:DG<

TAMURA, Kent

unread,
Feb 19, 2015, 6:00:34 PM2/19/15
to Dimitri Glazkov, Philip Jägenstedt, blink-dev, jro...@microsoft.com
LGTM2

--
TAMURA Kent
Software Engineer, Google


Chris Harrelson

unread,
Feb 22, 2015, 6:35:29 PM2/22/15
to TAMURA, Kent, Dimitri Glazkov, Philip Jägenstedt, blink-dev, jro...@microsoft.com
LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Philip Jägenstedt

unread,
Feb 25, 2015, 3:35:19 AM2/25/15
to Chris Harrelson, TAMURA, Kent, Dimitri Glazkov, blink-dev, Jacob Rossi
Thanks all.

Unfortunately, I've learned that the Chromium Dashboard has been
changed to have far lower precision, making anything less than 0.01%
appear as zero. At the time of deprecation it was ~0.006% and it's
possible that it still around there.

I'm still going to prepare a CL to remove it, but if someone at Google
wants to check the internal data and say not LGTM, that's
understandable.

I'm hoping that the Chromium Dashboard can be changed to have at least
0.001% granularity, as some removals aren't worthwhile at 0.005% but
would be if it's really zero usage.

Philip

Philip Jägenstedt

unread,
Feb 25, 2015, 8:28:08 PM2/25/15
to Chris Harrelson, Eric Bidelman, TAMURA, Kent, Dimitri Glazkov, blink-dev, Jacob Rossi
Hi all,

Eric Bidelman helped me investigate this and it turns out that it was a server bug after all. The data is now back to normal and the OverflowChangedEvent counter is reaching up to 0.0046% on some days.

At this usage the removal may not be completely smooth sailing. I am preparing a CL to put it behind a flag. If we get bug reports on the beta channel we can turn it back on while we try to help the affected sites find a standard solution. Does that sound like an OK plan?

Philip

Chris Harrelson

unread,
Feb 26, 2015, 12:27:14 AM2/26/15
to Philip Jägenstedt, Eric Bidelman, TAMURA, Kent, Dimitri Glazkov, blink-dev, Jacob Rossi

Sure sounds good.

Reply all
Reply to author
Forward
0 new messages