Intent to Ship : Content-type in Resource Timing

218 views
Skip to first unread message

Abin Paul

unread,
Apr 7, 2023, 7:11:18 PM4/7/23
to blin...@chromium.org

Contact emails

abin....@gmail.com


Explainer

https://github.com/abinpaul1/resource-timing/blob/explainer-content-type/Explainers/Content-Type.md


Specification

Resource Timing PR : https://github.com/w3c/resource-timing/pull/341

Fetch PR : https://github.com/whatwg/fetch/pull/1481



Summary

Adds a field to PerformanceResourceTiming that holds a string corresponding to the Content-type header of the fetched resource when the resource was fetched.



Blink component

Blink>PerformanceAPIs>ResourceTiming


TAG review

https://github.com/w3ctag/design-reviews/issues/785


TAG review status

Issues addressed


Risks



Interoperability and Compatibility



Gecko: Positive (https://github.com/mozilla/standards-positions/issues/705)


WebKit: No signal (https://github.com/WebKit/standards-positions/issues/88)


Web developers

Developer interest for the feature : https://github.com/w3c/resource-timing/issues/203


Other signals:


Ergonomics

No



Activation

No risks



Security

No risks



WebView application risks

Does this intent deprecate or change behaviour of existing APIs, such that it has potentially high risk for Android WebView-based applications? No



Debuggability

The new attribute shows up in Devtools. No implementation changes are required.


Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes


Is this feature fully tested by web-platform-tests?

Yes

https://wpt.fyi/results/resource-timing/content-type.html?label=master&label=experimental&aligned

https://wpt.fyi/results/resource-timing/content-type-parsing.html?label=master&label=experimental&aligned

Flag name

#enable-experimental-web-platform-features


Requires code in //chrome?

False


Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=1366706



Non-OSS dependencies

Does the feature depend on any code or APIs outside the Chromium open source repository and its open-source dependencies to function?

No


Estimated milestones


Chrome for desktop 115

Chrome for Android 115

Android Webview 115



Anticipated spec changes

No ongoing discussion that could lead to future changes



Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5156068351541248


Links to previous Intent discussions

Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/Dk2uL_gXpZc/m/OhY2ZomeAwAJ

Yoav Weiss

unread,
Apr 11, 2023, 5:27:44 AM4/11/23
to Abin Paul, blin...@chromium.org
Thanks for working on this Abin and for pushing this over the line!! (I'm recusing myself as an API owner, as I was involved in that work)

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM2ZH3c1k1fLSb-GmSPEs9MsZDY-O3TaGn9PuvT7DL2NATWFPQ%40mail.gmail.com.

Mike Taylor

unread,
Apr 11, 2023, 6:55:05 PM4/11/23
to Yoav Weiss, Abin Paul, blin...@chromium.org

Daniel Bratell

unread,
Apr 12, 2023, 11:26:01 AM4/12/23
to Mike Taylor, Yoav Weiss, Abin Paul, blin...@chromium.org

Rick Byers

unread,
Apr 19, 2023, 12:03:50 PM4/19/23
to Daniel Bratell, Mike Taylor, Yoav Weiss, Abin Paul, blin...@chromium.org
Hi Abin (or Yoav?),
What's blocking this spec PR from landing? As discussed here, our standard process is to do what we can to get spec changes fully landed if possible.

Thanks,
   Rick

Yoav Weiss

unread,
Apr 20, 2023, 2:36:05 AM4/20/23
to Rick Byers, Daniel Bratell, Mike Taylor, Abin Paul, blin...@chromium.org
On Wed, Apr 19, 2023 at 6:03 PM Rick Byers <rby...@chromium.org> wrote:
Hi Abin (or Yoav?),
What's blocking this spec PR from landing?

Nothing is blocking AFAICT. Just a matter of someone with permissions clicking the button.
  
As discussed here, our standard process is to do what we can to get spec changes fully landed if possible.

I think this can wait a few days until the button-clicking happens.

Yoav Weiss

unread,
May 3, 2023, 3:56:06 AM5/3/23
to Rick Byers, Anne van Kesteren, Daniel Bratell, Mike Taylor, Abin Paul, blin...@chromium.org
Update: +Anne van Kesteren has been working on a new MimeSniff spec concept that will enable this feature to only expose supported mime types, rather than any arbitrary one. (to prevent a threat model Apple folks are concerned with, without harming the use-cases the feature is tackling)

We'd need to modify the spec PR and implementation to rely on that concept.

Mike Taylor

unread,
May 15, 2023, 10:43:52 AM5/15/23
to Yoav Weiss, Rick Byers, Daniel Bratell, Abin Paul, blin...@chromium.org, Anne van Kesteren

I see that both the Resource Timing and Fetch PRs have landed - does that mean this I2S is unblocked now (and just needs an LGTM3)?

Yoav Weiss

unread,
May 15, 2023, 10:45:26 AM5/15/23
to Mike Taylor, Rick Byers, Daniel Bratell, Abin Paul, blin...@chromium.org, Anne van Kesteren
On Mon, May 15, 2023 at 4:43 PM Mike Taylor <mike...@chromium.org> wrote:

I see that both the Resource Timing and Fetch PRs have landed - does that mean this I2S is unblocked now (and just needs an LGTM3)?


I believe so.
 

Rick Byers

unread,
May 24, 2023, 11:47:07 AM5/24/23
to Yoav Weiss, Mike Taylor, Daniel Bratell, Abin Paul, blin...@chromium.org, Anne van Kesteren
Thanks, LGTM3

Barry Pollard

unread,
10:12 AM (4 hours ago) 10:12 AM
to blink-dev, rby...@chromium.org, mike...@chromium.org, Daniel Bratell, abin....@gmail.com, blin...@chromium.org, ann...@annevk.nl, Yoav Weiss
I've just discovered this was never shipped by default. I can't see a reason why and speaking to Yoav who was involved at the time, and digging through the CLs and bugs I think this was simply an oversight. The work is done, so I'd like to enable this by default. I don't think the original owner (Abin) is still involved (feel free to tell me if that's not the case, or if you remember any more background here Abin!), but I'm happy to do the small amount of work to see this through.

The bug (https://issues.chromium.org/issues/40239837) shows some complication with landing it due to test failures and it was reverted several times, but eventually landed (behind a flag) over two years ago. Perhaps this explains the confusion in ensuring it eventually landed by default? It has been running on our non-stable channels ever since.

We had API owner approval back then, and Firefox have also shipped this API in the meantime. However, it's been nearly three years since this was approved, so it would be good to get API approvals again. I can't seem to reset it in chromestatus but will hold off until I get confirmation here.

Let me know if you have any questions (or if any of you have any more relevant background here?).

Thanks,
Barry

Rick Byers

unread,
10:19 AM (4 hours ago) 10:19 AM
to Barry Pollard, blink-dev, mike...@chromium.org, Daniel Bratell, abin....@gmail.com, ann...@annevk.nl, Yoav Weiss
Thanks Barry. This seems small and non-controversial, you can consider previous API owners LGTM3 to still apply. Let us know if you think there are new material tradeoffs we should weigh in on, but otherwise I see no need for you to block on getting further API owner approval.

Rick

Mike Taylor

unread,
10:20 AM (4 hours ago) 10:20 AM
to Barry Pollard, blink-dev, rby...@chromium.org, Daniel Bratell, abin....@gmail.com, ann...@annevk.nl, Yoav Weiss

I don't think you need re-approvals - thanks for catching this and good luck with the rollout. But please come back and report if you run into any issues that xrequire you to back it out/pause the launch.

Reply all
Reply to author
Forward
0 new messages