Intent to Implement and Ship: Make |type| optional in WakeLock.request()

141 views
Skip to first unread message

Kubo Da Costa, Raphael

unread,
Oct 2, 2020, 6:59:26 AM10/2/20
to blin...@chromium.org

Contact emails

raphael.ku...@intel.comrei...@chromium.org

Explainer

https://github.com/w3c/screen-wake-lock/blob/gh-pages/explainer.md

Specification

https://w3c.github.io/screen-wake-lock/#the-wakelock-interface

Summary

Implement https://github.com/w3c/screen-wake-lock/pull/291, which makes the |type| parameter in WakeLock.request() optional and defaulting to "screen", which is the only allowed value at the moment. In other words, the following two lines would to the exact same thing:

    navigator.wakeLock.request();
    navigator.wakeLock.request("screen");

Blink component

Blink>WakeLock

TAG review

https://github.com/w3ctag/design-reviews/issues/543

TAG review status

Not applicable

Risks



Interoperability and Compatibility

This change is backwards-compatible. Existing code will continue to work, and new code can choose to call either "navigator.wakeLock.request()" or "navigator.wakeLock.request('screen')".

Gecko: Worth prototyping (https://mozilla.github.io/standards-positions/#screen-wake-lock)

WebKit: No signal (https://bugs.webkit.org/show_bug.cgi?id=205104) No activity on the mailing list after https://lists.webkit.org/pipermail/webkit-dev/2020-February/031083.html

Web developers: No signals


Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes

Is this feature fully tested by web-platform-tests?

Yes

Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=1133696

Link to entry on the Chrome Platform Status

https://www.chromestatus.com/feature/5725750881681408

This intent message was generated by Chrome Platform Status.


Yoav Weiss

unread,
Oct 5, 2020, 1:35:41 AM10/5/20
to Kubo Da Costa, Raphael, blin...@chromium.org
LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4de7fbf9717243769c3ee577cf370f89%40intel.com.

Mike West

unread,
Oct 7, 2020, 9:24:45 AM10/7/20
to blink-dev, yo...@yoav.ws, blin...@chromium.org, Raphael Kubo Da Costa
LGTM2. Thanks for following up on comments from the TAG review.

Daniel Bratell

unread,
Oct 7, 2020, 10:50:24 AM10/7/20
to Mike West, blink-dev, yo...@yoav.ws, Raphael Kubo Da Costa
Reply all
Reply to author
Forward
0 new messages