Contact emails
wanmi...@intel.com, hong....@intel.com, foo...@chromium.org
Spec
https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timer-initialisation-steps
No TAG review requested as this does not add/alter any API surfaces.
Summary
Calls to setTimeout(..., 0) were previously clamped to a 1 ms timeout for historical reason: https://bugs.chromium.org/p/chromium/issues/detail?id=402694, This is very old, http://trac.webkit.org/changeset/17156 appeared to add it (10/20/06).
This is actually a bug since there's no 1ms clamp in the spec, and which will cause scheduling error, e.g.
setTimeout(()=> console.log('1ms timeout'), 1);
setTimeout(()=> console.log('0ms timeout'), 0);
Outputs:
Chrome 87: 1ms timeout, 0ms timeout
Moreover, 1ms clamp may bring performance penalty.
Link to “Intent to Prototype” blink-dev discussion
N/A
Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes
Risks
Interoperability and Compatibility
Firefox: no 1ms clamp
Safari: 1ms clamp (WebKit's clamp at https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/DOMTimer.cpp#L384)
Some tests/live web pages that depended on this 1ms clamp may fail/meet issue.
Is this feature fully tested by web-platform-tests? Link to test suite results from wpt.fyi.
No, no specific test for setTimeout(…, 0) is actually 0ms timeout, this is actually not necessary.
Entry on the feature dashboard
https://www.chromestatus.com/feature/4889002157015040
Thanks,
Wanming
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/025bd7a7-6be1-4b77-9c3a-32bb6b295812n%40chromium.org.
Thanks all for your comments! I've created a WebKit issue at: https://bugs.webkit.org/show_bug.cgi?id=221124The main motivation of this intent-to-ship is to correct the scheduling and reduce potential performance impact. We didn't find impact on live sites with/without 1ms clamp maybe they‘ve already avoided the usage of setTimeout(..., 0) since compatible risk is really existed.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5c1d6691-1ccd-4451-a491-56990ecc695fn%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEhAvLduQ6XXA-Vm-8%3DTM9L-d5q1_h-DrvrKLHg8NBvxEQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/095fc193-27e5-4a7c-b816-edbab7eb176cn%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYfU0La%3D3Fpd%3DHBVQ2phHuvMSozpOsXqt-NR-mtWepRJPQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2869319d-e852-4f3b-8471-611f6ae7c9b4n%40chromium.org.
As Chris said, it's good that you managed to identify some
problematic areas during the beta phase. Of course it would have
been more pleasant with no problems at all, but this was always a
risky change. Hopefully you can use these bug reports to figure
out a version of this change that doesn't cause those problems.
From a process point of view we will consider this intent "on
hold" until you think it is ready to try again. At such a time,
just return to this thread (or file a new intent if you think that
would be cleaner).
/Daniel
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8JUEZDbfNsmXJWhcz_N7zcRwzoips2r_DzMEqhctwr1g%40mail.gmail.com.
Moreover, is there other workaround solution to push the optimization forward?
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b155d685-4b7e-498b-8e8a-1e9c95d4195an%40chromium.org.
Hi Chris, Daniel and all,The blocker issue https://bugs.chromium.org/p/chromium/issues/detail?id=1209717 has been fixed now, and per above performance improvement @verwaest reported, can we start testing on Beta again?
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f2f1d2cf-0b9b-4ed4-ac0e-4f7d9a20e4c1n%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cb9aacdf-dc28-42b0-90cd-6c0faec080ffn%40chromium.org.
Hi all,
Thanks Philip's bridge, I've been connected with the release managers and completed the new round of origin trial on M95 (we reached an agreement on reverting the change after the first M95 Beta release itself). During this period, I didn't receive any relevant bugs.
But unfortunately, after the origin trial, the fix for the previous block issue #1209717 was reverted due to regression at issue #1254867, @rakina is considering that maybe we can do nothing here because per crbug.com/1205285#c16, the original bug on Wikipedia has been fixed on Wikipedia's side.
So we are looking forward your feedbacks, on both the bug of #1209717 and what's the next step to move forward this intent-to-ship. Many thanks in advance!
Thanks,
Wanming
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5c0e9914-2d52-4e08-b041-c9ee4d5042cdn%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVtUZ63ZiiCLcFCYD2%2BnpOrt3g0anJQ3R-to0x%3DbNG_9A%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6d9cd96f-fd70-83bf-63cb-985fa7c27b07%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfX2K1V0CXc1Z%3DKJ_BUZ2MsZVmgzX0DfOkjZO1Lm7-NqnA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dec6a8e0-14c3-44e4-851c-66f95a370238n%40chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
LGTM2 to run on beta, making sure this is web compatible.
/Daniel
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dec6a8e0-14c3-44e4-851c-66f95a370238n%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/00e18e77-f4d5-42d2-b31f-177acd016854n%40chromium.org.
Hi Scott,
Running at 75% for 2 to 3 weeks sounds reasonable to me. If you don't find anything interesting (fingers crossed?), can you send an Intent to Experiment with the proposed experiment (%, timelines, etc) for Stable?
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXGoJ1h0MV8Z%2BABbVvvPWsUjLxPou_-SzE6O50s8CPSsedLHw%40mail.gmail.com.