Intent to Deprecate and Remove: WebKitAnimationEvent interface

瀏覽次數:109 次
跳到第一則未讀訊息

Stephen Mcgruer

未讀,
2018年9月12日 上午10:39:592018/9/12
收件者:blin...@chromium.org

Primary eng (and PM) emails

smcg...@chromium.org


Summary

Deprecate and remove WebKitAnimationEvent interface. WebKitAnimationEvent is the prefixed version of AnimationEvent. AnimationEvent is the event interface used for events relating to CSS Animations (e.g. animationstart).


The ability to create WebKitAnimationEvent from document.createEvent was removed last year, and WebKitAnimationEvent has been an alias of AnimationEvent for a long time (multiple years):


> window.WebKitAnimationEvent

ƒ AnimationEvent() { [native code] }


The only remaining way a web developer can interact with WebKitAnimationEvent is to access it via window, to either check it exists or to create an event from it. It makes no sense for a web developer to manually create such an event (that I am aware).


I would prefer to remove immediately (targeting M71), but would also be happy to land a deprecation warning for M71 and remove in M72.


Motivation

WebKitAnimationEvent has been fully replaced by AnimationEvent. The prefixed form is only supported in Safari. Firefox and Edge only support the un-prefixed AnimationEvent.


Interoperability and Compatibility Risk

Hopefully low, when viewed with some careful reasoning :). The UseCounter is high, at ~2.9% of the web. However, I believe most uses are either browser or support detection.


An analysis of HTTP Archive for this feature shows 744 hits for WebKitAnimationEvent appearing in a response body. Breaking them down showed:

  • 215 results (30% of total) from 'blueconic', which is a fingerprinting library.
  • 123 results (~16% of total) from 'celtra', which appears to be advertising library. The code in question fills a translation dict to map 'transitionstart' --> 'webkitAnimationStart'/etc for browsers that only support 'webkitAnimationStart' (so no browsers). Overall behavior will not change from removal, library will just use 'animationstart' instead of 'webkitAnimationStart'/etc.
  • 97 hits (~13% of total) from 'design-toolkit_min' (unknown library). Use of WebKitAnimationEvent appears to be for browser detection, but the check would fail on every browser I know of already: var u = t.WebKitAnimationEvent && !t.WebGLActiveInfo ? true : false;
  • 55 hits (~7%) of total from 'lfm' (unknown library). Used to decide whether to use 'webkitAnimationEnd' or 'animationend', this will continue to work after removal.
  • 36 hits (~5%) of total from 'aw_mobile/navigation.js'. It is not clear what the usage is; there is branching logic which does different things based on whether WebKitAnimationEvent exists, this may break after removal.
  • 30 hits (~4%) of total from 'alicdn.com/ae-ams-ui' (unknown library). Used to decide whether to use 'webkitAnimationEnd' or 'animationend' (but sensibly checks for the unprefixed version first, good web dev!), this will not change after removal.
  • The remaining are split between the following libraries, which have not been closely analyzed: avalon (28 hits), ae-channel-ui-voucher_js (23 hits), rfihub.net (16 hits), unclassified (128 hits).
Taking 5 random samples from unclassified:

$ ls unclassified/ | sort -R | head -n 5
WebKitAnimationEvent.230.txt
WebKitAnimationEvent.218.txt
WebKitAnimationEvent.381.txt
WebKitAnimationEvent.006.txt
WebKitAnimationEvent.528.txt

WebKitAnimationEvent.230.txt - same as aw_mobile/navigation.js logic. Appears to come from a jQTouch library. Looking at the latest version of this library (http://jqtjs.com/preview/src/jqt.js) it still uses this logic and will break (the library also hasn't been changed in 4 years). Library author should change to using the unprefixed events, which both Chrome and Safari support (and means their library would work on e.g. Firefox mobile).

WebKitAnimationEvent.218.txt - checks for animation event support by checking that either of WebKitAnimationEvent or AnimationEvent exist. Unaffected by removal.

WebKitAnimationEvent.381.txt - uses WebKitAnimationEvent to decide whether to prefix '-webkit' to 'animation-name'/etc. After removal will correctly use the unprefixed version.

WebKitAnimationEvent.006.txt - checks for animation event support by checking that either of WebKitAnimationEvent or AnimationEvent (or MSAnimationEvent!) exist. Unaffected by removal.

WebKitAnimationEvent.528.txt - red herring. Has a variable named 'WebKitAnimationEvent' but doesn't use the interface.

Edge: WebKitAnimationEvent is not supported. AnimationEvent is supported.

Firefox: WebKitAnimationEvent is not supported. AnimationEvent is supported.

Safari: WebKitAnimationEvent is supported. AnimationEvent is supported.


Alternative implementation suggestion for web developers

Developers should use the standardized AnimationEvent interface.


Usage information from UseCounter

See Interoperability and Compatibility Risk above.


Entry on the feature dashboard

https://www.chromestatus.com/feature/6027726842494976


Requesting approval to remove too?

Yes; would like to immediately remove for M71 but otherwise M72.

Daniel Bratell

未讀,
2018年9月13日 上午11:29:442018/9/13
收件者:blin...@chromium.org、Stephen Mcgruer
The usage is a bit high. Your analysis did identify a couple of sites that might break or get different behaviour and it's hard to know what usage they represent. There has never (really) been any reason for mobile web developers to not use WebKitAnimationEvent so I think we should at the very least start with a deprecation phase.

With some luck a deprecation phase will make high usage sites (that may have active developers) switch away, hopefully driving the usage down to a level where there is no need to worry.

/Daniel
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADY3MadKRqFxbkGRF_chG8RTYTSajbTp0JnoVxyjPDUUPB32YA%40mail.gmail.com.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

Stephen Mcgruer

未讀,
2018年9月17日 上午9:23:042018/9/17
收件者:bra...@opera.com、blin...@chromium.org
Thanks for the feedback Daniel. I definitely agree there is some risk here, so I would be happy with a deprecation phase if the other API owners agree.

Ping for API owners review.

Philip Jägenstedt

未讀,
2018年9月18日 上午10:29:252018/9/18
收件者:smcg...@chromium.org、Daniel Bratell、blink-dev
Thanks Stephen for the careful analysis.

Two high-level points suggesting low compat risk is that Edge hasn't shipped this, and that 744 total hits in httparchive is not a huge number in a case like this. Given that, the use counter almost certainly doesn't accurately reflect the compat risk, far from it.

With the careful bucketing of results and spot check of the unclassified, it seems like the only case still worth looking at is  'aw_mobile/navigation.js'. Can you get the URLs of the sites in question? (If you used the unjson script they should be at the top of the split files.)

Upon testing those in a real browser, I would not be surprised if the code is unreachable. Or that they are already broken in Edge and Firefox. With either of those outcomes I would still support immediate removal.

(It's not really possible to deprecate this, because window.WebKitAnimationEvent===window.AnimationEvent. Even trying to mark the internal object based on which property was used to access it last wouldn't be robust, and so we'd still fall back to analysis of httparchive.)

PhistucK

未讀,
2018年9月18日 下午1:35:212018/9/18
收件者:Philip Jägenstedt、smcg...@chromium.org、Daniel Bratell、blink-dev
Deprecation warnings for this would generate many false positives due to window enumeration...

aw_mobile/navigation.js has many if ($j.support.WebKitAnimationEvent), so I am not worried about that one.

PhistucK


j.j.

未讀,
2018年9月18日 下午4:55:102018/9/18
收件者:blink-dev、foo...@chromium.org、smcg...@chromium.org、bra...@opera.com


aw_mobile/navigation.js has many if ($j.support.WebKitAnimationEvent), so I am not worried about that one.

... it's a zombie anyways, seems no longer adjunct to any content.
 

Daniel Bratell

未讀,
2018年9月19日 上午11:34:002018/9/19
收件者:Philip Jägenstedt、PhistucK、smcg...@chromium.org、blink-dev
Good argument against deprecation, and the enumeration also explains the high use counter. Then I'm no longer worried about that one.

/Daniel

Stephen Mcgruer

未讀,
2018年9月20日 下午12:56:452018/9/20
收件者:Daniel Bratell、foo...@chromium.org、PhistucK、blink-dev
Phillip - I'm not clear of the status of this I2D, do you still want me to try the investigation you suggested or does phistuck's analysis suffice?

Philip Jägenstedt

未讀,
2018年9月20日 下午1:10:152018/9/20
收件者:smcg...@chromium.org、Daniel Bratell、PhistucK、blink-dev
You said initially that "It is not clear what the usage is; there is branching logic which does different things based on whether WebKitAnimationEvent exists, this may break after removal."

That the branch condition is $j.support.WebKitAnimationEvent is good. It looks like the else branch just doesn't do the animation but skips to the end of it. The script doesn't do anything with "useragent", or use "webkit" in a way that seems like engine sniffing.

Given the small numbers I don't think further analysis or testing is necessary.

LGTM1!

Chris Harrelson

未讀,
2018年9月20日 下午3:52:472018/9/20
收件者:Philip Jägenstedt、smcg...@chromium.org、Daniel Bratell、PhistucK、blink-dev

Daniel Bratell

未讀,
2018年9月21日 上午6:27:462018/9/21
收件者:Philip Jägenstedt、Chris Harrelson、smcg...@chromium.org、PhistucK、blink-dev
回覆所有人
回覆作者
轉寄
0 則新訊息