--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACBGQem%2BV6_UiLktmqwDCSXC3RJaMpmNm%3DSxv%2BH6%3DY4yCk5Msg%40mail.gmail.com.
Hello,
It’s been about 10 days since I shared the Intent to Prototype proposal, and from what I gather, it has been generally well received.
As I’m not entirely familiar with the process, I’d like to suggest the following next steps—unless there are any objections:
Merge the CL
Update the feature status to “Prepare to ship” on ChromeStatus
Begin drafting the Intent to Ship email
Please let me know if you agree with this approach, or if there’s anything else I should address before moving forward.
Thanks!
I agree that it seems like a good idea, and the only concern would be whether it will break things. It sounds like Michal Mocny has been on top of things, but what were his findings?
Once it comes to the shipping decision, the more you can say about interoperability and compatibility, the better.
For compatibility between browsers, are there bug issues in the Mozilla and WebKit databases already? If not, it would be great if you could file some so that they end up making the same fix.
/Daniel
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/15ac55eb-46bc-44d4-b50b-517d21fb27een%40chromium.org.
Thanks, I completely agree, the more we can highlight interoperability and cross-browser compatibility, the better, especially as we move toward the Intent to Ship stage.
My plan is to go step by step: first land the fix, then progressively enable the flag, assuming that’s aligned with how we usually handle this in the Blink Intent process (this is my first time going through it, so I really appreciate the guidance).
Regarding compatibility bugs for Mozilla and WebKit, I can take a look at filing those after I return from vacation (I’ll be off for the next 3 weeks starting today). I’m not entirely sure how to approach that part, so any help on that front would be appreciated.
Excited to hear your thoughts, Michal Mocny.
/Ane
Hello,
I’ve addressed the comments on my review. As mentioned in one of them, I’ve had some difficulties running tests locally due to issues with my machine.
I think it would be best to run try jobs to identify any remaining modifications needed before the CL can be merged. Could you please run them for me, since I don’t have the rights to do so?
Thanks again for your help!
Hi everyone,
I recently merged the patch for Layout Instability Attribution in CSS Pixels (merged on Oct 8) and would now like to begin the first “Intent to Ship” step, testing the feature locally.
I’ve installed Chrome Dev 143.x, where the patch should already be included (confirmed via the “Included in” tags on Gerrit). However, I’m currently unable to find the new flag I added — ReportLayoutShiftRectsInCssPixels — under chrome://flags. This flag is required to test the expected behavior locally.
Could anyone advise on how to proceed?
Do I need to enable a specific runtime flag or Finch experiment to activate the feature?
Is there a build configuration or command-line flag I should use to ensure the patch is active for local testing?
Are there additional steps I should take before starting the “Intent to Ship” verification phase?
Any guidance or pointers would be greatly appreciated.
Thanks,
Ane
Hi everyone,
I recently merged the patch for Layout Instability Attribution in CSS Pixels (merged on Oct 8) and would now like to begin the first “Intent to Ship” step, testing the feature locally.
I’ve installed Chrome Dev 143.x, where the patch should already be included (confirmed via the “Included in” tags on Gerrit). However, I’m currently unable to find the new flag I added — ReportLayoutShiftRectsInCssPixels — under chrome://flags. This flag is required to test the expected behavior locally.
Could anyone advise on how to proceed?
Do I need to enable a specific runtime flag or Finch experiment to activate the feature?
Is there a build configuration or command-line flag I should use to ensure the patch is active for local testing?
Are there additional steps I should take before starting the “Intent to Ship” verification phase?