Intent to Ship: text-decoration-thickness, text-underline-offset and from-font keyword for text-underline-position

[Dominik Röttsches]

Contact emails

dr...@chromium.org

sche...@chromium.org

Specification

https://drafts.csswg.org/css-text-decor-4/#text-underline-position-property

Summary

Implement CSS text decoration properties text-decoration-thickness and text-underline-offset. Add support for the new from-font keyword for text-underline-position. When from-font keywords are used, support variable font MVAR underline scaling (the tags `unds` and `undo` in the OpenType MVAR table override underlinePosition and underlineThickness in the OpenType `post` table).

Blink component

Blink>Fonts

Blink>Paint

Blink>CSS

TAG review

Text-decoration spec already established, feature shipping in other browsers.

Risks

Interoperability and Compatibility

Low, as already shipped in two other engines and already covered by existing WPT tests.

Gecko: Shipped/Shipping (https://bugzilla.mozilla.org/show_bug.cgi?id=1440014)

WebKit: Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=190774)

Web developers: Positive (https://twitter.com/jensimmons/status/1196420764360200198) Feedback received after ink-skipping, 25 ⭐️ on Chrome bug - 123 likes on video explaining the underlining styling features in FireFox.

Debuggability

Usual pathway for debugging CSS properties.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes

Is this feature fully tested by web-platform-tests?

Yes

Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=785230

Link to entry on the Chrome Platform Status

https://www.chromestatus.com/feature/5747636764147712

Link to previous intent-to-prototype thread
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/D6S8JRPYtDA/yZ7fYcQUBQAJ

[Chris Harrelson]

LGTM1

I agree that a TAG review is not required in this case because we are shipping a standardized feature already shipped

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN6muBvh9YvkT3vY1PqC_mnt%2BVArR2_ZP1-%2BXPoWXFhcLK%3Dotw%40mail.gmail.com.

[Manuel Rego Casasnovas]

Hi,

On 24/09/2020 16:10, Dominik Röttsches wrote:
> Is this feature fully tested by web-platform-tests

> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
>
> Yes

Is it the wpt.fyi information updated? I guess it'd be nice to fix the
parsing differences with Firefox:
https://wpt.fyi/results/css/css-text-decor/parsing?label=master&label=experimental&aligned&q=underline-position

> Tracking bug
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=785230

The bug is blocked in a few other issues, I haven't checked them so I
don't know they're important. But we shouldn't ship this without fixing
https://crbug.com/896295 first.

I believe that's the actual plan, as the implementation have been
waiting for that fix for a while. But just to verify.

Bye,
Rego

[Dominik Röttsches]

Hi Rego,

thanks for the quick response and feedback.

On Thu, Sep 24, 2020 at 7:04 PM Manuel Rego Casasnovas <re...@igalia.com> wrote:

Hi,

On 24/09/2020 16:10, Dominik Röttsches wrote:
>         Is this feature fully tested by web-platform-tests
>         <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
>
> Yes

Is it the wpt.fyi information updated? I guess it'd be nice to fix the
parsing differences with Firefox:
https://wpt.fyi/results/css/css-text-decor/parsing?label=master&label=experimental&aligned&q=underline-position

Thanks for pointing these out. I'll do another pass on this folder and see what the flag state for the wpt.fyi bot run is. I see two differences related to from-font compared to FF.

>         Tracking bug
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=785230

The bug is blocked in a few other issues, I haven't checked them so I
don't know they're important.

I was able to close two of them as they had already been fixed in the process. For the remaining two:

a) crbug.com/1093826 is a spec clarification on what computed values should be returned for the text-decoration shorthand, which is an existing issue we have with other shorthands as well (according to discussion with Anders), and I don't think it needs to block shipping. 

 

But we shouldn't ship this without fixing
https://crbug.com/896295 first.

I believe that's the actual plan, as the implementation have been
waiting for that fix for a while. But just to verify.

 

b) This one does need to be fixed before shipping and Stephen's fix for this one is for review here:

https://chromium-review.googlesource.com/c/chromium/src/+/2422356

Dominik

 

[Daniel Bratell]

LGTM2  -  since the issues Rego pointed out will be handled by the time it's released.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN6muBvzvnTuJCHxbit5sK-1gCgcfXKTidg9w3d4C%2BaAtO2UXw%40mail.gmail.com.

[Manuel Rego Casasnovas]

Thanks for the quick reply Dominik.

LGTM3 to ship once those issues are fixed.

>> a) crbug.com/1093826 <https://crbug.com/1093826> is a spec

>> clarification on what computed values should be returned for the
>> text-decoration shorthand, which is an existing issue we have with
>> other shorthands as well (according to discussion with Anders), and I
>> don't think it needs to block shipping. 
>>  
>>
>> But we shouldn't ship this without fixing
>> https://crbug.com/896295 first.
>>
>> I believe that's the actual plan, as the implementation have been
>> waiting for that fix for a while. But just to verify.
>>
>>  
>> b) This one does need to be fixed before shipping and Stephen's fix
>> for this one is for review here:
>> https://chromium-review.googlesource.com/c/chromium/src/+/2422356
>>
>> Dominik
>>
>>  
>> --
>> You received this message because you are subscribed to the Google
>> Groups "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send
>> an email to blink-dev+...@chromium.org

>> <mailto:blink-dev+...@chromium.org>.

>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN6muBvzvnTuJCHxbit5sK-1gCgcfXKTidg9w3d4C%2BaAtO2UXw%40mail.gmail.com

>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN6muBvzvnTuJCHxbit5sK-1gCgcfXKTidg9w3d4C%2BaAtO2UXw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org

> <mailto:blink-dev+...@chromium.org>.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/94b83915-615e-e053-5997-3052d8a345a1%40gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/94b83915-615e-e053-5997-3052d8a345a1%40gmail.com?utm_medium=email&utm_source=footer>.

[fri...@jeka.info]

https://www.chromestatus.com/feature/5747636764147712

says this shipped with Chrome 87 but text-decoration-thickness doesn`t work for me ...

[Stephen Chenney]

You're probably seeing https://bugs.chromium.org/p/chromium/issues/detail?id=1154537, fixed in Chrome 89 coming to Stable any day now.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/df062ce9-6536-496f-8e0c-51991ebe14ben%40chromium.org.