Intent to Implement and Ship: Remove FileSystemWritableFileStream::close() implementation

Skip to first unread message

Austin Sullivan

Jan 19, 2021, 2:19:42 PM1/19/21

Contact emails





This just overrides the (identical behaving) implementation from the base WritableStream class. Remove it from FileSystemWritableFileStream. WritableStream didn't used to have a close() method, as such FileSystemWritableFileStream implemented its own. Later WritableStream added one, but we forgot to remove the implementation of the override before shipping the API. This fixes that inconsistency between the spec and implementation.

Blink component


TAG review

TAG review status

This change makes the implementation align with the spec which was TAG reviewed for the File System Access API.


Interoperability and Compatibility

This change should be harmless. The current implementation just overrides the (identical behaving) implementation from the base WritableStream class. We'll now be using the base WritableStream class's close() method directly.

Gecko: No signal

Edge: No signal

WebKit: No signal

Web developers: No signals

Is this feature fully tested by web-platform-tests?


Tracking bug

Link to entry on the Chrome Platform Status

This intent message was generated by Chrome Platform Status.

Domenic Denicola

Jan 19, 2021, 2:24:19 PM1/19/21
to Austin Sullivan,
In case it helps the API owners, this change is technically web-exposed, but very subtle and hard to notice. Code would have to be doing something like:

// true before this change; false after

FileSystemWritableFileStream.prototype.close === WritableStream.prototype.close
// false before this change; true after
// throws before this change; works afterward

(Maybe this could have been a bugfix PSA instead of an Intent to Ship, but erring on the side of getting approval never hurts IMO.)

Mike West

Jan 21, 2021, 8:31:22 AM1/21/21
to Domenic Denicola, Austin Sullivan,
I agree with Domenic that this is minor enough to have warranted a PSA (or, really, just landing a bugfix CL). But, since you asked, LGTM1! :)


You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
To view this discussion on the web visit

Yoav Weiss

Jan 21, 2021, 8:56:47 AM1/21/21
to Mike West, Domenic Denicola, Austin Sullivan,
I was the one asking for the intent here, as it wasn't immediately clear to me from the CL that this is safe to remove.
Given the explanations, LGTM2 :)

Chris Harrelson

Jan 21, 2021, 11:24:25 AM1/21/21
to Yoav Weiss, Mike West, Domenic Denicola, Austin Sullivan,
Reply all
Reply to author
0 new messages