Intent to Ship: Array.fromAsync

146 views
Skip to first unread message

Rezvan Mahdavi Hezaveh

unread,
Oct 25, 2023, 6:44:48 PM10/25/23
to blin...@chromium.org

Contact emails

s...@chromium.orgrez...@chromium.org

Explainer

https://github.com/tc39/proposal-array-from-async

Specification

https://tc39.es/proposal-array-from-async

Summary

Array.fromAsync is the async version of Array.from. It takes async iterables, iterates them, and collects the results into an array.



Blink component

Blink>JavaScript>Language

TAG review

None

TAG review status

Not applicable

Risks



Interoperability and Compatibility

No known interop or web compat risk.



Gecko: Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1746209) This is a TC39 Stage 3 proposal.

WebKit: Positive This is a TC39 Stage 3 proposal.

Web developers: Positive (https://twitter.com/erickwendel_/status/1555206623836127232) Seems positive, lots of likes on Twitter.

Other signals:

WebView application risks

Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?

None



Debuggability

It is debugged as any other static method in JavaScript.



Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes

Is this feature fully tested by web-platform-tests?

Yes

https://github.com/tc39/test262/issues/3725



Flag name on chrome://flags

--harmony_array_from_async

Finch feature name

None

Non-finch justification

None

Requires code in //chrome?

False

Tracking bug

https://bugs.chromium.org/p/v8/issues/detail?id=13321

Estimated milestones

DevTrial on desktop120
DevTrial on Android120


Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

None

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5069575759069184

This intent message was generated by Chrome Platform Status.

Mike Taylor

unread,
Oct 25, 2023, 6:57:08 PM10/25/23
to Rezvan Mahdavi Hezaveh, blink-dev

LGTM1. It's encouraging that Firefox Nightly shipped this a few months back with no reported regressions thus far.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACJ3t%2Bg4MwKGhiGJg%2B0WdgJXTD0rGJ22ZFGAF8bnOtGoLhszzA%40mail.gmail.com.

Mike Taylor

unread,
Oct 25, 2023, 7:00:15 PM10/25/23
to Rezvan Mahdavi Hezaveh, blink-dev

Oops... sent too early. Can you also please request reviews for the rest of the review gates in the chromestatus entry?

Shu-yu Guo

unread,
Oct 25, 2023, 8:05:55 PM10/25/23
to Mike Taylor, Rezvan Mahdavi Hezaveh, blink-dev
Those gates are not applicable for most TC39 stage 3 features, including this one. Are you asking them to be marked as such or that we requested reviews for it?

Mike Taylor

unread,
Oct 25, 2023, 8:16:03 PM10/25/23
to Shu-yu Guo, Johnny Stenback, Rezvan Mahdavi Hezaveh, blink-dev

Sorry, we're still learning this new chromestatus process (and a similar concern came up in our API OWNERs meeting earlier today). My understanding is that we should have _something_ in there, so perhaps the right thing to do is to request the reviews stating that these are normally N/A for TC39 stage 3 features since we don't have a way for feature owners to mark something as N/A.

Johnny, does that sound right to you?

Yoav Weiss

unread,
Oct 26, 2023, 1:57:40 AM10/26/23
to Mike Taylor, Shu-yu Guo, Johnny Stenback, Rezvan Mahdavi Hezaveh, blink-dev
LGTM2 % administrative shenanigans regarding the review gates

Chris Harrelson

unread,
Oct 26, 2023, 11:21:22 AM10/26/23
to Shu-yu Guo, Mike Taylor, Rezvan Mahdavi Hezaveh, blink-dev
On Wed, Oct 25, 2023 at 5:05 PM Shu-yu Guo <s...@chromium.org> wrote:
Those gates are not applicable for most TC39 stage 3 features, including this one. Are you asking them to be marked as such or that we requested reviews for it?

I think they are. TC39 stage 3 features can skip a TAG review and signals, but the other fields are still required.
 

Johnny Stenback

unread,
Oct 26, 2023, 7:04:36 PM10/26/23
to Chris Harrelson, Shu-yu Guo, Mike Taylor, Rezvan Mahdavi Hezaveh, blink-dev
+1 to what Chris said. And if you feel a gate doesn't apply, you can state in a comment that you believe the result of the review should be n/a. And we're in fact in the midst of landing a short-hand button that does that for all approval gate chips.

Cheers,
Johnny

Chris Harrelson

unread,
Oct 27, 2023, 5:17:52 PM10/27/23
to Johnny Stenback, Shu-yu Guo, Mike Taylor, Rezvan Mahdavi Hezaveh, blink-dev
Reply all
Reply to author
Forward
0 new messages