Manuel Rego Casasnovas
unread,Apr 8, 2021, 8:11:28 AM4/8/21Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Sign in to report message as abuse
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Yoav Weiss, blink-dev, Frank Tang, Shu-yu Guo, Mathias Bynens, Adam Klein
LGTM2
On 08/04/2021 11:10, Yoav Weiss wrote:
> *LGTM1*
>
> On Wednesday, April 7, 2021 at 7:21:19 PM UTC+2 Frank Tang wrote:
>
> (Aiming to ship at m92. Notice this is just implement a small PR in
> ECMA402)
>
>
>
> Contact emails
>
>
ft...@chromium.org <mailto:
ft...@chromium.org>,
js...@chromium.org
> <mailto:
js...@chromium.org>
>
>
> Explainer
>
>
>
https://docs.google.com/document/d/10l10gpw5hBdZ1OuYVqZPU72-61yyOaTUQllIVRyQoFM/edit#
> <
https://docs.google.com/document/d/10l10gpw5hBdZ1OuYVqZPU72-61yyOaTUQllIVRyQoFM/edit#>
>
>
> Specification
>
>
https://github.com/tc39/ecma402/pull/346
> <
https://github.com/tc39/ecma402/pull/346>
>
>
> API spec
>
> Yes
>
>
> Design docs
>
>
>
https://github.com/tc39/ecma402/pull/346
> <
https://github.com/tc39/ecma402/pull/346>
>
>
> Summary
>
> Add a dayPeriod option to Intl.DateTimeFormat() method so the caller
> can format times such as "7 in the morning", "11 in the morning",
> "12 noon", "1 in the afternoon", "6 in the evening", "10 at night"
> (or in Chinese, "清晨7時", "上午11時", "中午12時", "下午1時" ,"下午6
> 時" ,"晚上10時")
>
>
>
> Blink component
>
> Blink>JavaScript>Internationalization
> <
https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3EInternationalization>
>
>
> Search tags
>
> Intl <
https://chromestatus.com/features#tags:Intl>, datetimeformat
> <
https://chromestatus.com/features#tags:datetimeformat>
>
>
> TAG review
>
> No TAG review needed since it is part of TC39 ECMA402 and already
> part of ECMA402 2021 edition
>
>
> TAG review status
>
> Pending
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
> low.
>
>
>
> Gecko: In development
> (
https://bugzilla.mozilla.org/show_bug.cgi?id=1645115
> <
https://bugzilla.mozilla.org/show_bug.cgi?id=1645115>)
>
>
> I don't know if this is accurate, as the bug seems dormant. At the same
> time, IIRC we've been told that stage3+ TC39 proposals require no
> further position.
>
>
> WebKit: In development
> (
https://trac.webkit.org/changeset/267454/webkit
> <
https://trac.webkit.org/changeset/267454/webkit>)
> <
https://stackoverflow.com/questions/66326186/reference-for-dayperiod-in-intl-datetimeformat>)
>
>
> That just seems like an indication that the feature needs better
> documentation.
>
>
>
> Ergonomics
>
> No increase of data. All required data already build into ICU.
>
>
>
> Activation
>
> Low. This is just adding additional acceptable value for a
> pre-existing API and expose no additional methods.
>
>
>
> Security
>
> Low. This is just adding additional acceptable value for a
> pre-existing API and expose no additional methods.
>
>
>
> Debuggability
>
> Good- resolveOptions would help developer to find out what happen
> during debugging.
>
>
>
> Is this feature fully tested by web-platform-tests
> <
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
> <
https://www.chromestatus.com/>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to
blink-dev+...@chromium.org
> <mailto:
blink-dev+...@chromium.org>.
> To view this discussion on the web visit
>
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a451fcb2-0d2f-4dbd-8e4b-50d8bd23fe7en%40chromium.org
> <
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a451fcb2-0d2f-4dbd-8e4b-50d8bd23fe7en%40chromium.org?utm_medium=email&utm_source=footer>.