Intent to Deprecate and Remove: remove HTMLFrameSetElement’s anonymous getter

126 views
Skip to first unread message

Hwanseung Lee

unread,
May 22, 2018, 8:01:52 AM5/22/18
to blink-dev

Primary eng (and PM) emails

hs121...@samsung.com


Summary

remove HTMLFrameSetElement’s anonymous getter which is non-standard.


Motivation

This non-standard getter was added 13 years ago to fix a compatibility issue

at the time: https://trac.webkit.org/changeset/8717/webkit

but it is not non-standard and nowadays it seems not used.


Interoperability and Compatibility Risk

very low. because this feature is not standard.

it is just legacy code from old webkit.

so webkit and blink have only supported it.


Edge: not supported

Firefox: not supported

Safari: Supported


Alternative implementation suggestion for web developers

this is non-standard. so we don’t need to provide an alternative.


Usage information from UseCounter

https://www.chromestatus.com/metrics/feature/timeline/popularity/2235

we are tracking this when it return non-null value. it is about 0.0001%


Entry on the feature dashboard

https://www.chromestatus.com/feature/5235521668251648


Requesting approval to remove too?

Yes. i would like to show a deprecation message before remove it.

could you recommend schedule how long show the message?


Philip Jägenstedt

unread,
May 22, 2018, 10:23:28 AM5/22/18
to HwanSeung Lee, blink-dev
LGTM1.

The code for this is here:

This is implemented entirely in terms of web-exposed APIs and after some experimenting I think this is the simplest equivalent JS:
function getFrameByName(frameset, name) {
    try {
        return frameset.children.namedItem(name).contentDocument.defaultView;
    } catch (e) {
        return null;
    }
}

Regarding the deprecation period, let's say just a single cycle, given how rarely used this is.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/37909221-3679-4395-9c7b-6408a8317581%40chromium.org.

Daniel Bratell

unread,
May 22, 2018, 11:21:54 AM5/22/18
to HwanSeung Lee, 'Philip Jägenstedt' via blink-dev, Philip Jägenstedt
LGTM2

/Daniel
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYepAMBq92%2BDRFix12O1199WF52qX651vSQMpmq%2B%2BwnfAw%40mail.gmail.com.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */

mk...@chromium.org

unread,
May 23, 2018, 2:12:52 AM5/23/18
to blink-dev, hs121...@samsung.com, foo...@google.com
LGTM3.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
Reply all
Reply to author
Forward
0 new messages