Intent to Ship: RegExp v flag with set notation + properties of strings

124 views

Skip to first unread message

Patrick Thier

unread,

Jan 25, 2023, 10:52:44 AM1/25/23

to blin...@chromium.org

Summary

Add set operations, string literals, nested classes and unicode properties of strings to regular expression character classes. Set operations and unicode properties of strings allow developers to create regular expressions matching strings with certain unicode characters with ease. E.g. /[\p{Script_Extensions=Greek}&&\p{Letter}]/v matches all greek letters.

Blink component

Blink>JavaScript>Regexp

TAG review

TAG review status

Not applicable

Risks

Interoperability and Compatibility

Covered by TC39 process: https://github.com/tc39/proposal-regexp-v-flag

Gecko: Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1713657) Assumed positive because this proposal is Stage 3 in TC39.

WebKit: Positive (https://bugs.webkit.org/show_bug.cgi?id=241593) Assumed positive because this proposal is Stage 3 in TC39.

Web developers: No signals

Other signals:

Activation

The new features are gated behind a new regular expression flag (/v). See https://github.com/tc39/proposal-regexp-v-flag#is-the-new-syntax-backwards-compatible-do-we-need-another-regular-expression-flag

WebView application risks

Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?

Debuggability

Uses existing debugging support for regular expressions. No additions required.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes

The feature is enabled for all platforms when compiled with internalization support.

Is this feature fully tested by web-platform-tests?

Covered by test262: https://github.com/tc39/test262/tree/main/test/built-ins/RegExp/unicodeSets/generated

Flag name

--harmony-regexp-unicode-sets

Requires code in //chrome?

False

Non-OSS dependencies

Does the feature depend on any code or APIs outside the Chromium open source repository and its open-source dependencies to function?

Sample links

https://v8.dev/features/regexp-v-flag

Estimated milestones

DevTrial on desktop

110

DevTrial on Android

110

Planned to ship in M112

Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5144156542861312

This intent message was generated by Chrome Platform Status.

Chris Harrelson

unread,

Jan 25, 2023, 11:55:55 AM1/25/23

to Patrick Thier, blin...@chromium.org

LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKhjTa_NMAR5FF5zkWDa0msVJk3gHA%3DgnzMndyv-_atBNr%3DQnQ%40mail.gmail.com.

Yoav Weiss

unread,

Jan 26, 2023, 4:13:32 AM1/26/23

to Chris Harrelson, Patrick Thier, blin...@chromium.org

LGTM2

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9MP-QiDWt5wHO6KsTWrZ1vy_NUcNZz-Nb%3DviKdnV%3D-TQ%40mail.gmail.com.

Manuel Rego Casasnovas

unread,

Jan 26, 2023, 7:33:49 AM1/26/23

to Yoav Weiss, Chris Harrelson, Patrick Thier, blin...@chromium.org

LGTM3

On 26/01/2023 10:12, Yoav Weiss wrote:
> LGTM2
>
> On Wed, Jan 25, 2023 at 5:55 PM Chris Harrelson <chri...@chromium.org
> <mailto:chri...@chromium.org>> wrote:
>
> LGTM1
>
> On Wed, Jan 25, 2023 at 7:52 AM 'Patrick Thier' via blink-dev

> <blin...@chromium.org <mailto:blin...@chromium.org>> wrote:
>
>
> Contact emails
>
> pth...@chromium.org
> <mailto:pth...@chromium.org>, mat...@chromium.org
> <mailto:mat...@chromium.org>
>
>
> Explainer
>
> https://github.com/tc39/proposal-regexp-v-flag
> <https://github.com/tc39/proposal-regexp-v-flag>
> https://v8.dev/features/regexp-v-flag

> <https://v8.dev/features/regexp-v-flag>
>
>
> Specification
>
> https://github.com/tc39/proposal-regexp-v-flag
> <https://github.com/tc39/proposal-regexp-v-flag>
>
>
> Summary
>
> Add set operations, string literals, nested classes and unicode
> properties of strings to regular expression character classes.
> Set operations and unicode properties of strings allow
> developers to create regular expressions matching strings with
> certain unicode characters with ease. E.g.
> /[\p{Script_Extensions=Greek}&&\p{Letter}]/v matches all greek
> letters.
>
>
>
> Blink component
>
> Blink>JavaScript>Regexp

> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3ERegexp>

>
>
> TAG review
>
>
>
> TAG review status
>
> Not applicable
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
> Covered by TC39 process:
> https://github.com/tc39/proposal-regexp-v-flag

> <https://github.com/tc39/proposal-regexp-v-flag>
>
>
>
> /Gecko/: Positive
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1713657
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1713657>) Assumed

> positive because this proposal is Stage 3 in TC39.
>

> /WebKit/: Positive
> (https://bugs.webkit.org/show_bug.cgi?id=241593
> <https://bugs.webkit.org/show_bug.cgi?id=241593>) Assumed

> positive because this proposal is Stage 3 in TC39.
>

> /Web developers/: No signals
>
> /Other signals/:

>
>
> Activation
>
> The new features are gated behind a new regular expression flag
> (/v). See

> https://github.com/tc39/proposal-regexp-v-flag#is-the-new-syntax-backwards-compatible-do-we-need-another-regular-expression-flag <https://github.com/tc39/proposal-regexp-v-flag#is-the-new-syntax-backwards-compatible-do-we-need-another-regular-expression-flag>

>
>
>
> WebView application risks
>
> Does this intent deprecate or change behavior of existing APIs,
> such that it has potentially high risk for Android WebView-based
> applications?
>
>
>
> Debuggability
>
> Uses existing debugging support for regular expressions. No
> additions required.
>
>
>
> Will this feature be supported on all six Blink
> platforms (Windows, Mac, Linux, Chrome OS, Android, and
> Android WebView)?
>
> Yes
>
> The feature is enabled for all platforms when compiled with
> internalization support.
>
>
>
> Is this feature fully tested by web-platform-tests

> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?
>
> Covered by test262:
> https://github.com/tc39/test262/tree/main/test/built-ins/RegExp/unicodeSets/generated <https://github.com/tc39/test262/tree/main/test/built-ins/RegExp/unicodeSets/generated>

> <https://chromestatus.com/>.

>
> --
> You received this message because you are subscribed to the
> Google Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to blink-dev+...@chromium.org

> <mailto:blink-dev+...@chromium.org>.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKhjTa_NMAR5FF5zkWDa0msVJk3gHA%3DgnzMndyv-_atBNr%3DQnQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKhjTa_NMAR5FF5zkWDa0msVJk3gHA%3DgnzMndyv-_atBNr%3DQnQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org

> <mailto:blink-dev+...@chromium.org>.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9MP-QiDWt5wHO6KsTWrZ1vy_NUcNZz-Nb%3DviKdnV%3D-TQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9MP-QiDWt5wHO6KsTWrZ1vy_NUcNZz-Nb%3DviKdnV%3D-TQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org

> <mailto:blink-dev+...@chromium.org>.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfWzQv_JzMkvMTGf%3DwUDqXfADWZOgezLtG2tzr53syYE0A%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfWzQv_JzMkvMTGf%3DwUDqXfADWZOgezLtG2tzr53syYE0A%40mail.gmail.com?utm_medium=email&utm_source=footer>.

Reply all

Reply to author

Forward

0 new messages