Intent to Remove: InstallEvent Interface

54 views
Skip to first unread message

Paritosh

unread,
Apr 6, 2015, 7:47:26 AM4/6/15
to blin...@chromium.org

 

Primary eng (and PM) emails

parit...@samsung.com

 

Link to “Intent to Deprecate” thread

Never used from Script

 

Summary

Removing InstallEvent Interface from ServiceWorker, as this get removed in https://github.com/slightlyoff/ServiceWorker/commit/4d172287dc5f92530ac251f68a670f5f4de9540c

 

Motivation

https://github.com/slightlyoff/ServiceWorker/issues/661

http://code.google.com/p/chromium/issues/detail?id=470032

 

Alternative

We can use Extendable interface for install events.

 

Compatibility Risk

Low. As Never used from script.

Paritosh

TAMURA, Kent

unread,
Apr 7, 2015, 3:23:13 AM4/7/15
to Paritosh, blink-dev
> Never used from Script

I'm confused.  Do you mean InstallEvent interface haven't shipped?

--
TAMURA Kent
Software Engineer, Google


Matt Falkenhagen

unread,
Apr 7, 2015, 3:58:52 AM4/7/15
to TAMURA, Kent, Paritosh, blink-dev
It has shipped and can be used in script as "new InstallEvent()" or "event instanceof InstallEvent".

But most likely, no one does this. The install event is a special lifetime event dispatched to the Service Worker so it can do initialization before receiving functional events. Dispatching yourself an install event wouldn't make sense, and there's no reason outside of tests to do instanceof InstallEvent. So it's should be safe to make this change.

TAMURA, Kent

unread,
Apr 7, 2015, 4:13:38 AM4/7/15
to Matt Falkenhagen, Paritosh, blink-dev
So, in summary,
- The interface will be changed for 'install' event: InstallEvent -> ExtendableEvent, which was a parent interface of InstallEvent
- InstallEvent::activeWorker will be removed

Is this right?

Matt Falkenhagen

unread,
Apr 7, 2015, 4:33:52 AM4/7/15
to TAMURA, Kent, Paritosh, blink-dev
(reply all this time) 
Correct, but we never shipped InstallEvent::activeWorker.

TAMURA, Kent

unread,
Apr 7, 2015, 4:36:51 AM4/7/15
to Matt Falkenhagen, Paritosh, blink-dev
Thanks.  I finally understand the compatibility risk is very low.  LGTM.

Dimitri Glazkov

unread,
Apr 7, 2015, 10:56:55 AM4/7/15
to TAMURA, Kent, Matt Falkenhagen, Paritosh, blink-dev
LGTM2

Chris Harrelson

unread,
Apr 7, 2015, 11:53:43 AM4/7/15
to Dimitri Glazkov, TAMURA, Kent, Matt Falkenhagen, Paritosh, blink-dev
LGTM

LGTM2
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Reply all
Reply to author
Forward
0 new messages