Possible to remove WebGLRenderingContextBase::commit()?

[Colin Blundell]

Hi +Chris Harrelson and blink-dev@,

+Vasiliy Telezhnikov and I discovered that WebGLRenderingContextBase::commit() appears to implement an abandoned web API (it's under an experimental runtime flag that was added years ago). However, we're not web platform experts. Could anyone say definitively whether it's safe to remove this code?

Thanks,

Colin

[Dave Tapuska]

Features behind experimental web platform flags are considered experimental and can be removed. There doesn't appear to be a field trial for this either. So I believe it is fine to remove. My guess is that it should have been removed when the 2d version was removed. See https://source.chromium.org/chromium/chromium/src/+/6905991000c1950addd7b980604d453b5bcf26a7

dave.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NGBDXAsBodEhNEi_15FOWc%2BTEU6a0%3DiBw_XiDaUmC-z6g%40mail.gmail.com.

[Colin Blundell]

On Thu, Jun 26, 2025 at 3:53 PM Dave Tapuska <dtap...@chromium.org> wrote:

Features behind experimental web platform flags are considered experimental and can be removed. There doesn't appear to be a field trial for this either. So I believe it is fine to remove. My guess is that it should have been removed when the 2d version was removed. See https://source.chromium.org/chromium/chromium/src/+/6905991000c1950addd7b980604d453b5bcf26a7

Thanks for that pointer! In particular, am I reading correctly that this PR covered the WebGL context?

[Dave Tapuska]

I'd leave that to Domenic to comment (since they reviewed the PR) :-)

[Domenic Denicola]

That PR did not cover WebGLRenderingContext; it only modified OffscreenCanvasRenderingContext2D.

The WebGLRenderingContextBase interface seems to be specified in https://registry.khronos.org/webgl/specs/latest/1.0/#5.14 . I can't find the word "commit" in that spec using find-in-page, at least.

[Chris Harrelson]

The commit method was part of the original OffscreenCanvas design, and based on feedback it was removed (lots of discussion in this thread). It's safe to remove this method and the flag.

[Colin Blundell]

Great, thank you!