Intent to Ship: PointerEvent.deviceId for Mult-Pen Inking

瀏覽次數:1,074 次
跳到第一則未讀訊息

Sahir Vellani

未讀,
2023年10月4日 晚上7:44:052023/10/4
收件者:Abridged recipients、Olga Gerchikov、Alex Russell

Contact emails

Explainer

Specification

Summary

As devices with advanced pen input capabilities are becoming increasingly prevalent, it is important that the web platform continues to evolve to fully support these advanced features in order to unlock rich experiences for both end users and developers. One such advancement is the ability for a device's digitizer to recognize more than one pen device interacting with it simultaneously. This feature is an extension to the PointerEvent interface to include a new attribute, deviceId, that represents a session-persistent, document isolated, unique identifier that a developer can reliably use to identify individual pens interacting with the page.



Blink component

TAG review

TAG review status

Pending. TAG review has been pending for 2 months.

Risks



Interoperability and Compatibility



Gecko: No signal (https://github.com/mozilla/standards-positions/issues/715)

WebKit: No signal (https://github.com/WebKit/standards-positions/issues/102)

Web developers: No signals

Other signals:

WebView application risks

Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?

None



Debuggability



Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

No

Is this feature fully tested by web-platform-tests?

No. However, there are web tests in Chromium that test PointerEventInit with this feature.

Flag name on chrome://flags

PointerEventDeviceId

Finch feature name



Non-finch justification

Edge origin trials successfully underway.

Requires code in //chrome?

False

Measurement

PointerEventDeviceId use counter implemented.

Availability expectation

Initially available on Chromium browsers on Windows.

Adoption expectation

Feature is used by specific partner(s) to provide functionality immediately upon launch.

Adoption plan

This feature has been through origin trials on Edge. It is being used by partners that provide features on devices with multi pen support.

Non-OSS dependencies

Does the feature depend on any code or APIs outside the Chromium open source repository and its open-source dependencies to function?

Operating system API's are used to obtain the device id, and are necessary for this feature to function. Please see the security questionnaire in the TAG review on security and privacy concerns related to the use of these APIs.

Estimated milestones

Shipping on desktop
120


Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

WICG Proposal: https://github.com/WICG/proposals/issues/101 No web compat/interop risk.

Link to entry on the Chrome Platform Status

Links to previous Intent discussions

This intent message was generated by Chrome Platform Status.

Mike Taylor

未讀,
2023年10月6日 中午12:03:352023/10/6
收件者:Sahir Vellani、Abridged recipients、Olga Gerchikov、Alex Russell
Any Origin Trial feedback you can share?


Requires code in //chrome?

False

Measurement

PointerEventDeviceId use counter implemented.

Availability expectation

Initially available on Chromium browsers on Windows.
Out of curiosity, are there limitations on other platforms that prevent supporting this feature?

Adoption expectation

Feature is used by specific partner(s) to provide functionality immediately upon launch.

Adoption plan

This feature has been through origin trials on Edge. It is being used by partners that provide features on devices with multi pen support.

Non-OSS dependencies

Does the feature depend on any code or APIs outside the Chromium open source repository and its open-source dependencies to function?

Operating system API's are used to obtain the device id, and are necessary for this feature to function. Please see the security questionnaire in the TAG review on security and privacy concerns related to the use of these APIs.

Estimated milestones

Shipping on desktop
120


Anticipated spec changes

Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).

WICG Proposal: https://github.com/WICG/proposals/issues/101 No web compat/interop risk.

Link to entry on the Chrome Platform Status

Links to previous Intent discussions

This intent message was generated by Chrome Platform Status.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/PH0PR00MB1349B7917876E7AC505E790AFBCBA%40PH0PR00MB1349.namprd00.prod.outlook.com.

Sahir Vellani

未讀,
2023年10月6日 下午2:10:302023/10/6
收件者:blink-dev、mike...@chromium.org、gerc...@microsoft.com、Alex Russell、Sahir Vellani
Absolutely, the feature has been working well. Our partners (Microsoft Whiteboard) have enabled the feature that is dependent on this API for their general audience! We did not receive any constructive feedback. This API is being used by them on Microsoft Surface Hub devices, which support multi-pen inking.

Requires code in //chrome?
False

Measurement
PointerEventDeviceId use counter implemented.

Availability expectation
Initially available on Chromium browsers on Windows.
Out of curiosity, are there limitations on other platforms that prevent supporting this feature?

We haven't been able to get our hands on hardware that supports other platforms in addition to multi pen inking in order to implement and appropriately test this feature. We welcome any sponsors for implementing and testing this, especially on Linux/Android.

Daniel Bratell

未讀,
2023年10月11日 清晨7:59:152023/10/11
收件者:Sahir Vellani、blink-dev、mike...@chromium.org、gerc...@microsoft.com、Alex Russell

I see that various mandatory steps in chromestatus (privacy,security,enterprise,debuggability,testing) seems to be unstarted. It is possible they were made mandatory after you create the entry, but it would be good if you could get them started now at least.

Also, it's unfortunate that TAG and standards positions requests have not resulted in anything, but that is hardly your fault. There were some questions in the WebKit request. Is all that ok now?

/Daniel

Sahir Vellani

未讀,
2023年10月15日 下午2:07:232023/10/15
收件者:blink-dev、Daniel Bratell、mike...@chromium.org、gerc...@microsoft.com、Alex Russell、Sahir Vellani
Thanks for the feedback, I wasn't aware they were mandatory. The steps have been started, just awaiting feedback from Security and Privacy reviewers. I've received LGTMs for all other areas. After our response to WebKit's question, they did not have any further follow-up questions. So I'm assuming all is well.

Mike Taylor

未讀,
2023年10月16日 下午6:43:002023/10/16
收件者:Sahir Vellani、blink-dev、Daniel Bratell、gerc...@microsoft.com、Alex Russell

Yoav Weiss

未讀,
2023年10月17日 清晨7:16:412023/10/17
收件者:Mike Taylor、Sahir Vellani、blink-dev、Daniel Bratell、gerc...@microsoft.com、Alex Russell
On Tue, Oct 17, 2023 at 12:42 AM Mike Taylor <mike...@chromium.org> wrote:

LGTM1

On 10/15/23 11:07 AM, 'Sahir Vellani' via blink-dev wrote:
Thanks for the feedback, I wasn't aware they were mandatory. The steps have been started, just awaiting feedback from Security and Privacy reviewers. I've received LGTMs for all other areas. After our response to WebKit's question, they did not have any further follow-up questions. So I'm assuming all is well.

On Wednesday, October 11, 2023 at 4:59:15 AM UTC-7 Daniel Bratell wrote:

I see that various mandatory steps in chromestatus (privacy,security,enterprise,debuggability,testing) seems to be unstarted. It is possible they were made mandatory after you create the entry, but it would be good if you could get them started now at least.

Also, it's unfortunate that TAG and standards positions requests have not resulted in anything, but that is hardly your fault. There were some questions in the WebKit request. Is all that ok now?

/Daniel

On 2023-10-06 20:10, 'Sahir Vellani' via blink-dev wrote:

Is there a more formal spec for this?
Any support outside of Microsoft that would enable y'all to move this to the WICG?
 

Mike Taylor

未讀,
2023年10月18日 上午11:55:052023/10/18
收件者:Yoav Weiss、Sahir Vellani、blink-dev、Daniel Bratell、gerc...@microsoft.com、Alex Russell

Apologies, I missed that there wasn't yet a spec. I'll retract my LGTM until then.

Alex Russell

未讀,
2023年10月18日 上午11:55:432023/10/18
收件者:blink-dev、Yoav Weiss、sahir....@microsoft.com、blink-dev、Daniel Bratell、gerc...@microsoft.com、Alex Russell、Mike Taylor、ann...@microsoft.com
I agree that this needs a spec PR and the explainer should at least migrate to WICG before we agree to ship. Also, can you please link to the TAG review?

Best,

Alex

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

Sahir Vellani

未讀,
2024年1月11日 下午6:08:161月11日
收件者:blink-dev、sligh...@chromium.org、yoav...@chromium.org、Sahir Vellani、blink-dev、Daniel Bratell、gerc...@microsoft.com、Alex Russell、mike...@chromium.org、ann...@microsoft.com
Hi all, good news!

Reviving this thread because we have accomplished:
2. WICG Repository for standardization discussions. Link to explainer in WICG Repo:  pointer-event-extensions/pointer-event-device-id-explainer.md at main · WICG/pointer-event-extensions (github.com)
3. A PR against the PointerEvent spec with proposed changes:  Add deviceId to PointerEvent spec by sahirv · Pull Request #495 · w3c/pointerevents (github.com) We will be waiting for Spec Level 3 to come out before this can be merged; but this provides an official starting point for the standardized description of this feature. Based on the feedback received, I don't anticipate any major changes to the design.

Reviewers, can we please get another review for shipping this feature?

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Vladimir Levin

未讀,
2024年1月17日 上午9:51:591月17日
收件者:Sahir Vellani、blink-dev、sligh...@chromium.org、yoav...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、mike...@chromium.org、ann...@microsoft.com
On Thu, Jan 11, 2024 at 6:08 PM 'Sahir Vellani' via blink-dev <blin...@chromium.org> wrote:
Hi all, good news!

Reviving this thread because we have accomplished:
2. WICG Repository for standardization discussions. Link to explainer in WICG Repo:  pointer-event-extensions/pointer-event-device-id-explainer.md at main · WICG/pointer-event-extensions (github.com)
3. A PR against the PointerEvent spec with proposed changes:  Add deviceId to PointerEvent spec by sahirv · Pull Request #495 · w3c/pointerevents (github.com) We will be waiting for Spec Level 3 to come out before this can be merged; but this provides an official starting point for the standardized description of this feature. Based on the feedback received, I don't anticipate any major changes to the design.

For posterity, I was initially unsure why this wasn't an issue on the w3c/pointerevents, but it does seem like the discussion happened there and folks agreed to move this in WICG: https://github.com/w3c/pointerevents/issues/353 \o/

Yoav Weiss (@Shopify)

未讀,
2024年1月17日 上午10:39:481月17日
收件者:blink-dev、vmp...@google.com、blink-dev、Alex Russell、Yoav Weiss、Daniel Bratell、gerc...@microsoft.com、Alex Russell、Mike Taylor、ann...@microsoft.com、sahir....@microsoft.com
On Wednesday, January 17, 2024 at 3:51:59 PM UTC+1 vmp...@google.com wrote:
On Thu, Jan 11, 2024 at 6:08 PM 'Sahir Vellani' via blink-dev <blin...@chromium.org> wrote:
Hi all, good news!

Reviving this thread because we have accomplished:
2. WICG Repository for standardization discussions. Link to explainer in WICG Repo:  pointer-event-extensions/pointer-event-device-id-explainer.md at main · WICG/pointer-event-extensions (github.com)
3. A PR against the PointerEvent spec with proposed changes:  Add deviceId to PointerEvent spec by sahirv · Pull Request #495 · w3c/pointerevents (github.com) We will be waiting for Spec Level 3 to come out before this can be merged; but this provides an official starting point for the standardized description of this feature. Based on the feedback received, I don't anticipate any major changes to the design.

Thanks for the PR! Was it reviewed by other WG members?
For example, "User agents MAY reserve a generic `deviceId` value of `0` or `1` for events generated by the primary mouse device." seems risky from an interop perspective. E.g. developers may rely on some UAs doing that and fail when others don't.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

Sahir Vellani

未讀,
2024年1月18日 下午3:05:171月18日
收件者:blink-dev、yoav...@chromium.org、vmp...@google.com、blink-dev、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、mike...@chromium.org、ann...@microsoft.com、Sahir Vellani
Appreciate the feedback! Yes the PR was reviewed by WG members for any major concerns; but I believe there will be more comprehensive feedback once the Level 3 spec lands. Regarding your concern, the language is based on that of PointerEvent.pointerId. The ultimate goal here is to differentiate between devices, and like pointerId, the way the ids are assigned has been left to the UA. I think web developers should be able to rely on PointerEvent.pointerType to confirm whether the pointer event comes from the primary mouse device. In Chromium, we transmit 1 for the mouse for PointerEvent.deviceId.

Mike Taylor

未讀,
2024年1月18日 晚上9:26:201月18日
收件者:Sahir Vellani、blink-dev、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、ann...@microsoft.com

Forgive my ignorance around this API generally, but is there any reason the spec can't require a single value? If not, why not?

Sahir Vellani

未讀,
2024年1月18日 晚上11:40:001月18日
收件者:blink-dev、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、ann...@microsoft.com、Sahir Vellani
I can't say what the reasoning is for that behavior in PointerEvent.pointerId, as I was not involved. However, I will make a change in the spec to only use the value of 1 for primary mouse device.
There may be a scenario where PointerEvent.deviceId is unsupported by the UA (separate from an invalid id of -1); e.g, on platforms where the feature is unimplemented. In that case, developers might have a check like if(event.deviceId) {...}. If the deviceId is 0 for a valid reason, it will fail that check. I see no harm in limiting the deviceId from primary mouse to 1. It will avoid this interop issue and make the feature more friendly to web developers.

Sahir Vellani

未讀,
2024年1月18日 晚上11:44:581月18日
收件者:blink-dev、Sahir Vellani、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、ann...@microsoft.com
Just to clarify, I've made the change in the deviceId verbiage in the spec, not pointerId :)

Sahir Vellani

未讀,
2024年1月23日 中午12:15:511月23日
收件者:blink-dev、Sahir Vellani、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、ann...@microsoft.com
Hi all, any more questions or concerns?

Robert Flack

未讀,
2024年1月23日 下午1:01:111月23日
收件者:Sahir Vellani、blink-dev、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell
FWIW, in the PEWG call last week there was some question of how this relates to the pen customizations proposal. I suppose the general question is whether this should be an additional part of some hardware specific device customization in pointerEvent.penCustomizationsDetails. I think there is a risk of shipping this without consensus on the general shape, as it will make it harder to change if it's decided there's a better way to expose the information without breaking existing uses. We should probably take the API that has been incubated and bring it back for discussion in the working group.

On Tue, Jan 23, 2024 at 12:15 PM 'Sahir Vellani' via blink-dev <blin...@chromium.org> wrote:
Hi all, any more questions or concerns?

On Thursday, January 18, 2024 at 8:44:58 PM UTC-8 Sahir Vellani wrote:
Just to clarify, I've made the change in the deviceId verbiage in the spec, not pointerId :)

On Thursday, January 18, 2024 at 8:40:00 PM UTC-8 Sahir Vellani wrote:
I can't say what the reasoning is for that behavior in PointerEvent.pointerId, as I was not involved. However, I will make a change in the spec to only use the value of 1 for primary mouse device.
There may be a scenario where PointerEvent.deviceId is unsupported by the UA (separate from an invalid id of -1); e.g, on platforms where the feature is unimplemented. In that case, developers might have a check like if(event.deviceId) {...}. If the deviceId is 0 for a valid reason, it will fail that check. I see no harm in limiting the deviceId from primary mouse to 1. It will avoid this interop issue and make the feature more friendly to web developers.

0 was originally reserved to mean a non-pointer device. This was discussed in https://github.com/w3c/pointerevents/issues/343 where we discovered that Firefox has, and continues to use 0 for mouse pointer events where chrome and safari use 1.

Rick Byers

未讀,
2024年1月23日 下午2:00:581月23日
收件者:Robert Flack、Sahir Vellani、blink-dev、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell
This is a pretty niche and tiny addition which matters a lot to probably a couple websites in the world, and not at all to everyone else. It's a shame that it's taken over a year of discussion on what to ship. Worst case and we get this wrong and have something better in the future, I can't imagine it would be hard to change over and deprecate this. Sahir, do you agree? If so, I don't think it's a good use of resources to spend a lot more time debating this tiny addition, the stakes are IMHO not high here.

However, I definitely think we want to give PEWG a fair chance to weigh in on the spec PR. The PR was just filed 2 weeks ago, so maybe another week delay to wait for feedback on it is reasonable? Rob, can you get this on the agenda for the next PEWG call and indicate that I think Chromium should just ship it as-is unless there's a concrete counter-proposal in the next couple weeks?

Rick


Robert Flack

未讀,
2024年1月23日 下午2:01:051月23日
收件者:Sahir Vellani、blink-dev、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell
On Tue, Jan 23, 2024 at 1:00 PM Robert Flack <fla...@chromium.org> wrote:
FWIW, in the PEWG call last week there was some question of how this relates to the pen customizations proposal. I suppose the general question is whether this should be an additional part of some hardware specific device customization in pointerEvent.penCustomizationsDetails. I think there is a risk of shipping this without consensus on the general shape, as it will make it harder to change if it's decided there's a better way to expose the information without breaking existing uses. We should probably take the API that has been incubated and bring it back for discussion in the working group.

I've raised this for discussion to try to reach consensus on the general idea. I also realize my comment comes across more critical than I meant it to be. There is risk to locking in the current proposal, but I also suspect we'd be able to make a breaking change if needed, so I did not intend my comment to be blocking. Apologies!

Robert Flack

未讀,
2024年1月23日 下午2:04:011月23日
收件者:Rick Byers、Sahir Vellani、blink-dev、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell
On Tue, Jan 23, 2024 at 2:00 PM Rick Byers <rby...@chromium.org> wrote:
This is a pretty niche and tiny addition which matters a lot to probably a couple websites in the world, and not at all to everyone else. It's a shame that it's taken over a year of discussion on what to ship. Worst case and we get this wrong and have something better in the future, I can't imagine it would be hard to change over and deprecate this. Sahir, do you agree? If so, I don't think it's a good use of resources to spend a lot more time debating this tiny addition, the stakes are IMHO not high here.

However, I definitely think we want to give PEWG a fair chance to weigh in on the spec PR. The PR was just filed 2 weeks ago, so maybe another week delay to wait for feedback on it is reasonable? Rob, can you get this on the agenda for the next PEWG call and indicate that I think Chromium should just ship it as-is unless there's a concrete counter-proposal in the next couple weeks?

Absolutely! Happy to!

Sahir Vellani

未讀,
2024年1月23日 下午2:26:321月23日
收件者:blink-dev、fla...@chromium.org、blink-dev、mike...@chromium.org、yoav...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、Sahir Vellani
Thanks Rick and Robert! 

Rick, I agree that it would be relatively easy to change/deprecate deviceId. There are not too many devices at the moment that support multiple pens, and not many web apps either. I think the cost to the websites of not having Chrome support this for the foreseeable future is greater than changing where the deviceId gets read from. The Pen Customizations api looks quite cool, although deviceId is more generic.

Robert, I'm happy to wait a week or two more for the PEWG to discuss this further. Thanks for putting deviceId in the agenda, and of course we can rework this if a more appropriate alternative is proposed. :)

Yoav Weiss (@Shopify)

未讀,
2024年1月31日 上午11:33:251月31日
收件者:blink-dev、sahir....@microsoft.com、Robert Flack、blink-dev、Mike Taylor、Yoav Weiss、vmp...@google.com、Alex Russell、Daniel Bratell、gerc...@microsoft.com、Alex Russell
Thanks for chiming in, Robert!

Sahir - can you let us know once the PEWG has discussed this and you feel this is good to go?

Robert Flack

未讀,
2024年2月1日 下午3:33:462月1日
收件者:Yoav Weiss (@Shopify)、Sahir Vellani、Rick Byers、blink-dev、Mike Taylor、vmp...@google.com、Alex Russell、Daniel Bratell、gerc...@microsoft.com、Alex Russell
We just discussed this yesterday where the consensus was that we thought it would be pragmatic to put this new device specific identifier into a common structure on the pointer event where other device specific customizations could later be added (e.g. those from the pen customizations proposal). This avoids needing to have new properties on the pointer event for each device specific customization attribute added.

Another question that came up was how universal this customization was, i.e. whether there would be support for this on other platforms.

@Sahir Vellani would you be able to suggest what you think the best structure name / property name for pointer specific identifier properties might be?

I do agree with @Rick Byers that this is likely a niche API which we'll likely be able to change, I'm just trying to get ahead of breaking changes early.

Sahir Vellani

未讀,
2024年2月1日 下午4:31:242月1日
收件者:blink-dev、fla...@chromium.org、blink-dev、mike...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、yoav...@chromium.org、Sahir Vellani、rby...@chromium.org
Thanks for the update Robert! That makes sense. 

What about deviceProperties? That would place the emphasis on the device generating the pointer event; with "properties" being generic enough to include different supported functions of the device. So we would have something like PointerEvent.deviceProperties.deviceId/PointerEvent.deviceProperties.preferredInkingColor etc.

Would you be able to clarify the next steps once the structure name has been agreed upon? I believe we'll need to update the explainer, spec PR and change the chromium implementation. Anything else?

Robert Flack

未讀,
2024年2月12日 上午9:53:302月12日
收件者:Sahir Vellani、blink-dev、mike...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、yoav...@chromium.org、rby...@chromium.org
I think deviceProperties is reasonable. The other question was when deviceId would be populated? E.g. should touches on the same touchscreen device have the same deviceId or should we only have a deviceId when we can uniquely identify the particular pointer? I suspect maybe the latter since otherwise you couldn't infer uniqueness from its existence.

Could you comment on the pointerevents issue so that the context is there for the next meeting? I'll request that it be discussed again.

On Thu, Feb 1, 2024 at 4:31 PM 'Sahir Vellani' via blink-dev <blin...@chromium.org> wrote:
Thanks for the update Robert! That makes sense. 

What about deviceProperties? That would place the emphasis on the device generating the pointer event; with "properties" being generic enough to include different supported functions of the device. So we would have something like PointerEvent.deviceProperties.deviceId/PointerEvent.deviceProperties.preferredInkingColor etc.

Would you be able to clarify the next steps once the structure name has been agreed upon? I believe we'll need to update the explainer, spec PR and change the chromium implementation. Anything else? 

This sounds good.

Sahir Vellani

未讀,
2024年5月7日 中午12:39:345月7日
收件者:blink-dev、fla...@chromium.org、blink-dev、mike...@chromium.org、vmp...@google.com、sligh...@chromium.org、Daniel Bratell、gerc...@microsoft.com、Alex Russell、yoav...@chromium.org、rby...@chromium.org、Sahir Vellani
Hi all, re-opening this thread. The feature has been re-implemented based on the PEWG feedback and guidance. Here is a quick summary of changes -
- The PR against spec has received lots of fruitful discussion and feedback, and is now in a stable state. We do not anticipate any further breaking changes to the uniqueId API.
- PointerEvent.deviceId has been changed to PointerEvent.deviceProperties.uniqueId. There is no longer a reserved id for the mouse pointer. Invalid id is 0 instead of -1. The discussion and reasoning behind all changes can be found in the spec PR.
- WPT tests have been implemented for this feature.
- The feature has been verified by our partners via Origin Trial

Any oppositions to this being shipped in Chromium?

sahir.vellani via Chromestatus

未讀,
2024年5月8日 下午5:00:385月8日
收件者:blin...@chromium.org
This is ready for another review :)

Dan Clark

未讀,
2024年5月8日 晚上9:10:485月8日
收件者:blink-dev、sahir.vellani via Chromestatus
A non-blocking comment: now that the syntax has been changed I think it would be great if you could update the Explainer and the Mozilla and WebKit requests-for-position to reduce potential for confusion.

Also, is there a reason the spec PR is still in Draft status? Could it be published so that there's no ambiguity for reviewers that this is (hopefully) moving forward imminently?

-- Dan

Sahir Vellani

未讀,
2024年5月8日 晚上10:14:315月8日
收件者:blink-dev、dan...@microsoft.com、sahir.vellani via Chromestatus
I've published the spec PR. Since I can't update the links in the original comment of this thread, I'd like to link the updated explainer here for visibility.  pointer-event-extensions/pointer-event-device-id-explainer.md at main · WICG/pointer-event-extensions (github.com)
I have added comments to both request-for-positions informing of the changes to the API. 
Thanks for your comments Dan!

Jeffrey Yasskin

未讀,
2024年5月9日 上午11:48:425月9日
收件者:Sahir Vellani、Ben Mathwig、blink-dev、dan...@microsoft.com、sahir.vellani via Chromestatus
If you've moved the explainer, could you replace the content of https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/PointerEventDeviceId/explainer.md with a pointer to the new location? Then people who follow the old links won't be confused. You can and should also update the links in https://github.com/w3ctag/design-reviews/issues/880, and @Ben Mathwig should update the links in https://github.com/mozilla/standards-positions/issues/715 and https://github.com/WebKit/standards-positions/issues/102.

Thanks,
Jeffrey

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Jeffrey Yasskin

未讀,
2024年5月9日 上午11:51:025月9日
收件者:Jeffrey Yasskin、Sahir Vellani、Ben Mathwig、blink-dev、dan...@microsoft.com、sahir.vellani via Chromestatus
Oops, Ben's not at Microsoft anymore, so you've done the best you can with the Mozilla and WebKit position requests. Thanks.

Sahir Vellani

未讀,
2024年5月9日 下午3:23:445月9日
收件者:blink-dev、jyas...@chromium.org、Sahir Vellani、Ben Mathwig、blink-dev、dan...@microsoft.com、sahir.vellani via Chromestatus
Done! I've updated the explainer as well as the links in the TAG review.

Chris Harrelson

未讀,
2024年5月15日 中午12:02:525月15日
收件者:Sahir Vellani、blink-dev、jyas...@chromium.org、Ben Mathwig、dan...@microsoft.com、sahir.vellani via Chromestatus
Hi,

I see the spec PR is still pending. Is there a reason it can't land before shipping?

Sahir Vellani

未讀,
2024年5月15日 中午12:40:065月15日
收件者:blink-dev、Chris Harrelson、blink-dev、jyas...@chromium.org、Ben Mathwig、dan...@microsoft.com、sahir.vellani via Chromestatus、Sahir Vellani、fla...@chromium.org
From my understanding, we need to wait for the PointerEvents spec V3 to be published before the PR can be merged; this change is slated for the 4th iteration of the spec.

Yoav Weiss (@Shopify)

未讀,
2024年5月16日 凌晨3:41:275月16日
收件者:Sahir Vellani、blink-dev、Chris Harrelson、jyas...@chromium.org、Ben Mathwig、dan...@microsoft.com、sahir.vellani via Chromestatus、fla...@chromium.org
On Wed, May 15, 2024 at 6:40 PM 'Sahir Vellani' via blink-dev <blin...@chromium.org> wrote:
From my understanding, we need to wait for the PointerEvents spec V3 to be published before the PR can be merged; this change is slated for the 4th iteration of the spec.

That's an odd work mode. Do all other feature extensions just wait in PRs up until publishing?
Even for specs that still work with levels, I'd expect "current" and "future" branches, where future PRs can be merged to the "future" one as they're ready..

With that said, it seems like there's still active discussion on the PR. Could we get to a state where it's reviewed by relevant folks that sign off on it before shipping?
I agree we shouldn't wait for arbitrary publishing points before shipping, but a spec review would help ensure that what we're shipping is well defined.
   

Robert Flack

未讀,
2024年5月16日 下午4:05:425月16日
收件者:Yoav Weiss (@Shopify)、Patrick H. Lauke、Sahir Vellani、blink-dev、Chris Harrelson、jyas...@chromium.org、Ben Mathwig、dan...@microsoft.com、sahir.vellani via Chromestatus
I believe the reason for waiting is that the intention is to switch to a different publishing model after level 3 is published? @Patrick H. Lauke to confirm.

Yoav Weiss (@Shopify)

未讀,
2024年5月17日 凌晨2:00:205月17日
收件者:Robert Flack、Patrick H. Lauke、Sahir Vellani、blink-dev、Chris Harrelson、jyas...@chromium.org、Ben Mathwig、dan...@microsoft.com、sahir.vellani via Chromestatus
On Thu, May 16, 2024 at 10:05 PM Robert Flack <fla...@chromium.org> wrote:
I believe the reason for waiting is that the intention is to switch to a different publishing model after level 3 is published? @Patrick H. Lauke to confirm.

Other than publishing mechanics, was the PR reviewed and good to go?

Patrick H. Lauke

未讀,
2024年5月17日 上午10:13:165月17日
收件者:Robert Flack、Yoav Weiss (@Shopify)、Sahir Vellani、blink-dev、Chris Harrelson、jyas...@chromium.org、Ben Mathwig、dan...@microsoft.com、sahir.vellani via Chromestatus


On 16/05/2024 21:05, Robert Flack wrote:
> I believe the reason for waiting is that the intention is to switch to a
> different publishing model after level 3 is published? @Patrick H. Lauke
> <mailto:re...@splintered.co.uk> to confirm.

Apologies for the convoluted model here ... I have to admit that I'm
actually not sure what the expected way of working around this is, as
Pointer Events has been such a "slow and steady" process so far, with a
very linear way of working - it's only now that we're just hoping to get
PE3 to REC and then had this extra functionality come in that we've hit
this snag. I will check with Philippe at W3C to work out what the best
way forward here is (have the "frozen" version that makes its way
through the steps to REC, while being able to already have a
"future/next" branch).

P
--
Patrick H. Lauke

* https://www.splintered.co.uk/
* https://github.com/patrickhlauke
* https://flickr.com/photos/redux/
* https://mastodon.social/@patrick_h_lauke

Yoav Weiss (@Shopify)

未讀,
2024年5月22日 下午4:30:485月22日
收件者:Patrick H. Lauke、Robert Flack、Sahir Vellani、blink-dev、Chris Harrelson、jyas...@chromium.org、dan...@microsoft.com、sahir.vellani via Chromestatus
OK, thanks for outlining the spec mechanics :)

Regardless of whether the PR actually lands in the spec, for the purpose of risk-assessment, it's even more interesting to know if the PR is *ready* to land in the spec.
Can y'all clarify its review status? If it's ready to land, can a spec editor approve it, even if it doesn't land until later?

Robert Flack

未讀,
2024年5月23日 上午10:00:385月23日
收件者:Yoav Weiss (@Shopify)、Patrick H. Lauke、Sahir Vellani、blink-dev、Chris Harrelson、jyas...@chromium.org、dan...@microsoft.com、sahir.vellani via Chromestatus
There were some fresh concerns raised about the shape of the spec PR which are being hashed out on that review thread. I will give it approval once we reach a consensus there.
回覆所有人
回覆作者
轉寄
0 則新訊息