--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeTMg3-RVWOKRnKQ7OTzbHcLXpVoVrVdRGO6Kr-x6XhBAw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABc02_KZ34VfewpFpvGab-_JOOfjSEQ26HvFV-NR9JL4L-SY_Q%40mail.gmail.com.
LGTM1
On Thu, May 28, 2020 at 3:51 AM PhistucK <phis...@gmail.com> wrote:
Sounds like even after this change, there will still not be 100% interoperability with Safari, or did I misunderstand?The risks section is quite confusing.☆PhistucK
On Thu, May 28, 2020 at 12:47 PM Rune Lillesveen <fut...@chromium.org> wrote:
--CSSWG resolution: https://github.com/w3c/csswg-drafts/issues/3881#issuecomment-634799613The color-scheme property from CSS Color Adjustment level 1 spec changed in two ways. 1. The 'only' keyword is no longer special and is treated as a <custom-ident> as any other unknown color-scheme. The 'only' keyword was previously only allowed in combination with 'light', but had otherwise no effect in Chrome. 2. 'color-scheme: dark' will have a used value of 'dark' even when the preferred color-scheme is 'light'. 'color-scheme: light dark' still has a used value based on the preferred scheme. The spec has changed which allows page authors to use dark themed UA rendering even when the preferred color-scheme is 'light'. The new behavior is: color-scheme: light -> always light color-scheme: dark -> always dark color-scheme: light dark -> select the preferred scheme This means content which always has a dark theme in their CSS will be able to match that with dark themed UA controls. It also improves interoperability with WebKit which already had this behavior for 'color-scheme: dark'.Aligns with WebKit. There is an interoperability risk not to ship this. Compatibility: For 'only': the parser will be more admissive and allow color-scheme with 'only' where we previously would drop the declaration. For instance this will now be accepted with only being ignored as an unknown color-scheme: color-scheme: light dark only For 'color-scheme: dark': Previously this was equivalent to 'color-scheme: light dark' in Chrome. There is a chance that authors who want to support both light and dark have used this as a pattern. However, the current effect is limited since we have not yet shipped dark themed UA controls, only initial color and default viewport background. Firefox: Mixed public signals Mozilla were originally opposed to support a used 'dark' value when the preferred scheme was 'light' because user agents using system form control rendering would not be able to use dark themed controls when the system preference was a light, which led to the spec originally being written as it was. The plan for Firefox is to move away from system controls: https://github.com/w3c/csswg-drafts/issues/3881#issuecomment-634463620 From the CSSWG meeting notes for this resolution: "emilio: uneasy about overwriting user preference. Not really objecting" Edge: No public signals (but fremy@ argued for this when the color-scheme property was initially introduced. The use case mentioned was applications like VS Code which is typically dark when the OS theme is light and would benefit from being able to have dark themed controls).Safari: Shipped 'only' still has a separate meaning in Safari for opting out of UA color transformations. Web developers: No signals Limited usefulness before CSSColorSchemeUARendering is enabled.Yes Yes As part of shipping this, existing tests in wpt css/css-color-adjust will be modified to match the current spec draft. https://crbug.com/1087115 https://chromestatus.com/feature/5653721679659008This intent message was generated by Chrome Platform Status.
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeTMg3-RVWOKRnKQ7OTzbHcLXpVoVrVdRGO6Kr-x6XhBAw%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
Sounds like even after this change, there will still not be 100% interoperability with Safari, or did I misunderstand?The risks section is quite confusing.
LGTM3
/Daniel
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeQFq%2Bkp3%2BKrmN_OobPkKzZfb9kM3o%2BLZ%3DMumMmqUxM_tg%40mail.gmail.com.
That resolution was on the assumption that the prefers-color-scheme's
no-preference value would go away as resolved in [1].
Is there any intention to change that as well anytime soon? Asking
because at least to me both resolutions seem related, and it'd be sad to
leave the spec in a state where it makes sense, but where
implementations don't, or vice versa.