Intent to Deprecate and Remove: -webkit-box-flex-group, -webkit-box-lines, % values of -webkit-line-clamp

147 visningar
Hoppa till det första olästa meddelandet

ikilp...@chromium.org

oläst,
5 mars 2018 16:48:522018-03-05
till blink-dev

Primary eng (and PM) emails

ikilp...@chromium.org


Summary

This intent to remove covers 3 different properties from the -webkit-box display type.


-webkit-box-flex-group - This property has virtually zero usage based on the UseCounter on stable. There is still -webkit-box-flex which is used widely.


% values of -webkit-line-clamp - Fun fact! Most people use -webkit-line-clamp with a single number, this has relatively high usage. It can actually accept % values as well. There is interest in finding a standards based solution to the number values usecase, but we haven’t seen demand for the %-based values. Based on the UseCounter, this has virtually zero usage.


-webkit-box-lines - This property was never fully implemented. It was originally intended such that a “vertical”/”horizontal” -webkit-box can have multiple rows/columns. The only effect it has today is to switch to a broken intrinsic size calculation. (It will use the vertical intrinsic size calculation for a horizontal -webkit-box, ¯\_(ツ)_/¯). We think that this has slightly higher usage as people think it's necessary for using -webkit-line-clamp.


Motivation

We desire to eventually move the -webkit-box implementation over to the flex implementation with a few switches. This is what Firefox and Edge do today. Removing these properties allows us to incrementally move towards this.


Interoperability and Compatibility Risk

We think this has low interop and compat risk, due to the low usage.


Edge: Edge does have an implementation/flexbox-mapping of -webkit-box, but these properties/values aren’t supported.

Firefox: Firefox does have an implementation/flexbox-mapping of -webkit-box, but these properties/values aren’t supported.

Safari: Supported.


Please include links where possible.


Alternative implementation suggestion for web developers

Unlike -webkit-line-clamp which has high usage, these properties were never used widely by web developers.


Usage information from UseCounter

See above.


OWP launch tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=818691


Entry on the feature dashboard

No entry as this shouldn’t have any impact on web developers.


Requesting approval to remove too?

Yes - the plan is the remove immediately. We don’t think the deprecation will add value given the low usage of the properties.


Rick Byers

oläst,
5 mars 2018 20:40:222018-03-05
till Ian Kilpatrick, blink-dev
LGTM1

Is it worth adding negative test cases to WPT somewhere so that it will be clear WebKit is now an outlier in supporting these?

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e324609a-f30d-4afd-b08f-5b19d0c6841c%40chromium.org.

PhistucK

oläst,
6 mars 2018 02:55:272018-03-06
till Ian Kilpatrick, blink-dev
Feature dashboard entries feed the beta blog posts, which mention removals, so I think it should have an entry.


PhistucK

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

Ojan Vafai

oläst,
6 mars 2018 11:31:022018-03-06
till PhistucK, Ian Kilpatrick, blink-dev
Lgtm2

Agree this should have chromestatus entry. 

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.

TAMURA, Kent

oläst,
8 mars 2018 19:06:472018-03-08
till Ojan Vafai, PhistucK, Ian Kilpatrick, blink-dev
LGTM3.


Lgtm2

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABc02_%2BUDOgurhFisu%3D5o4ta0Y-UCHM5RcxBti3xgyYpXNjDoA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.



--
TAMURA Kent
Software Engineer, Google


Florian Rivoal

oläst,
8 mars 2018 19:58:292018-03-08
till TAMURA, Kent, Ojan Vafai, PhistucK, Ian Kilpatrick, blink-dev
Hi,

No issue with this at all.

I just wanted to let you know that Fantasai and I just drafted a tentative solution for a standard version of (-webkit-)line-clamp. I guess this should be of interest to people working on this. 


Feedback about the design, as well as about web compat constraints very much welcome.

—Florian

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqHe%3DOHWaQq4o_U1bFq5wvun68gEGtpGy6iLOYRSLC1G7g%40mail.gmail.com.

Ian Kilpatrick

oläst,
8 mars 2018 20:23:272018-03-08
till Florian Rivoal, TAMURA, Kent, Ojan Vafai, PhistucK, blink-dev
Svara alla
Svara författaren
Vidarebefordra
0 nya meddelanden