Ask googlers to use https://github.com/explainers-by-googlers for explainers. [website : main]
Jeffrey Yasskin (Gerrit)
Jeffrey Yasskin has uploaded this change for review.
Ask googlers to use https://github.com/explainers-by-googlers for explainers.
Also point Microsoft folks at their explainer repo, and invite other orgs to
tell us about theirs.
For googlers, a full design doc is at go/chrome-explainers-org-dd.
Change-Id: I5cc23ad9525d42c0012d0e0462582139714cba83
---
M site/blink/launching-features/index.md
1 file changed, 14 insertions(+), 4 deletions(-)
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Jeffrey Yasskin (Gerrit)
Attention is currently required from: Alex Russell, Chris Wilson, Mike Taylor.
Patch set 1:Commit-Queue +1
1 comment:
Patchset:
We shouldn't merge this until https://github.com/explainers-by-googlers/template/pull/1 is merged, but I think we can overlap the review.
Alex, did I give the right instructions to Microsofties?
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Jeffrey Yasskin (Gerrit)
Attention is currently required from: Alex Russell, Chris Wilson, Mike Taylor.
Jeffrey Yasskin would like Chris Wilson, Mike Taylor and Alex Russell to review this change.
Ask googlers to use https://github.com/explainers-by-googlers for explainers.
Also point Microsoft folks at their explainer repo, and invite other orgs to
tell us about theirs.
For googlers, a full design doc is at go/chrome-explainers-org-dd.
Change-Id: I5cc23ad9525d42c0012d0e0462582139714cba83
---
M site/blink/launching-features/index.md
1 file changed, 14 insertions(+), 4 deletions(-)
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Jeffrey Yasskin (Gerrit)
Attention is currently required from: Alex Russell, Mike Taylor, Vladimir Levin.
1 comment:
File site/blink/launching-features/index.md:
Patch Set #1, Line 173:
* Google: put your explainer in <https://github.com/explainers-by-googlers>.I find it hard to judge where this wording fits on a scale of "opportunity" or "recommendation" or " […]
It's meant to be a "should" level recommendation rather than a hard requirement. I could reorder it to soften it some. E.g.
```
Then host your explainer at a public URL. Some organizations recommend
specific places:
* Google: <https://github.com/explainers-by-googlers>
* Microsoft: <https://github.com/MicrosoftEdge/MSEdgeExplainers>
* If your organization has an area for explainers, [send us a
patch](https://source.chromium.org/chromium/chromium/src/+/main:docs/website/docs/CONTRIBUTING.md)
to describe it here.Otherwise, a public personal Github repo typically works well. Then put
a link to your public explainer in the feature entry.
```
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Chris Wilson (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin, Mike Taylor.
Patch set 1:Code-Review +1
Vladimir Levin (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin, Mike Taylor.
Patch Set #1, Line 173:
* Google: put your explainer in <https://github.com/explainers-by-googlers>.
I find it hard to judge where this wording fits on a scale of "opportunity" or "recommendation" or "requirement".
"If you're writing the explainer for Google, put your explainer here" sounds like a requirement. Is that correct?
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Vladimir Levin (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin, Mike Taylor.
1 comment:
File site/blink/launching-features/index.md:
Patch Set #1, Line 173:
* Google: put your explainer in <https://github.com/explainers-by-googlers>.
It's meant to be a "should" level recommendation rather than a hard requirement. […]
That sounds good to me. Thanks
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Jeffrey Yasskin (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin, Mike Taylor.
Jeffrey Yasskin uploaded patch set #2 to this change.
Ask googlers to use https://github.com/explainers-by-googlers for explainers.
Also point Microsoft folks at their explainer repo, and invite other orgs to
tell us about theirs.
For googlers, a full design doc is at go/chrome-explainers-org-dd.
Change-Id: I5cc23ad9525d42c0012d0e0462582139714cba83
---
M site/blink/launching-features/index.md
1 file changed, 12 insertions(+), 4 deletions(-)
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Mike Taylor (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin.
Patch set 2:Code-Review +1
Jeffrey Yasskin (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin.
Jeffrey Yasskin uploaded patch set #3 to this change.
Ask googlers to use https://github.com/explainers-by-googlers for explainers.
Also point Microsoft folks at their explainer repo, and invite other orgs to
tell us about theirs.
For googlers, a full design doc is at go/chrome-explainers-org-dd.
DO_NOT_SUBMIT: until b/313644840 is fixed.
Change-Id: I5cc23ad9525d42c0012d0e0462582139714cba83
---
M site/blink/launching-features/index.md
1 file changed, 12 insertions(+), 4 deletions(-)
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Jeffrey Yasskin (Gerrit)
Attention is currently required from: Alex Russell, Jeffrey Yasskin.
Jeffrey Yasskin uploaded patch set #4 to this change.
Ask googlers to use https://github.com/explainers-by-googlers for explainers.
Also point Microsoft folks at their explainer repo, and invite other orgs to
tell us about theirs.
For googlers, a full design doc is at go/chrome-explainers-org-dd.
Change-Id: I5cc23ad9525d42c0012d0e0462582139714cba83
---
M site/blink/launching-features/index.md
1 file changed, 12 insertions(+), 4 deletions(-)
To view, visit change 5067942. To unsubscribe, or for help writing mail filters, visit settings.
Jeffrey Yasskin (Gerrit)
chromium-website-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
chromium-we...@luci-project-accounts.iam.gserviceaccount.com submitted this change.
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Ask googlers to use https://github.com/explainers-by-googlers for explainers.
Also point Microsoft folks at their explainer repo, and invite other orgs to
tell us about theirs.
For googlers, a full design doc is at go/chrome-explainers-org-dd.
Change-Id: I5cc23ad9525d42c0012d0e0462582139714cba83
Reviewed-on: https://chromium-review.googlesource.com/c/website/+/5067942
Reviewed-by: Dirk Pranke <dpr...@google.com>
Reviewed-by: Chris Wilson <cwi...@google.com>
Commit-Queue: Jeffrey Yasskin <jyas...@google.com>
Reviewed-by: Mike Taylor <mike...@chromium.org>
---
M site/blink/launching-features/index.md
1 file changed, 12 insertions(+), 4 deletions(-)