There were some offline discussions about this, but on reflection I wonder if there is a relatively simple decision tree that we can try out. How about this:If your feature meets these conditions, a TAG review can be skipped:* The feature is already specified by a standards body* The feature is shipped in at least one other browser, or the feature is already more-or-less shipped in Chrome and this is just fixing it to improve spec compliance or correctness, or the feature is a new or improved syntax for an existing feature
Otherwise you need to submit a TAG review.Hypothetical examples that don't need TAG:1. Shipping colors: super-bright, where Firefox already shipped it and it's in a spec.2. Unprefixing colors: -webkit-super-bright where there is a colors: super-bright spec that is basically the same as -webkit-super-bright, and no other browser implements it.3. Fixing a corner case of colors: super-bright to improve interop or spec compliance4. Shipping colors: super-duper-bright because the spec body decided that's better than colors: super-bright and the latter is already shipped in at least one browser.However you'd need a TAG review in this situation:1. Shipping colors: super-bright because the CSSWG agreed to put in a spec, and colors: super-bright is only 20 lines of code that bumps up brightness by 10%. TAG review is required here because it has not shipped in any browser.I added this example because it seems one where there would be disagreement about whether a TAG review in this case is a waste of time.
--Chris
You received this message because you are subscribed to the Google Groups "blink-api-owners-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-api-owners-d...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CA%2BN6QZsLhZU3MkbKPh%3DTS30gz5jzULd0%3DnWY6PTOaG_NKSjzXg%40mail.gmail.com.
Thank you for the draft decision tree.On Tue, Aug 25, 2020 at 8:08 AM Chris Harrelson <chri...@chromium.org> wrote:There were some offline discussions about this, but on reflection I wonder if there is a relatively simple decision tree that we can try out. How about this:If your feature meets these conditions, a TAG review can be skipped:* The feature is already specified by a standards body* The feature is shipped in at least one other browser, or the feature is already more-or-less shipped in Chrome and this is just fixing it to improve spec compliance or correctness, or the feature is a new or improved syntax for an existing featureThis sounds reasonable.Does a TAG review work well for a feature removal?
Otherwise you need to submit a TAG review.Hypothetical examples that don't need TAG:1. Shipping colors: super-bright, where Firefox already shipped it and it's in a spec.2. Unprefixing colors: -webkit-super-bright where there is a colors: super-bright spec that is basically the same as -webkit-super-bright, and no other browser implements it.3. Fixing a corner case of colors: super-bright to improve interop or spec compliance4. Shipping colors: super-duper-bright because the spec body decided that's better than colors: super-bright and the latter is already shipped in at least one browser.However you'd need a TAG review in this situation:1. Shipping colors: super-bright because the CSSWG agreed to put in a spec, and colors: super-bright is only 20 lines of code that bumps up brightness by 10%. TAG review is required here because it has not shipped in any browser.I added this example because it seems one where there would be disagreement about whether a TAG review in this case is a waste of time.These examples are very helpful. We should publish them!
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CA%2BN6QZtqn9WCExYopyDsebWDYbVeiRRcnE4SMO9AVvrf%2Bym85w%40mail.gmail.com.