Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Add note about TAG reviews that take too long [website : main]

380 views
Skip to first unread message

Jeffrey Yasskin (Gerrit)

unread,
Mar 6, 2024, 2:59:42 PM3/6/24
to Chris Harrelson, blink-api-ow...@chromium.org, Jeffrey Yasskin
Attention needed from Chris Harrelson and Noam Rosenthal

Noam Rosenthal has uploaded the change for review

Jeffrey Yasskin would like Chris Harrelson to review this change authored by Noam Rosenthal.

Commit message

Add note about TAG reviews that take too long
Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401

Change diff

diff --git a/site/blink/launching-features/index.md b/site/blink/launching-features/index.md
index 7bbc692..a21723e 100644
--- a/site/blink/launching-features/index.md
+++ b/site/blink/launching-features/index.md
@@ -314,6 +314,9 @@
this at least a month ahead of sending an Intent to Ship, to give the TAG
sufficient time for meaningful feedback.

+ Note that if the TAG review takes long and the design is being matured elsewhere, to the point where a TAG review would no longer be helpful,
+ it's best to notify the TAG team so that they can close the issue and prioritze other issues.
+
#### Step 5 (Optional): Origin Trial {:#origin-trials}

If you want to gather data on the usability of your feature that an [Origin

Change information

Files:
  • M site/blink/launching-features/index.md
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Noam Rosenthal
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 2
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Attention: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
unsatisfied_requirement
open
diffy

Jeffrey Yasskin (Gerrit)

unread,
Mar 6, 2024, 2:59:43 PM3/6/24
to Noam Rosenthal, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Noam Rosenthal

Jeffrey Yasskin added 3 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jeffrey Yasskin . resolved

Hi API owners. This came up around https://github.com/w3ctag/design-reviews/issues/886#issuecomment-1953174126, where the WHATWG discussion had come to consensus in the 6 months since the TAG review was filed, and that discussion already covered the concerns the TAG raised. There were some improvements our team could have made to their explainer to prevent the TAG's concerns, which this change doesn't intend to cover.

This change is about how and when to tell the TAG that a design is frozen, and so it's not worth their time to review it any more. I'm not sure Noam's change or my suggestions convey that exactly right, and I'd love to hear more opinions.

File site/blink/launching-features/index.md
Line 317, Patchset 2 (Latest): Note that if the TAG review takes long and the design is being matured elsewhere, to the point where a TAG review would no longer be helpful,
Jeffrey Yasskin . unresolved

I think we should be more specific about what indicates that a TAG review would no longer be helpful. Perhaps:

```suggestion
Note that if the TAG takes several months to review the feature,
and during that time the implementations and relevant standards
bodies find consensus on the feature, the TAG's review might not
be able to influence the design anymore. If that happens,
```
Line 381, Patchset 2 (Latest):If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
Jeffrey Yasskin . unresolved

We might also want to say something here about "if the TAG has _not_ commented"...


```suggestion
If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
If the TAG has _not_ commented, then after your I2S is approved, it's courteous
to post to the review saying that Chromium considers the feature stable, and
any future suggestions will need to come with stronger justifications.
```

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Noam Rosenthal
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 2
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Attention: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Wed, 06 Mar 2024 19:59:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Mar 6, 2024, 3:26:19 PM3/6/24
to Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Jeffrey Yasskin

Noam Rosenthal added 2 comments

File site/blink/launching-features/index.md
Line 317, Patchset 2 (Latest): Note that if the TAG review takes long and the design is being matured elsewhere, to the point where a TAG review would no longer be helpful,
Jeffrey Yasskin . resolved

I think we should be more specific about what indicates that a TAG review would no longer be helpful. Perhaps:

```suggestion
Note that if the TAG takes several months to review the feature,
and during that time the implementations and relevant standards
bodies find consensus on the feature, the TAG's review might not
be able to influence the design anymore. If that happens,
```
Noam Rosenthal

Fix applied.

Line 381, Patchset 2 (Latest):If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
Jeffrey Yasskin . resolved

We might also want to say something here about "if the TAG has _not_ commented"...


```suggestion
If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
If the TAG has _not_ commented, then after your I2S is approved, it's courteous
to post to the review saying that Chromium considers the feature stable, and
any future suggestions will need to come with stronger justifications.
```

Noam Rosenthal

Fix applied.

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Jeffrey Yasskin
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 2
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Attention: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Comment-Date: Wed, 06 Mar 2024 20:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeffrey Yasskin <jyas...@google.com>
unsatisfied_requirement
open
diffy

David Baron (Gerrit)

unread,
Mar 6, 2024, 3:26:23 PM3/6/24
to Noam Rosenthal, David Baron, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Jeffrey Yasskin

David Baron added 2 comments

File site/blink/launching-features/index.md
Line 318, Patchset 2: it's best to notify the TAG team so that they can close the issue and prioritze other issues.
David Baron . unresolved
Drop the word "team", and fix spelling of "prioritize".
```suggestion
it's best to notify the TAG so that they can close the issue and prioritize other issues.
```
Line 381, Patchset 2:If the TAG has commented on your review, and the state of the review is anything

other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
Jeffrey Yasskin . unresolved

We might also want to say something here about "if the TAG has _not_ commented"...


```suggestion
If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
If the TAG has _not_ commented, then after your I2S is approved, it's courteous
to post to the review saying that Chromium considers the feature stable, and
any future suggestions will need to come with stronger justifications.
```

David Baron

I think the last phrase in this suggestion might be a bit awkward (in that it seems to be telling the TAG what to do rather than telling them what the Chromium project will do). Perhaps instead of "any future suggestions will need to come with stronger justifications" maybe something like "future proposals for changes will be weighed against the compatibility risk of changing a shipping feature".

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Jeffrey Yasskin
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 2
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Attention: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Comment-Date: Wed, 06 Mar 2024 20:18:16 +0000
unsatisfied_requirement
open
diffy

Jeffrey Yasskin (Gerrit)

unread,
Mar 6, 2024, 3:35:06 PM3/6/24
to Noam Rosenthal, David Baron, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Noam Rosenthal

Jeffrey Yasskin added 1 comment

File site/blink/launching-features/index.md
Line 381, Patchset 2:If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
Jeffrey Yasskin . unresolved

We might also want to say something here about "if the TAG has _not_ commented"...


```suggestion
If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
If the TAG has _not_ commented, then after your I2S is approved, it's courteous
to post to the review saying that Chromium considers the feature stable, and
any future suggestions will need to come with stronger justifications.
```

David Baron

I think the last phrase in this suggestion might be a bit awkward (in that it seems to be telling the TAG what to do rather than telling them what the Chromium project will do). Perhaps instead of "any future suggestions will need to come with stronger justifications" maybe something like "future proposals for changes will be weighed against the compatibility risk of changing a shipping feature".

Jeffrey Yasskin

That sounds better to me too.

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Noam Rosenthal
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 3
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Wed, 06 Mar 2024 20:35:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Baron <dba...@chromium.org>
Comment-In-Reply-To: Jeffrey Yasskin <jyas...@google.com>
unsatisfied_requirement
open
diffy

Mike Taylor (Gerrit)

unread,
Mar 6, 2024, 5:05:30 PM3/6/24
to Noam Rosenthal, David Baron, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Noam Rosenthal

Mike Taylor voted and added 1 comment

Votes added by Mike Taylor

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mike Taylor . resolved

This LGTM, incorporating dbaron's suggestions.

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 3
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Wed, 06 Mar 2024 22:05:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Mar 7, 2024, 6:11:19 AM3/7/24
to Mike Taylor, David Baron, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson, David Baron and Jeffrey Yasskin

Noam Rosenthal added 3 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Noam Rosenthal . resolved

Applied comments. @jyas...@google.com do you mind taking a last look before I CQ?

File site/blink/launching-features/index.md
Line 318, Patchset 2: it's best to notify the TAG team so that they can close the issue and prioritze other issues.
David Baron . resolved
Drop the word "team", and fix spelling of "prioritize".
```suggestion
it's best to notify the TAG so that they can close the issue and prioritize other issues.
```
Noam Rosenthal

Done

Line 381, Patchset 2:If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
Jeffrey Yasskin . resolved

We might also want to say something here about "if the TAG has _not_ commented"...


```suggestion
If the TAG has commented on your review, and the state of the review is anything
other than [`Resolution:
satisfied`](https://github.com/w3ctag/design-reviews/issues?q=is%3Aissue+label%3A%22Resolution%3A+satisfied%22),
the API Owners should be able to see evidence that you've seriously and
comprehensively engaged with their comments, and tried to resolve any concerns.
If the TAG has _not_ commented, then after your I2S is approved, it's courteous
to post to the review saying that Chromium considers the feature stable, and
any future suggestions will need to come with stronger justifications.
```

David Baron

I think the last phrase in this suggestion might be a bit awkward (in that it seems to be telling the TAG what to do rather than telling them what the Chromium project will do). Perhaps instead of "any future suggestions will need to come with stronger justifications" maybe something like "future proposals for changes will be weighed against the compatibility risk of changing a shipping feature".

Jeffrey Yasskin

That sounds better to me too.

Noam Rosenthal

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • David Baron
  • Jeffrey Yasskin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 8
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: David Baron <dba...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Attention: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 10:41:49 +0000
satisfied_requirement
open
diffy

Jeffrey Yasskin (Gerrit)

unread,
Mar 7, 2024, 11:43:07 AM3/7/24
to Noam Rosenthal, Mike Taylor, David Baron, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Noam Rosenthal

Jeffrey Yasskin added 1 comment

File site/blink/launching-features/index.md
Line 317, Patchset 2: Note that if the TAG review takes long and the design is being matured elsewhere, to the point where a TAG review would no longer be helpful,
Jeffrey Yasskin . unresolved

I think we should be more specific about what indicates that a TAG review would no longer be helpful. Perhaps:

```suggestion
Note that if the TAG takes several months to review the feature,
and during that time the implementations and relevant standards
bodies find consensus on the feature, the TAG's review might not
be able to influence the design anymore. If that happens,
```
Noam Rosenthal

Fix applied.

Jeffrey Yasskin

This got lost again in patchset 4. 🙃

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 8
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Thu, 07 Mar 2024 16:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Noam Rosenthal <nrose...@chromium.org>
Comment-In-Reply-To: Jeffrey Yasskin <jyas...@google.com>
satisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Mar 7, 2024, 12:42:00 PM3/7/24
to Mike Taylor, David Baron, Chris Harrelson, Jeffrey Yasskin, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Jeffrey Yasskin

Noam Rosenthal added 1 comment

File site/blink/launching-features/index.md
Line 317, Patchset 2: Note that if the TAG review takes long and the design is being matured elsewhere, to the point where a TAG review would no longer be helpful,
Jeffrey Yasskin . unresolved

I think we should be more specific about what indicates that a TAG review would no longer be helpful. Perhaps:

```suggestion
Note that if the TAG takes several months to review the feature,
and during that time the implementations and relevant standards
bodies find consensus on the feature, the TAG's review might not
be able to influence the design anymore. If that happens,
```
Noam Rosenthal

Fix applied.

Jeffrey Yasskin

This got lost again in patchset 4. 🙃

Noam Rosenthal

Drat, gerrit editing UI... trying again.

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Jeffrey Yasskin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 9
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Attention: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 17:41:53 +0000
satisfied_requirement
open
diffy

Jeffrey Yasskin (Gerrit)

unread,
Mar 7, 2024, 12:45:13 PM3/7/24
to Noam Rosenthal, Jeffrey Yasskin, Mike Taylor, David Baron, Chris Harrelson, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson and Noam Rosenthal

Jeffrey Yasskin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 9
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Thu, 07 Mar 2024 17:45:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Mar 8, 2024, 4:45:07 AM3/8/24
to Jeffrey Yasskin, Mike Taylor, David Baron, Chris Harrelson, Tricium, blink-api-ow...@chromium.org
Attention needed from Chris Harrelson

Noam Rosenthal voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 9
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@chromium.org>
Gerrit-CC: David Baron <dba...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Fri, 08 Mar 2024 09:44:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

chromium-website-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Mar 8, 2024, 4:45:11 AM3/8/24
to Noam Rosenthal, Jeffrey Yasskin, Mike Taylor, David Baron, Chris Harrelson, Tricium, blink-api-ow...@chromium.org
Commit message:
Add note about TAG reviews that take too long
Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Reviewed-by: Mike Taylor <mike...@chromium.org>
Commit-Queue: Noam Rosenthal <nrose...@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyas...@google.com>
Files:
  • M site/blink/launching-features/index.md
Change size: S
Delta: 1 file changed, 10 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mike Taylor, +1 by Jeffrey Yasskin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I85fbf359e5797356af6257aa99cc37847f3ec401
Gerrit-Change-Number: 5349100
Gerrit-PatchSet: 10
Gerrit-Owner: Noam Rosenthal <nrose...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages