Add recommendation to link to blink-dev in CLs turning on features, to make them easier to review and more transparent. [website : main]

364 views

Skip to first unread message

chromium-website-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Feb 26, 2024, 8:58:16 PM2/26/24

to Chris Harrelson, Jeffrey Yasskin, Tricium

chromium-we...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: site/blink/launching-features/index.md
Insertions: 13, Deletions: 0.

@@ -492,6 +492,9 @@
 
 Once you have the needed approvals, set the implementation status to "Enabled by default" in
 ChromeStatus.
+You will likely also need to land a Chromium CL to turn on the feature.
+Link to the blink-dev thread via the [Google Groups web interface](https://groups.google.com/a/chromium.org/g/blink-dev)
+in your CL's commit message to make it easy and clear to review.
 
 ### Feature deprecations
 
@@ -680,6 +683,11 @@
 that their LGTMs still apply. Otherwise, you can keep following your approved
 plan without new LGTMs.
 
+You will likely also need to land a Chromium CL to turn on the feature.
+Link to the blink-dev thread via the [Google Groups web interface](https://groups.google.com/a/chromium.org/g/blink-dev)
+in your CL's commit message to make it easy and clear to review.
+
+
 #### Step 7: Disable the feature {:#disable-feature}
 
 Disable the feature by default. Update ChromeStatus to either “Disabled” or
@@ -771,6 +779,11 @@
 guidelines](https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md),
 which generally allow for some discretion for trivial changes.
 
+You will likely also need to land a Chromium CL to turn on the feature.
+Link to the blink-dev thread via the [Google Groups web interface](https://groups.google.com/a/chromium.org/g/blink-dev)
+in your CL's commit message to make it easy and clear to review.
+
+
 You may wish to use [Finch](http://go/finch) to increase confidence in the new
 code as you deploy it.
 
```

Change information

Commit message:

Add recommendation to link to blink-dev in CLs turning on features, to make them easier to review and more transparent.

Change-Id: Ifa3db99cb29375d62b852d1d511814a7e05da345

Reviewed-on: https://chromium-review.googlesource.com/c/website/+/5325349

Reviewed-by: Jeffrey Yasskin <jyas...@google.com>

Commit-Queue: Chris Harrelson <chri...@chromium.org>

Files:

M site/blink/launching-features/index.md

Change size: S

Delta: 1 file changed, 16 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Jeffrey Yasskin

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages