Process for removing C++ APIs from third_party/blink/public/platform/platform.h

[Sam Zackrisson]

Hi,

I am maintaining code including two small C++ APIs in Blink's public/platform/ folder:

1) blink::Platform::GetWebRTCAudioProcessingConfiguration() [1]
2) blink::Platform::GetAgcStartupMinimumVolume() [2]

Is there any process or PSA necessary before removing functions like these, since they live in public/?

Details

These APIs were not intended to be exposed for wide usage.

• #1 was added without any real understanding of the possible implications of having code living in public/ (my bad).
• #2 is an abstraction of a commandline flag, added as part of onion souping code in content/ into blink/.
• Neither feature was announced in any way, not is it in any way accessible via web APIs in the way covered by https://www.chromium.org/blink/launching-features#TOC-Feature-deprecations.
  

I am in contact with the client that API #1 was added for, and they are no longer using it.
The existence of these APIs complicates ongoing work to move some blink code into media/.

Kind regards

Sam

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/platform/platform.h;l=668;drc=d2f37a73b35d282c9b8aa553f01faa1bfbf453c8;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/platform/platform.h;l=699;drc=d2f37a73b35d282c9b8aa553f01faa1bfbf453c8;bpv=1;bpt=0

[Daniel Bratell]

Not really. "Public" in this case is an artifact of when Blink was a black box with an external C++ API using non-Blink types and doesn't mean that they are exposed to the web developers.

So you just need to make sure they are unused and get a code review and then you are done.

/Daniel

--
You received this message because you are subscribed to the Google Groups "blink-api-owners-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-api-owners-d...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CADYPCULw_4ac8hVJu2MZbJ9qCNj6JqmvB7LQucE1icknOxYVBw%40mail.gmail.com.

[Mike West]

+1 to Daniel's comments.

Blink's public API surface is not web-exposed, nor is it something we consider to be a reasonable embedding layer (embedders will have a much better time using the APIs exposed at //content/public). If we don't need a particular Blink //public/platform API anymore, you should feel free to remove it without any approvals other than normal code-review.

-mike

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/51e56e90-d257-8b43-4956-104725bb9fb9%40gmail.com.

[Sam Zackrisson]

Thank you both, that clarifies (and simplifies) things a bit.

- Sam