Merge the TAG and Standards-Positions exceptions into a single section, and add a summary of TAG review. [website : main]
85 views
Skip to first unread message
Jeffrey Yasskin (Gerrit)
Dec 23, 2024, 7:15:56 PM12/23/24
to Jeffrey Yasskin
Jeffrey Yasskin has uploaded the change for review![]( "Open in Gerrit")
Commit message
Merge the TAG and Standards-Positions exceptions into a single section, and add a summary of TAG review.
Change-Id: Ia6d9a51822f1a6ed92381f7daf19bd237c36bb8a
Change diff
Change information
Files:
- M site/blink/guidelines/api-owners/process-exceptions/index.md
- M site/blink/launching-features/index.md
- M site/blink/launching-features/wide-review/index.md
Change size: M
Delta: 3 files changed, 99 insertions(+), 88 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yasskin (Gerrit)
Dec 23, 2024, 7:30:54 PM12/23/24
to Chris Harrelson, blink-api-ow...@chromium.org, Jeffrey Yasskin
Attention needed from Chris Harrelson
Jeffrey Yasskin has uploaded the change for review![]( "Open in Gerrit")
Jeffrey Yasskin would like Chris Harrelson to review this change.
Commit message
Merge the TAG and Standards-Positions exceptions into a single section, and add a summary of TAG review.
This changes a few of the exceptions in minor ways:
* Adds Khronos standards to the TAG exceptions. They were already in the standards-position exceptions.
* Narrows "An exception was granted by consensus of the Blink API owners" for TAG reviews to apply to small features, which matches the discussion when it was added (https://groups.google.com/a/chromium.org/g/blink-dev/c/naqmDmy1iM8/m/lQAJ17CRAQAJ) and the similar exception for standards-position requests.
* Moves the "exception" for TAG specification review to the description of how to request TAG reviews: it wasn't saying not to get a review, just refining how to ask for it.
Change-Id: Ia6d9a51822f1a6ed92381f7daf19bd237c36bb8a
Change diff
Change information
Files:
- M site/blink/guidelines/api-owners/process-exceptions/index.md
- M site/blink/launching-features/index.md
- M site/blink/launching-features/wide-review/index.md
Change size: M
Delta: 3 files changed, 100 insertions(+), 88 deletions(-)
Related details
Attention is currently required from:
- Chris Harrelson
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Dec 27, 2024, 1:32:54 PM12/27/24
to Jeffrey Yasskin, Code Review Nudger, chromium-websi...@chops-service-accounts.iam.gserviceaccount.com, blink-api-ow...@chromium.org
Attention needed from Jeffrey Yasskin
Chris Harrelson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jeffrey Yasskin
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yasskin
Jan 6, 2025, 2:48:47 PMJan 6
to blink-api-ow...@chromium.org
Hi Blink API owners,
I wanted to make sure you had a chance to review this after the holidays, since I sent it just before Christmas.
I'll merge it on Wednesday unless I hear back before that.
Thanks,
Jeffrey
Mike Taylor
Jan 6, 2025, 3:02:08 PMJan 6
to Jeffrey Yasskin, blink-api-owners-discuss
Thanks Jeffrey - it wasn't clear to me it was a request to review
(since Chris was added as reviewer and approved already). Will
take a look.
--
You received this message because you are subscribed to the Google Groups "blink-api-owners-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-api-owners-d...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CANh-dXnRm0fRr%2BQr_bMmQw-pG3%3D%2BLunuLGjzaUcT4Ys5-M4CAA%40mail.gmail.com.
Mike Taylor (Gerrit)
Jan 6, 2025, 3:07:08 PMJan 6
to Jeffrey Yasskin, Chris Harrelson, Code Review Nudger, chromium-websi...@chops-service-accounts.iam.gserviceaccount.com, blink-api-ow...@chromium.org
Attention needed from Jeffrey Yasskin
Mike Taylor voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike Taylor
| Code-Review | +1 |
1 comment
File site/blink/launching-features/wide-review/index.md
Line 13, Patchset 3 (Latest):
every Intent-to-Ship has to show what external stakeholders (in particular theMike Taylor . unresolved
optional nit (I don't care much about capitalization, but this seems more consistent with the rest of the page)
```suggestion
every intent to ship has to show what external stakeholders (in particular the
```
Related details
Attention is currently required from:
- Jeffrey Yasskin
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yasskin (Gerrit)
Jan 6, 2025, 3:40:47 PMJan 6
to Jeffrey Yasskin, Mike Taylor, Chris Harrelson, Code Review Nudger, chromium-websi...@chops-service-accounts.iam.gserviceaccount.com, blink-api-ow...@chromium.org
Jeffrey Yasskin added 1 comment![]( "Open in Gerrit")
File site/blink/launching-features/wide-review/index.md
Line 13, Patchset 3 (Latest):
every Intent-to-Ship has to show what external stakeholders (in particular theMike Taylor . resolved
optional nit (I don't care much about capitalization, but this seems more consistent with the rest of the page)
```suggestion
every intent to ship has to show what external stakeholders (in particular the
```
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-website-try-builder@chops-service-accounts.iam.gserviceaccount.com (Gerrit)
Jan 6, 2025, 3:42:24 PMJan 6
to Jeffrey Yasskin, Mike Taylor, Chris Harrelson, Code Review Nudger, blink-api-ow...@chromium.org
Attention needed from Jeffrey Yasskin
Message from chromium-websi...@chops-service-accounts.iam.gserviceaccount.com![]( "Open in Gerrit")
Preview this change at https://chromium-website--cl6121106-ps4-xzim6vw5.web.app
Related details
Attention is currently required from:
- Jeffrey Yasskin
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yasskin
Jan 6, 2025, 3:43:24 PMJan 6
to Mike Taylor, blink-api-owners-discuss
Yes, sorry for being unclear. Nobody extra _needs_ to review this (since Chris H did already), but I wanted to make sure that everyone who _wants_ to review it has a chance. Thanks for your review, Mike!
Yoav Weiss (@Shopify) (Gerrit)
Jan 7, 2025, 5:56:04 AMJan 7
to Jeffrey Yasskin, Mike Taylor, Chris Harrelson, Code Review Nudger, chromium-websi...@chops-service-accounts.iam.gserviceaccount.com, blink-api-ow...@chromium.org
Attention needed from Jeffrey Yasskin
Yoav Weiss (@Shopify) voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yoav Weiss (@Shopify)
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jeffrey Yasskin
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yasskin (Gerrit)
Jan 8, 2025, 11:54:17 AMJan 8
to Jeffrey Yasskin, Yoav Weiss (@Shopify), Mike Taylor, Chris Harrelson, Code Review Nudger, chromium-websi...@chops-service-accounts.iam.gserviceaccount.com, blink-api-ow...@chromium.org
Jeffrey Yasskin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-website-try-builder@chops-service-accounts.iam.gserviceaccount.com (Gerrit)
Jan 8, 2025, 11:54:53 AMJan 8
to Jeffrey Yasskin, chromium-we...@luci-project-accounts.iam.gserviceaccount.com, Yoav Weiss (@Shopify), Mike Taylor, Chris Harrelson, Code Review Nudger, blink-api-ow...@chromium.org
Attention needed from Jeffrey Yasskin
Preview this change at https://chromium-website--cl6121106-ps4-xzim6vw5.web.app
Related details
Attention is currently required from:
- Jeffrey Yasskin
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-website-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jan 8, 2025, 11:55:07 AMJan 8
to Jeffrey Yasskin, Yoav Weiss (@Shopify), Mike Taylor, Chris Harrelson, Code Review Nudger, chromium-websi...@chops-service-accounts.iam.gserviceaccount.com, blink-api-ow...@chromium.org
chromium-we...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Merge the TAG and Standards-Positions exceptions into a single section, and add a summary of TAG review.
This changes a few of the exceptions in minor ways:
* Adds Khronos standards to the TAG exceptions. They were already in the standards-position exceptions.
* Narrows "An exception was granted by consensus of the Blink API owners" for TAG reviews to apply to small features, which matches the discussion when it was added (https://groups.google.com/a/chromium.org/g/blink-dev/c/naqmDmy1iM8/m/lQAJ17CRAQAJ) and the similar exception for standards-position requests.
* Moves the "exception" for TAG specification review to the description of how to request TAG reviews: it wasn't saying not to get a review, just refining how to ask for it.
Change-Id: Ia6d9a51822f1a6ed92381f7daf19bd237c36bb8a
Commit-Queue: Jeffrey Yasskin <jyas...@google.com>
Reviewed-by: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Reviewed-by: Mike Taylor <mike...@chromium.org>
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Files:
- M site/blink/guidelines/api-owners/process-exceptions/index.md
- M site/blink/launching-features/index.md
- M site/blink/launching-features/wide-review/index.md
Change size: M
Delta: 3 files changed, 100 insertions(+), 88 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mike Taylor, +1 by Yoav Weiss (@Shopify), +1 by Chris Harrelson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages